From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1B7247042F for ; Fri, 31 Jul 2026 18:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785522275; cv=none; b=Eiie+XX2U5FxE0fWKmc6+Pzexv28N/Fd0qaAA+P1NPqZQDUuD/eua3hRBzzb4wXKKzyRN2DhrHc5MN9bl1oBtvj8kQKyckEaeoDpJWUTploUg+CJe0bo1KMfxBd4NDI8fm+9lW9NWTC2nqvFLsctEPsWapDjTKk1+N2s7ECjY/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785522275; c=relaxed/simple; bh=j4VKKE2lbj9EIehEK9wJEP89gyl1CvgBqtl5SfvS28s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OfqZntPiDnGb66coBXbw0k2Rk7GntCZ9bddxGriUoGV41A1qGHWPnafkI7Dj07TsAy55YqOIhcf0W8JcXLd9thL2j3A52ePJEf4OvzM+uopUpIyXQD5NoAPPSMu+ER9UBtOxseb2eXeVhe4TCJaRLc7/570zOlnZvZzToelI+eg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fqOAVfux; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fqOAVfux" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-cb5b8572b70so1119510a12.2 for ; Fri, 31 Jul 2026 11:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785522272; x=1786127072; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gsS73bmDoxyOch7pFT+GXYXN7OXiaTwdO6oVVnU6ol0=; b=fqOAVfuxd0YXprlVo/1PwgPvj+ReaQ6VTQq+JkPfdW2JqjA5F50PTwsDtmEimu/KyM eLWsHh5YZDIZtsjDSM9FDWUyOOE+M35t174XHrq5Kr5D4GbvNgwuqmleau7zboDojkNR uP9si+NWBdq4UJjh/VMX2yDAHtwjLdkFZFhq0ZAZ5kmHSZbjxIMozECd3Q8xgyY95KXE DhLHCWfNZNDAVfoytuEeTDehrP59C/NwCxLDHjfAOO7U1FWMZFNMD2DAJsb3y/cZ51WL wkUMUrFz6G3Rr2DzUJ/pNtmVE6DK4HwLJaqG6NB6SH2Cr/yT9/wByIuph2qTRwsiW4eJ H2Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785522272; x=1786127072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=gsS73bmDoxyOch7pFT+GXYXN7OXiaTwdO6oVVnU6ol0=; b=hjDFdrXk7omKnf4fWkyTun6wET/RUl4aDzew01sokQoA65qD+uOtN1K+SLLI8xhc+l tvKPWObaA4UU+RNKLqAbCPXekpX4OdGnC3idMzz3rV9m+F1th7kAoNWN4LNsk+fSsvYx GTCJfzyRBCJRN9Dxgm7YcbxyxyCL/aNI+Emptk0oPJ0iEU1JA92OLrpGsQmX2ICHLycT HWoNAkyZEx8p+NMfWw/6qUKrfSdFBIIqKPGyPGWsRfoGcoRhcwTaBsaKWETRLoIQnzz6 LBNQruPsNHwnHKbEwlPoptoJVnG9Sr4b7z6QI3aG/yHiFh779ofMceVcoWqBrzthtTHH EZIA== X-Forwarded-Encrypted: i=1; AHgh+RrBxO8XU5/awKbmGJGpUc5MunyYCnM0XYSxzyCDs6sQA/VtT4aee+maFnQwCtZ3qNHvY7f9UGpsIn0Qvio=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9uKVIRyInUC+4sFgbR38Ke3/1gfB/kXrQmrTHc8BqafnhQcfY /SbtX1VukgfmpngHBU88YC3mTKpqbqdHud9UlqR6LO0Gd1wT1TiMBIqa X-Gm-Gg: AR+sD11eYZYbTyGda51vGdlYtxvddQEygwYO/1YQbuz/sJbEjnNAdyOJAL8wfx3usdf iab+Me1DARUkl7anD9ZadOgBl/4CF6ODPMGSnddylcw5NAhv7kJF9kXKS9C+oOPSH123I46wamb GVRbsQtUx0VGWtIDzGh/2qURhSvBUBW/6KR3DaQliuDSrgX1yQIIBbBofg5aw35JiaIWMIBeuPJ anQ3uwa0oqBQJ47sKW290vqeMgbCCJfmWlj50Pe6bGWQzYCoPy3odvmov+bJ37niJwDPQgaQHj0 NZSpSkmGWIiK0I8EPb1/d0uiqDQtFZrgb+5BWuGR7bg+ORmGbN1m3nJ1Kz9Or1QKs6W3haj2md5 OlzSTP3IMkQ0YaAuonqKSW9eQiTk0yXMjqYOsyzsN7a73uPzv4UTgu8cGOYROzJjIMoTxf7fysE oIAwJ+BZqOqQ6kalZzgZ3BDUHwGugz0KUymZV2XqRBYF9vnKHXjIWeSvGPI4Lq X-Received: by 2002:a05:6a21:6f13:b0:3c4:2a97:fd2 with SMTP id adf61e73a8af0-3c92a8757b4mr806736637.67.1785522272021; Fri, 31 Jul 2026 11:24:32 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:d69c:7f00:28b4:311c]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c1casm8400785eec.10.2026.07.31.11.24.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 11:24:31 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron , Andy Shevchenko Cc: Joshua Crofts , Broadcom internal kernel list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Mohammad Shahid Subject: [PATCH v3 2/3] iio: adc: bcm_iproc_adc: Introduce local device pointer Date: Fri, 31 Jul 2026 23:53:46 +0530 Message-ID: <20260731182347.42888-3-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731182347.42888-1-mdshahid03@gmail.com> References: <20260731182347.42888-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid Introduce a local 'struct device *dev' variable in iproc_adc_probe() and use it instead of repeatedly referencing '&pdev->dev'. This simplifies the code and makes subsequent error handling changes less verbose. No functional change intended. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c index 1b0dd654402f..29ea35972a23 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -506,9 +506,10 @@ static int iproc_adc_probe(struct platform_device *pdev) { struct iproc_adc_priv *adc_priv; struct iio_dev *indio_dev = NULL; + struct device *dev = &pdev->dev; int ret; - indio_dev = devm_iio_device_alloc(&pdev->dev, + indio_dev = devm_iio_device_alloc(dev, sizeof(*adc_priv)); if (!indio_dev) return -ENOMEM; @@ -523,14 +524,14 @@ static int iproc_adc_probe(struct platform_device *pdev) adc_priv->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "adc-syscon"); if (IS_ERR(adc_priv->regmap)) { - dev_err(&pdev->dev, "failed to get handle for tsc syscon\n"); + dev_err(dev, "failed to get handle for tsc syscon\n"); ret = PTR_ERR(adc_priv->regmap); return ret; } - adc_priv->adc_clk = devm_clk_get(&pdev->dev, "tsc_clk"); + adc_priv->adc_clk = devm_clk_get(dev, "tsc_clk"); if (IS_ERR(adc_priv->adc_clk)) { - dev_err(&pdev->dev, + dev_err(dev, "failed getting clock tsc_clk\n"); ret = PTR_ERR(adc_priv->adc_clk); return ret; @@ -543,11 +544,11 @@ static int iproc_adc_probe(struct platform_device *pdev) ret = regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, IPROC_ADC_AUXIN_SCAN_ENA); if (ret) { - dev_err(&pdev->dev, "failed to write IPROC_REGCTL2 %d\n", ret); + dev_err(dev, "failed to write IPROC_REGCTL2 %d\n", ret); return ret; } - ret = devm_request_threaded_irq(&pdev->dev, adc_priv->irqno, + ret = devm_request_threaded_irq(dev, adc_priv->irqno, iproc_adc_interrupt_handler, iproc_adc_interrupt_thread, IRQF_SHARED, "iproc-adc", indio_dev); @@ -556,14 +557,14 @@ static int iproc_adc_probe(struct platform_device *pdev) ret = clk_prepare_enable(adc_priv->adc_clk); if (ret) { - dev_err(&pdev->dev, + dev_err(dev, "clk_prepare_enable failed %d\n", ret); return ret; } ret = iproc_adc_enable(indio_dev); if (ret) { - dev_err(&pdev->dev, "failed to enable adc %d\n", ret); + dev_err(dev, "failed to enable adc %d\n", ret); goto err_adc_enable; } @@ -575,7 +576,7 @@ static int iproc_adc_probe(struct platform_device *pdev) ret = iio_device_register(indio_dev); if (ret) { - dev_err(&pdev->dev, "iio_device_register failed:err %d\n", ret); + dev_err(dev, "iio_device_register failed:err %d\n", ret); goto err_clk; } -- 2.43.0