From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00DBC455192 for ; Fri, 31 Jul 2026 18:24:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785522287; cv=none; b=J2C0XcVRkqpewVKTdlkc+mhPbyguFWuN6bJgiKQ37/IhF2Bgxrn6AHNRb/TQWPtqdAH1xQ/Sn8KzuCnDPkfpB/bvQL1PkEv5XWQ0mNO/kc3fFLRI1ZsqM9NghoVEJ7COXkavT90fWfTFpFUjjzvasvSqRMaRZjtLghYZ5CUWIOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785522287; c=relaxed/simple; bh=VD2QHojgachEtitvCMQ22pgLNRLQvtYqV1cce6F2O+o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Vk6VUSHI0iUlb3FVKGzWryzFeGMm2upodI07wzdk9Ac5Z1sgO5as74VSVthPUZ6CzPh10i0SVcDyKr9AXvsk4H64M9m67DvOcefbCJ8KuY9C2Bosxap9hKCOgqBTRsa7y0NLeUqkeJDhHe+Pg4ZS7z0L/XoL77UkTfIREtewXa0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lko9YkiT; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lko9YkiT" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38e3617ba36so1462335a91.3 for ; Fri, 31 Jul 2026 11:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785522282; x=1786127082; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=S96pVSc6qSK7JNjBnWVrJfF1KAwOzUVlXD18tkrIn6w=; b=lko9YkiTAslGn6X5mbMSTAL7xnSHkPC7oG6e5OEZQ9Gk2nBce5wfjEJIx5aPsQwaCU Rjy9frMFar0Q4xU26XtTcLzHh6p1jzD1hBrQdqBOknFrbxO2Jdsk0kfop/Yeew8ZzGeK 9N15s/VHiMXOwQWg2DAcDcxXFwB5LtD92rpCcFVSzHIua4t6P7mkYUN0P9wzN3r1mWgD cWY/8BbEdXTla8DX2vSbP8g9hrLLYid890zNT+fn+/NA3iUy/tU7Xyu+Ms0RnA0AzSAK 0q8IkTDFzbxY21TVH9DVjoBp6Mm8Lg0zTfRL2Ecrf7VemiS4WfZV61HI6FvBtKniADes lqhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785522282; x=1786127082; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=S96pVSc6qSK7JNjBnWVrJfF1KAwOzUVlXD18tkrIn6w=; b=YsOI01KtXVRShZ/bIyj7TmgVcykBCZbd971ixHra1uIqNprGjFCtSsVweof0ftWACe ySh6JXZ+7xyWWeG3BNM1JqPvTD+UVOIJ38Q5nxRS2rObCkpzECGP6kBDERx9Nv6lPo5e JQB/L64mhagi4SlM1Xql3F1VulqFqlt4yD7iKj07pKlaHWXvmlEy55N2xVzFCzADUj2h nuFzq+ae/KnY6O5eY8O96Wx+glRw+uU4txYyxjTqGGMYjysCvEg6GtpBnpDKuI0cSPK7 nIlbPeNYOdnjGfDPG+omel8il9ho7NrFurSJYk38Se+KXK5P+N4k7kBOXeYfHVQEOeQW rInw== X-Forwarded-Encrypted: i=1; AHgh+RoWitXs/VD5JWtueLbLAt4VIqI8RRoFhmoBPreQS51ipAmDR71YX2e8t9ZtDTUnXYMHl9zZivVoNcG/LhQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5kdFrl8S1rhbmifv3JtR+8BcwKxQI33ge2ngBfpO01nbp80z+ UJHssGqxqC+nhyiurUBN87QWVXZko9CAUCCsIMjKM1LvVhwM3SkrcT+d X-Gm-Gg: AR+sD10b1i2wfZI2VoyPAjc98R9q/Baa/ok8rG1V1Mh8jXH4lE6JAlUAt3aZYmZHrsB 9Sg5BPJjJWbQ8rz+YikH8CGl5T+MmeOiFXZyaaZybmKN8etkcGnOa0fteFFu6miKU/X/2vGtbbs LLiGcBo5qzI00307vbUeJVHXiBeco4T2OYwuhES7m43dnnU8JEf+zyT/b7qNJBFzHjGeCL3x0oa rVk8eKlmj0KsUamZb9flP94J5QchjOEfusZC+o3H+cl8ctm6DxX8fBog2O59uiy/VYyHTCi152y jAd3dGBQ62hc8nJGj+kv5rTiKiouUe22mRmhRbnEtnhAT/F3TUCtUQHRGBgsLKy8mUkesnX4uzA WeYhL/iIz+woMfPU72KQem5i6pUd/iA0X9AXXzZlx+RvB8XaFkdofiPd+xojqNNzFoAlSmmuT9+ fhQeir+WgDY16MbKedjHR3BEgk6osm+lpZuJu+Sfe8Wkz0LVr8ABOIkjIeDwI= X-Received: by 2002:a17:903:3886:b0:2ca:feb:303b with SMTP id d9443c01a7336-2d052429193mr8562495ad.25.1785522282316; Fri, 31 Jul 2026 11:24:42 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:d69c:7f00:28b4:311c]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9c1casm8400785eec.10.2026.07.31.11.24.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 11:24:41 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron , Andy Shevchenko Cc: Joshua Crofts , Broadcom internal kernel list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Mohammad Shahid Subject: [PATCH v3 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() Date: Fri, 31 Jul 2026 23:53:47 +0530 Message-ID: <20260731182347.42888-4-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731182347.42888-1-mdshahid03@gmail.com> References: <20260731182347.42888-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid This simplifies the probe error handling by replacing open-coded dev_err() and return sequences. Also remove the redundant dev_err() after iproc_adc_enable(), as the helper already reports the failure. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 43 +++++++++++++++------------------ 1 file changed, 19 insertions(+), 24 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c index 29ea35972a23..5fcd528eb88a 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -523,19 +523,16 @@ static int iproc_adc_probe(struct platform_device *pdev) adc_priv->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "adc-syscon"); - if (IS_ERR(adc_priv->regmap)) { - dev_err(dev, "failed to get handle for tsc syscon\n"); - ret = PTR_ERR(adc_priv->regmap); - return ret; - } + if (IS_ERR(adc_priv->regmap)) + return dev_err_probe(dev, + PTR_ERR(adc_priv->regmap), + "failed to get handle for tsc syscon\n"); adc_priv->adc_clk = devm_clk_get(dev, "tsc_clk"); - if (IS_ERR(adc_priv->adc_clk)) { - dev_err(dev, - "failed getting clock tsc_clk\n"); - ret = PTR_ERR(adc_priv->adc_clk); - return ret; - } + if (IS_ERR(adc_priv->adc_clk)) + return dev_err_probe(dev, + PTR_ERR(adc_priv->adc_clk), + "failed getting clock tsc_clk\n"); adc_priv->irqno = platform_get_irq(pdev, 0); if (adc_priv->irqno < 0) @@ -543,10 +540,10 @@ static int iproc_adc_probe(struct platform_device *pdev) ret = regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, IPROC_ADC_AUXIN_SCAN_ENA); - if (ret) { - dev_err(dev, "failed to write IPROC_REGCTL2 %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, + ret, + "failed to write IPROC_REGCTL2\n"); ret = devm_request_threaded_irq(dev, adc_priv->irqno, iproc_adc_interrupt_handler, @@ -556,17 +553,14 @@ static int iproc_adc_probe(struct platform_device *pdev) return ret; ret = clk_prepare_enable(adc_priv->adc_clk); - if (ret) { - dev_err(dev, - "clk_prepare_enable failed %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, + ret, + "failed to enable clock\n"); ret = iproc_adc_enable(indio_dev); - if (ret) { - dev_err(dev, "failed to enable adc %d\n", ret); + if (ret) goto err_adc_enable; - } indio_dev->name = "iproc-static-adc"; indio_dev->info = &iproc_adc_iio_info; @@ -576,7 +570,8 @@ static int iproc_adc_probe(struct platform_device *pdev) ret = iio_device_register(indio_dev); if (ret) { - dev_err(dev, "iio_device_register failed:err %d\n", ret); + dev_err_probe(dev, ret, + "failed to register IIO device\n"); goto err_clk; } -- 2.43.0