From: Andrea Righi <arighi@nvidia.com>
To: Tejun Heo <tj@kernel.org>, David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>
Cc: Kuba Piecuch <jpiecuch@google.com>,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCHSET v3 sched_ext/for-7.3] sched_ext: Fix idle CPU state initialization and validation
Date: Fri, 31 Jul 2026 20:23:32 +0200 [thread overview]
Message-ID: <20260731182406.3166853-1-arighi@nvidia.com> (raw)
The built-in idle masks are initialized with all online CPUs marked idle, but
idle tracking currently starts only after sched_ext is fully enabled. This
leaves busy CPUs incorrectly advertised as idle during ops.init() and until
their next idle transition.
Moreover, the allowed_cpus selftest checks that a remotely selected CPU is no
longer present in the idle mask. An idle-to-idle re-pick can re-advertise the
CPU before the test performs this check, making the validation inherently racy.
Fix this by enabling built-in idle tracking before ops.init() and refreshing the
state of every online CPU under its rq lock. Early tracking updates the built-in
masks, while ops.update_idle() notifications remain suppressed until the
scheduler is fully enabled.
Also rework the allowed_cpus kselftest to replace the racy remote-CPU check with
a stable local invariant that relies on the newly reliable idle-mask state.
Changes in v3:
- Reuse the built-in idle-selection static key instead of introducing a
dedicated idle-tracking key (Kuba Piecuch)
- Check the local CPU-idle invariant from both ops.select_cpu() and
ops.enqueue() (Kuba Piecuch)
- Inspect the idle mask without modifying it and perform the check before
calling scx_bpf_select_cpu_and() (Kuba Piecuch)
- Link to v2: https://lore.kernel.org/all/20260731090334.2911948-1-arighi@nvidia.com/
Changes in v2:
- Move idle-mask initialization from the selftest into the sched_ext
core (Kuba Piecuch)
- Add a dedicated idle-tracking static key so transitions are tracked
before the scheduler is fully enabled (Kuba Piecuch)
- Rework the allowed_cpus selftest to validate the stable local CPU-idle
invariant
- Link to v1: https://lore.kernel.org/all/20260726064754.378671-1-arighi@nvidia.com/
Andrea Righi (2):
sched_ext: Initialize idle masks before ops.init()
selftests/sched_ext: Make allowed_cpus idle validation race-free
kernel/sched/ext/ext.h | 5 ++-
kernel/sched/ext/idle.c | 35 ++++++++++++++--
.../testing/selftests/sched_ext/allowed_cpus.bpf.c | 49 ++++++++++++++++++----
3 files changed, 78 insertions(+), 11 deletions(-)
next reply other threads:[~2026-07-31 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 18:23 Andrea Righi [this message]
2026-07-31 18:23 ` [PATCH 1/2] sched_ext: Initialize idle masks before ops.init() Andrea Righi
2026-08-02 19:19 ` Tejun Heo
2026-08-03 5:46 ` Andrea Righi
2026-07-31 18:23 ` [PATCH 2/2] selftests/sched_ext: Make allowed_cpus idle validation race-free Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731182406.3166853-1-arighi@nvidia.com \
--to=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=jpiecuch@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®