From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DC0A35E1C1 for ; Sat, 1 Aug 2026 06:45:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785566707; cv=none; b=VcvOkVtx4LX4BF0X2iYk4KFZGTOMi6iKQ3XNIwOKowfEY7tbHDjwCj4cBeqjteI0SBu+20fE8s1slb+axjWcYylEqa7JBaIY3waYQs63YEOP6IShRGrjSBg8sNuG7JdDRa2+ep8woA01PUC9yV0K60UTzQq6oBsZGmtuka94OoE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785566707; c=relaxed/simple; bh=Talog+0/N6j8EQ1PakpJ6H88zNB0v5H7GMdas4bX7vU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NV/FUabi41eizvYLdUKLkltsfHIynzcXsOxGZSNkweECoBtIkQwHM9RCI5KgSIG1M6FnZYy/ZOsIP40lkTnkeXIs6STZsJPLxhw1tmoIm2mWH6FSm9WKn52YkD9kGIWuTFK8SMOkyM8gFYrePAXp29kPQtCVSqyf3OhbhCMrn3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FuSHQqp0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NTIoERBQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FuSHQqp0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NTIoERBQ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6713C4fY2944367 for ; Sat, 1 Aug 2026 06:45:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Gy//CsWuz2yFFMSMOowYorOjj1Lc1O2Hpen8MYG/G6w=; b=FuSHQqp0K8t1xWMM UdLd1dDN4uSn9FjKY7Y3blIoeNXY+W98GamApn1MIFeXBaXWTp9fhOCsRClKJo+6 oJzvEoXv58v35yUjoPhRtAji3i7istuf38dS3jzzbZ/Pi/pFNN8U6niX9FeMZCMC A7QDVFP5Z/yD+xqairo6gZDlw/Z6pLUvEgsFezXgh4fD1XXpRBC1CdJSwjdbrtz+ 5IVFS0e1Otn7JeCGoYBLijshCC27P9BJ+Eid2EC39RwDSt6q6/Yfwtg31Y9/XULX kjrDADMxrLnBfBJV8ocToQg53GdEtTWflUq8WZSZswprTdUL7zhOT1V7mKWbq1E+ kZlQ3w== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fs8pg0c6u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 01 Aug 2026 06:45:04 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cb7d6ba548eso2076073a12.1 for ; Fri, 31 Jul 2026 23:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785566704; x=1786171504; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Gy//CsWuz2yFFMSMOowYorOjj1Lc1O2Hpen8MYG/G6w=; b=NTIoERBQ3nOTRLljzIAvhhsKiHq8BXrSachG96waxR6XpMWWwbBJ8PaSdfSNwxJkwM G7dlIDAzl55B3ft1IhgcUQ7BV1ddNMgt2Ydp/ps2GxzriQTsCYpLoa8MrV3YLIuw11kr vuu9CxPcKC8zxPY2lyPUR4DU0zeZNA3h0ozOyf0t3T3PaEfKXLfGCFHbRLl1Pj/IR/gI WwPTra1DA90sFYbdLnaLrwkNkbk2fvrtE6WwvTzX/POJVfVUta3Frshcn0SDmSunrsl6 eZ46JIqVZMbyNBUtY+t0gURLKQS7b//EQZREamHyYpPo/+HRi7wOAM7xRKUCybPssxjV 4kRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785566704; x=1786171504; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Gy//CsWuz2yFFMSMOowYorOjj1Lc1O2Hpen8MYG/G6w=; b=etxInFZYuN3J18rLazP/e9o7g8rU+tizYbIAMkIv0aNZes7yJQDMycbPdV/tU5pqf1 EQM3QYExPrUUNu9bpetcBfGTvG3s+j1sPAniRFps9ayWJdlnd7As9tfChr1Xq8N5G+ZN a1GRj69MC6PaV+/kkOKzu065Ytp8AK1Yp59bKImGLp4NOm+07qso4ojXtZABD61gdeRC p6/vwCHCwQxgnDnF2XtCGEh+fEoR1azrYnaz6lsBtW0sNXHXQ4Bo2XNLxwAreEyqgVZI AZo2myIpwi8pjeGPDv4xtTpW07bfm/rPjA9vg6lx73L1NGUszZ+BsqXQX0JmDJ+XF4dr UFnA== X-Forwarded-Encrypted: i=1; AHgh+Rrn3kwC4GT5ike577o+aeIxN/wvxCWndMze4az3bgUsPpzExbIx/j8BoxMnyQwOpOh67+yH2qbnqj1LvME=@vger.kernel.org X-Gm-Message-State: AOJu0YzDrKl/2I+7JQfUT2UwdIu7k4ky1h03Vz9ck7EHq1SEiiUZLSpa syL4/ivRDlfsLJx9YkKV1mlLKXf02oKjKzBAnjdBiM6BF6kzyKXmzCM1mFGqtc2pLfaS4374Jeg /gP8y3fJrd911Or5HCqsM7SfZSrKRgQ1cN5p/ntaFN4qunXD6ReBK3Bu1eRWyCSEV0b4= X-Gm-Gg: AR+sD11ACKTmR+WWrqAQGKpGm+mWEwb5S7lcmsCzB9CpgMowlT2ZaHGvambN+Wei6vF dsCAC0sCHFhpP58HqjYSs0VfP3j5OwPMWcAZ2oS1b4rIi3JWa/y+j/Y4M5GDLf01uMCUWW5IO23 EkyZDmb9yxe/my73pAqlh+5z+kCtsuBVJCJ1PapQALEc4Pqg9bykqh4d8Su7GxCpjB9g3pxcYYN NI8ugvDr6nHJNYNlaDbe8r+fasar4luoWJbQJnIVMqFZtCNqY4e51y7PVO/wCLUtytcefDLrp/x a1WQ6rhof6r/0B4fL14PNrFAMz8I5IIle+oJ8Jq9yYbDhC/nDU4gyfHtLw3IrMqlZqJEzG+3gxE xVDWzyiftYyAC/LIdYuBHtr3KMTNbAJA= X-Received: by 2002:a05:6a20:2d26:b0:3c3:a024:1360 with SMTP id adf61e73a8af0-3c92a793ad0mr2620693637.28.1785566704222; Fri, 31 Jul 2026 23:45:04 -0700 (PDT) X-Received: by 2002:a05:6a20:2d26:b0:3c3:a024:1360 with SMTP id adf61e73a8af0-3c92a793ad0mr2620658637.28.1785566703776; Fri, 31 Jul 2026 23:45:03 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153ddda5d9sm16863759eec.13.2026.07.31.23.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 23:45:03 -0700 (PDT) From: Sachin Kumar Garg Date: Sat, 01 Aug 2026 12:14:48 +0530 Subject: [PATCH v9 1/3] media: iris: cache work mode after computing it in iris_set_stage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260801-iris_multi_slice-v9-1-bddf1449c280@oss.qualcomm.com> References: <20260801-iris_multi_slice-v9-0-bddf1449c280@oss.qualcomm.com> In-Reply-To: <20260801-iris_multi_slice-v9-0-bddf1449c280@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Vedang Nagar , Stefan Schmidt Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, 20260731-iris-ar50lt-v9-0-d71a782001c0@oss.qualcomm.com, Sachin Kumar Garg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785566693; l=1459; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=Talog+0/N6j8EQ1PakpJ6H88zNB0v5H7GMdas4bX7vU=; b=PW1aiaMjR+2fLFDCo2MWppwlTXu0vjtTDyfNmmOBdiCEgYBs4yBBmCX7qmQmEJ4cL7SMbPn4h 267nikmztr1DRkNWcT9QVcvnann++9YMEVLk8XwA2XrJF2JmWW2tyf+ X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Proofpoint-GUID: mDaYn0cxVaktnselTC7B0COgb7KLtVxl X-Proofpoint-ORIG-GUID: mDaYn0cxVaktnselTC7B0COgb7KLtVxl X-Proofpoint-Spam-Info: AW1haW4tMjYwODAxMDA0NSBTYWx0ZWRfX+5XgVX5jAxdI zO1k89Kaxl0fj5U+iZ1jTSSH3C83RDX1ZgJF/V4mhdWDXIxdIggr1L5/DPK62RDUoGUkWSlTC4n vsG66TXXY4s+bjB1vLlYRMVyIqEmMZA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAxMDA0NSBTYWx0ZWRfXw4i3lmDYAbJ9 XxmZk123TWckkesrxcasO745sxlDv6rgRgAl29F1EshMZvJZ/tYxixoW162Jp2gzoZMCJ4vkYaT bwoBXWCLVi1/41pvy7lM3v7s+sXNUDgq7mzBZC22dzKY07rRBwAVF7M7qL2v0kNiLGoXj/nTO/p kBSKFL4t46khkYqQUjj4QNU8nve430jbgzC/IqFj/4y1BdWtZQRcWy/j3J965G8Nks/VxTbynIx WnC1ugDxzqsEMVK1ap7MmnFc7hSzxWNmpyBen4c1Dh8JFJX81DilqZVdWQ2GqoNOkI8NHY4sNmG ZMYuNyIs9sf/KTSK8sztmRO7H1gmtkGKgE2PWQPiBS8qCEXlstSnF3+N74PAJo9YgH0AnfNTTN0 oF7BBsTwsOQ19TIrtc7uiTI4hNEKUu1keUubrHVbMGQ50pee+cb5jAK4fh05wTL0dqoNA70Ux37 fz4gtpt1GdsYFCvp7eA== X-Authority-Analysis: v=2.4 cv=U4Oiy+ru c=1 sm=1 tr=0 ts=6a6d95f0 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=DQE9uWRhMQBL0dtU3VIA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_07,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 impostorscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608010045 iris_set_stage() computes work_mode and sends it to firmware but never updates inst->fw_caps[STAGE].value, leaving the cached STAGE value stale. iris_vpu_enc_bin_size() and iris_vpu3x_vpu4x_calculate_frequency() read this cached value, so a stale default causes them to miscalculate buffer size and clock frequency for sessions actually running in a different stage than the cached one. Update inst->fw_caps[cap_id].value with the computed work_mode before sending it to firmware, keeping the cache consistent with what is actually configured. Fixes: 3a19d7b9e08b ("media: iris: implement set properties to firmware during streamon") Reviewed-by: Vikash Garodia Signed-off-by: Sachin Kumar Garg --- drivers/media/platform/qcom/iris/iris_ctrls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c index cdd02328cb71..14e0bc06e1ad 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -525,6 +525,8 @@ int iris_set_stage(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id work_mode = STAGE_1; } + inst->fw_caps[cap_id].value = work_mode; + return hfi_ops->session_set_property(inst, hfi_id, HFI_HOST_FLAGS_NONE, iris_get_port_info(inst, cap_id), -- 2.34.1