From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow-a2-smtp.messagingengine.com (flow-a2-smtp.messagingengine.com [103.168.172.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 955D8237713 for ; Sat, 1 Aug 2026 03:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.137 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785555385; cv=none; b=obdpPvHjSWs3f3F7/iHC49Wv++s09H/KAWUxuX8YZq+9QkSRv5JqTPpxndi8pLwQO8ozY8vKejR+3aY35ONct89D4nLiumNTWkTAT1If4dGYXvSWDTj8IktbbScYUYzI2k9dOvNzOZlgRUq8c6Bf1QLr/czIrpCxCRwUFHxjyTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785555385; c=relaxed/simple; bh=Kd/xtjrXL+ZSFGvvYxUao+0BEyM+qeVjXC70r8IO+a0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HA9XbdVe6Os2sHVGt/5IyclW67cdzNzkJ0HpICaELygSNSqUV5g2/LLd2HQLpvcp13+dSvB+sZja/zTbwnc2Yz9ulTg1nJ7yJ7LAKq1o0cSNR/amUyYeN8xjW9CAVIpjOcex8G5YB29EoCALq3qTnWJO6D42UoqWH8/keDP1gfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gahingwoo.com; spf=pass smtp.mailfrom=gahingwoo.com; dkim=pass (2048-bit key) header.d=gahingwoo.com header.i=@gahingwoo.com header.b=oz86UqND; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=nQFXs9EW; arc=none smtp.client-ip=103.168.172.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gahingwoo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gahingwoo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gahingwoo.com header.i=@gahingwoo.com header.b="oz86UqND"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="nQFXs9EW" Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailflow.phl.internal (Postfix) with ESMTP id 8CCAE138012B; Fri, 31 Jul 2026 23:36:22 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Fri, 31 Jul 2026 23:36:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gahingwoo.com; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1785555382; x= 1785558982; bh=Kd/xtjrXL+ZSFGvvYxUao+0BEyM+qeVjXC70r8IO+a0=; b=o z86UqNDQeB62nnfqOmcNnf6aZ3eAairvn0RXbyK3m7QlPX2Rffmcozjefoxmivd8 cn/0FwE6fmXfmpfmQ7daoqNkIWmY3NYsRlsMvxP0VBS5mpBxiN6rPK/MfORUXA+N ns142ECvekgIWt2586CJdOleQYQIkEuWmH+4vnvHO9RlMvE1lsdNTAAAYuEbkC3R 3+Z10kHHzKDRqOP/ANtc4t04HcYSmN3WP+fS1u+NvPuO/ovJ8NkYNsplPN1/eI+h O32gLAj0qyYxF9Ml7BO1ZBhRiTRX/2VRGu2vJsNMWZP96C9bx70Tiq/mjIoJbaFo Mo7sKNQrfQL45LHeTfrzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1785555382; x=1785558982; bh=K d/xtjrXL+ZSFGvvYxUao+0BEyM+qeVjXC70r8IO+a0=; b=nQFXs9EW0XGKN3zf+ jTriL0RUOVUli6tYYs2vouiAxYs2cceQdUPqEhKaMcWZsRt4y93p2JHAFCtkpfHf wyJ/9pDS4z8U0DIJcSK7IOKE978Q5HuMgpItGkQIaYperIRregmB1W0jlHMTzHSY gH/hZu/bhrpOQfN4SiQmNAwn7ENtY3R5ZsF62/ZLghYnMp0Nwrr/4TKp4/T3Icnn sL0KPRX0ZapLQYaRhbzafWTn/tOUO15DIKhZhycVffIx+9RrgYN9TOP8Yx9qBJDR SqZrpvOyf7e3EN6HX/+vQfzWC0+DIX/fK+ylzgQkiuJOG0mxr+qvEpaWaRj9vk+I v76AQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFGtZaGtXrwImdZSICG4DUqUu96tkJF0TuoMDWZLUDTN+ut1sbQE3D/S1YOvP7agd DagK4+sKjqjfOl9Dni90cOTdE7gDKtt1z+cYPOMi3+abEEFyaXJqk242pkBhUJmgbD8YAF M02plys25VQS9ULd0ZD9BWh0lB1k+/8yOpPh9BR4m/YNJ6aJLN/kzTB7SU0AZ+omYCa+bJ kUULTD2vflCE1P1O8N2urjEs0Q6bokgGb1/m9IRU+HsXZO4qX8KJWlRvrsx1AcX4SQ/kd+ Wv5h2nNm3stWs/xwTO4vSBKDpp9JcZMq8lKUd3R4c8sLFnOPlrf27aICH0hLl6PAgOE2qx 40Tshx/pWouUPk3C8l4dnX5kdA1pJ7k1D4+U3iSahIziJsATLg1q/tE7HpEs9Qwiipv5a6 vTeC4VPQB7ELHgGANUuShSs3HKxQB59Ma3pT+pz1T2wYZtypY41OzZqOHebroWD99zm7aU tKv09I443qVoBraCWFhoLCVXomxHG1gSS7r1Vz/P1baPsxoit50lFCIbncViWmw24uUoyj yAR8Axk5yK4FwfPUCokn+GsSDHztBRKqWjEHfeuGnKbgN/gpCEH0lAjIUYxwMYPcP1nJ7m 8kNEMLD6g4tdI0uZOFlw02AaYwD1sW7mnLiNkhX18FMFVt9HafiJkFyQHa+Q X-ME-Proxy: Feedback-ID: i7a5e4b5f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 31 Jul 2026 23:36:18 -0400 (EDT) From: Jiaxing Hu To: royalnet026@gmail.com Cc: tomeu@tomeuvizoso.net, heiko@sntech.de, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jiaxing Hu Subject: Re: [PATCH v2 2/2] accel/rocket: keep core slots stable across unbind and rebind Date: Sat, 1 Aug 2026 15:36:14 +1200 Message-ID: <20260801033614.2008530-1-gahing@gahingwoo.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731064933.12548-3-royalnet026@gmail.com> References: <20260731064933.12548-1-royalnet026@gmail.com> <20260731064933.12548-3-royalnet026@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Igor, All three are addressed, and in the right places. The .dev = NULL lands in the rocket_core_init() failure path before num_cores is decremented, which is what keeps the live slot count and the scheds allocation in step. The .dev check in sched_to_core() and the note about synchronous probe are both what I had in mind. Thanks for exercising the forced init failure path on hardware too. Reviewed-by: Jiaxing Hu And thanks for the Tested-by on my v3. RK3588 is the part I cannot check here, so having the soc_data conversion confirmed on all three cores is worth a lot. Cheers, Jiaxing