From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CCFE48986F for ; Sat, 1 Aug 2026 10:30:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785580235; cv=none; b=hUPUzrEoaWFFQTno6rs52rpCnpj4NjpkzWGyqUpXe8bEUPnD1dpVpZ3XDj/XSZzBZSdp/opnwMn4x6m8NiVIBGvyswafmEERDGR/W3c/aSflBVGKhrofNAR1hElhW+zQl6VK5KQiXaUIq0jzG5mCMZBbywVtEV4os6UYDhZVIZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785580235; c=relaxed/simple; bh=ohlnl419En7WmpkldBcnOODjFe4MOBH6dlQrHo9uFdE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XmJYr8V3wCGy/aqzso1S0mPPc62lsxKehwTwov9WcerV1b7vvV8wSY5cBdGYHJ5UkRP1UURvtA8QgIztt5byBFeuiTH025L3sujir1IC96P9fI/N8lXES30Zk4QDW92ZMmOrdYPdCVw4KNjl51ilG9+570bTfcL8gjtNmEaH1Ps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TAQWKoQH; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TAQWKoQH" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-84862b0d5f8so1649674b3a.3 for ; Sat, 01 Aug 2026 03:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785580234; x=1786185034; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ohlnl419En7WmpkldBcnOODjFe4MOBH6dlQrHo9uFdE=; b=TAQWKoQHDPZbJvSi5CIJ5mey6UL9q3lD9SvvGH6ydLJ2tx/3FCgjmkUEPhN9dmEPPd tIKQ0lTjnl5deDEi++z6Lo2qNAIC05KcZOTaCeuSCQxIXKfCjwJlG006Aybc7BSeizES mI1j0eBGI7lNTwkG7HAuIA68egVqRktvmf0clADYmRQn2IEH14JqLlQhiOYqbQf6VFo9 dHse9Vj4D+40Y7qOgnTPORWg2YtxS5X/lwrmhXuSRvIaewsXU5DM/DBqxaBaesUS3Pqq eV4GMzKA3dOAipnrz1ljLZgY0aNcFKmF7wV4ljxzzwIC0CjOHcYnfLvXh1dKSPX3y/jF lKbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785580234; x=1786185034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ohlnl419En7WmpkldBcnOODjFe4MOBH6dlQrHo9uFdE=; b=J8y03IjgBzZNXLwBj9JuFJ+9nkg/M/nizzmXiRfhcmww+rpgdva1ilFxq+urPco9PE NAmHBurtB5KtaIBzsysIWBOrIbCubXFy4J4pgLz9wRGyw3rQpqYyVLwMB50qLlwqzP1j U7qjvskcP6zuuy0P6Al2MApArtKXQdZ+HK7tYOrQaiTva9VVHj9DhcXr3PZTiO8pWC2h vCx5p9zYRtsW4Q82uJdxfMV/SaTX2debNRuDC+87U8RCGhIqswCqJSW9quiR58L7G6fo AULOQnnWgua9xOHqY3F4c5jiLqehva8icIiMoXMF5C5FcGEgs5KAEr7AxPCWaDcxKxmp tCYg== X-Forwarded-Encrypted: i=1; AHgh+RrwLY5JZuMQuGJImau4tCNRfNWwmRe8M/cQDu46Nk3QNpKdc1juiT0CFPdsOAJzlgy84dIrpUYsyr7aJBY=@vger.kernel.org X-Gm-Message-State: AOJu0YzNmdVfN9hyUkx4zlj22CZ2mj19Tope0bjG2GkCHM+iGuLYUnO2 ST7oonFbvS/wNp0T3prEtTShWdt4f+6ptOHRU55bQ6wzpRY/AUekbFlR X-Gm-Gg: AR+sD10tM+va6nCNYrOxutyKy6YKGYdTGbIkOCznf7gvYO0n6Xo7iSw1cdQpoCxtIkl 09lNiSYOBZuEVut+sxr8eD8TCly91+hCSC6nFsfQZMAX7+BQGoiwf2KQhRYqQqOOwPq3hHm0HTT h2skOx5EDZLIxQwT7xawaR0QXZJcjWd5p/0KceXxGKVFnbgsEyRD7T/WnCMmrnlmDrOvdWQ/Jaq S+fZ5Gpk++3dvkMl6QalRZHasWpDV3cLZS3Vig2/a8G1bpohU8YhtNW4cNKUpxfNNZyQT9LyT+W G34Q3XJCe1EeSYRkBqgb/Gt0+ZTy8IQwRyLohMhfGN3TtFu2NYWAN4N2/8AXS2GfgmuVX3yUM/K y+uVxqnI9U+LunaU21Q1UViwdSik4eqqgWmjRewSJMOkJa9etXVi28ySd8S7rbOAVLCCvQ9UtFD Li9Rmf/uwMExdvyofzdpW3Yq07SqCYXVGoSiP2hO6gbc5q3smTeXPZs+GKEeguPw== X-Received: by 2002:a05:6a20:914a:b0:3c3:a17c:1f77 with SMTP id adf61e73a8af0-3c92aa2ada0mr2878840637.51.1785580233796; Sat, 01 Aug 2026 03:30:33 -0700 (PDT) Received: from xiaomibookpro-14 ([149.19.17.31]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e18e114sm27560090eec.28.2026.08.01.03.30.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 03:30:33 -0700 (PDT) From: Zhefu Zhang To: Andrew Zhou Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Zhefu Zhang Subject: Re: [PATCH] Input: i8042 - add Xiaomi Book Pro 14 to dumbkbd quirk list Date: Sat, 1 Aug 2026 22:30:12 +1200 Message-ID: <20260801103012.4142-1-a723356@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260718122437.11112-1-zhoulol888@gmail.com> References: <20260718122437.11112-1-zhoulol888@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Andrew, I have the same machine and sent an alternative fix today, "Input: atkbd - skip deactivate for Xiaomi Book Pro 14's internal keyboard". On this machine atkbd deactivates the keyboard at the end of atkbd_probe(); the EC acknowledges the ATKBD_CMD_ENABLE issued afterwards but never resumes scanning, so no key is ever reported. Setting the existing atkbd_deactivate_fixup quirk avoids the deactivation and the internal keyboard works. Compared to SERIO_QUIRK_DUMBKBD this also keeps the keyboard LED working: with dumbkbd the driver never writes to the keyboard at all, so the Caps Lock LED is not available. Tested on Xiaomi Book Pro 14, board TM2424. Thanks, Zhefu Zhang