From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAA0233B961 for ; Sat, 1 Aug 2026 16:01:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785600110; cv=none; b=oYDtHkK+HaPcJcijZfIB/GlhrvtPmiuPV1e8FLJNLCx+KuBIUEgSa5T97PxvUaKdLPr4GXHpzBaP483n5fa9tgnyuZy5BxR3JgXR5Q70jmc97U97ttwz5pH4z5yqYSxR2u/thxs0CcEPNfLoYJrAolVvYV8XvVYzYiUZ6ds+3tI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785600110; c=relaxed/simple; bh=MqiKR68RJI+sSyHnDz+68UWU+EVIhF+AL3wII3bVp9g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oMDafoQVlcEkfLzcRY/TUMGxGNpaSA8qjSIvQDhbNVT++Czb2hwWqtXHBsOTvxRG4Ph8xi5FlarHN988lOoDwCb9K2+HHS4pQn56wb0SUMTbzd6V3LeHiM8xQ8SeoH5QA4hiuXFumtSNfJ7PlXIv/UArloXpXtIlNeIHDIcfwW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TIS3A1OK; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TIS3A1OK" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-49800c6a846so6386645e9.3 for ; Sat, 01 Aug 2026 09:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785600105; x=1786204905; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=unnQHqlFBCeMIkO8etGG10JaJI99QH/KEoQ2kEjq9AI=; b=TIS3A1OKgAZmLkAdtCNT9/FPOvTQG5tXdZy1ELGJW/KFRUDFFon/V9HkjpYa5Pookc DjGkpsDYBqa8c2tFpxyL1SN1uZIvHioah6XGcdUB8QtlPXOqKmjlrWeiXNL719RkLghj RlgateatNx4YhLlU8tmPCDkHpqm1uyYIbu5qcIHa4uwOfGH519dP0O5t38Lw2XSIKIkE 4RPvXzcHbDBmyX2+jocy/WIzlkzcB/DXLNinXeKP1vwYrhcBvI3+Q/2t72rlofEQW9vc sNbUNaERd9SwpAT6kmqqYAL628avPkOfoxqs5iF+A74YHltczknGpv1fqW2dxRRqelq0 KWpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785600105; x=1786204905; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=unnQHqlFBCeMIkO8etGG10JaJI99QH/KEoQ2kEjq9AI=; b=i/s6yovFwM2sM9q41skBndy6p1JipozXR7R8d8xqTRxKw6zdCUrhVfzz7l+0o6QUYe jfADsR38etwa40h+kokaBSuDcP91QJdJsjPrCt/21xloaRrwObDZdOc4oqY5O9mwuAuC hPdIXza9I3iazfLFjXAJ2ma7ZdxuOBkAwVB2GGFktKsZCaQqzxW4uItTtxQkQ8qaDMy/ /fwFTPEUfdVpc2iB1kE7JZn8A4LF28jUMJAH9Oe1hkmmAmoYuVEBPW/fszUm/isgX5Qu JScBMsg9S3z75EPR/8sX/ZETltsDczJQcG1zFcY4o8R4qhz++hBfTmWvmaPtUHWpAGjJ JhxA== X-Forwarded-Encrypted: i=1; AHgh+Rpk7Q7NFMUY8lID9JpuSx42uUsXO3toBGRbAbM5ohPJIs5ZgEJuM4QRTefRNJ1m7ebPjLzigbMyDPhg2YA=@vger.kernel.org X-Gm-Message-State: AOJu0YwuopVvbFojuYorKz/Q5MKyRY1rY7dt80iyT2fyjSSsVuNeH9XN BCK81QO/MG6OlP3tOnNEM1euc0eaiVpvrQY6Rpt5kTUfEQAlNQab1U+4 X-Gm-Gg: AR+sD10wdjhoEz5f7pM6SBfV8RaekVXDaoITJrG9MWojhiHGymiBeKwJTkLNDhSReNQ AXNKWSajgRaTUm3LUCDzCqCxA8jPvF4FmJFD8NP2OHeVcmOCZaMvoRBr8uDZgsfqPhvy7nSFwpz X82HYNdqt3/VciQU6KBDoV23DkJB3SNGBUXbr6ziZAshN/w/upkfWBkAxPlvDtVu3A22NOEjaMt ZXwji/4cun6vVvV19kWX8ZK3VSsGTKVHgCmGRoLXakIkBLHv8d8UUvj6uejDTizpirr6e0YdRRW RSmF0t3NxkZxyKRri4WKhO0BlMjtwFUXaXqJ5v1YuQ3kctG9rJ6N8oNx/k+pVEecQxAlpDArVvi OQjfwroHRwwkQhxMoQpKeMEmq6cQG6ZdWE1EFnv2GlmpUzmmPBGI5TJA9NiXybsp5+kVr9LBLPb zTrJ4SPoDWBFCd+IHN9nwxDZ+lZ00MSjv7IbCeq2qb9uGlxTFSKsJWD1rZ3rZt7VJtnPq99TzUz 1BK6yO5hgg4o8ilPBcQA1uTT1wgh8UH8hhFUcNuJGJlNABpT0SB X-Received: by 2002:a05:600c:8b33:b0:495:779a:ed33 with SMTP id 5b1f17b1804b1-4980c66c798mr61780875e9.7.1785600105026; Sat, 01 Aug 2026 09:01:45 -0700 (PDT) Received: from nixos-office (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4980869106csm89424255e9.9.2026.08.01.09.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 09:01:43 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: akpm@linux-foundation.org Cc: arnd@arndb.de, ojeda@kernel.org, n.schier@fritz.com, tglx@kernel.org, gary@garyguo.net, thomas.weissschuh@linutronix.de, aliceryhl@google.com, leitao@debian.org, dianders@chromium.org, linux.amoon@gmail.com, oleg@redhat.com, peterz@infradead.org, andreas@gaisler.com, linux-kernel@vger.kernel.org, Julian Braha Subject: [PATCH] nohz: replace dead select with choice default Date: Sat, 1 Aug 2026 17:01:40 +0100 Message-ID: <20260801160140.2391000-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 'select' does not work on config options in a 'choice', so currently the 'select VIRT_CPU_ACCOUNTING_GEN' for NO_HZ_FULL is dead, with the choice option VIRT_CPU_ACCOUNTING_GEN only being enabled when NO_HZ_FULL=y because the other choice members depend on NO_HZ_FULL=n. Let's remove the dead select, and encode this relationship as a default of the choice, instead. This dead select was found by kconfirm, a static analysis tool for Kconfig. Signed-off-by: Julian Braha --- init/Kconfig | 1 + kernel/time/Kconfig | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/init/Kconfig b/init/Kconfig index 544167a7045d..8583d9f06c52 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -565,6 +565,7 @@ config VIRT_CPU_ACCOUNTING choice prompt "Cputime accounting" + default VIRT_CPU_ACCOUNTING_GEN if NO_HZ_FULL default TICK_CPU_ACCOUNTING # Kind of a stub config for the pure tick based cputime accounting diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig index d098ac39bde4..ddfb6bee0745 100644 --- a/kernel/time/Kconfig +++ b/kernel/time/Kconfig @@ -133,7 +133,6 @@ config NO_HZ_FULL depends on HAVE_VIRT_CPU_ACCOUNTING_GEN select NO_HZ_COMMON select RCU_NOCB_CPU - select VIRT_CPU_ACCOUNTING_GEN select IRQ_WORK select CPU_ISOLATION help -- 2.55.0