From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB671339379 for ; Sat, 1 Aug 2026 22:10:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785622216; cv=none; b=oMTnbFmHJlwNG/ZmLBkeDfYvEaaIuMKgz7iy2g9aL4z26obyh/WIJezG3swT1byl0YRZeWEDjpuRb3SQkX3SJX26RTclIKH29SmIapYEW6YU8uMIdgdmt5XDuWhKyjOPkztEJDGC/F2gJlaOjcioB/8pQeU612VzJTl5/WxX4x8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785622216; c=relaxed/simple; bh=v6FLlzaxvuRI+eKzcxTmVtfLmwaLXwmBPtv/mhG5j2k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=g7Z5ul0cMM8U9YZ1WaBsqfJPKzxOnuoB7+MwkeFE32QnpSuRYOR9o+FwEmLXq71LGL6dAmNT0/1hRT463A/U1H4V1nxZfYo+aRP+K4kWg0ANrDCjxku8+r5jQQFXuU0A171vFEjIEwkHf6f4B0AY85V4MzeyjbNDDMN0/lP0/qc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Sgdj550M; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Sgdj550M" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-92ed3993c1eso113505285a.1 for ; Sat, 01 Aug 2026 15:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785622214; x=1786227014; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=qxmLBep9DxGKAT2MJoLX8E/AhHBeKq4XjNfAEIUfYrg=; b=Sgdj550M7D+otKgljXfIBzFIMOggf/cLPgAEqzZLPe6/7qmU50D5mW8+Lz0ZItB+l8 IgisproS7bdCAOxFXEM3CW75LYbPfaVVBGIb+kZcNabjXa43EOsTWuaU1SL6RsDqaeTa oWpcUdqRkwoKmVjSqu5lw74F0x0ZmutP7UUwdUbdv0cZih9BWYJx51Tk0csaTomIEXLl qCuTQMiVwNcbvaTRytreUDhA0US2xdkWNDRNpOkeKk16LjJkACGUJnLrOibvCjXx9kpe 416MCe5ujK5NaZfl3E1lqGx7m7yTLgy5S2jBlVBRujaUZOwTx/W57OM3KOgrbOIPcKJ5 boFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785622214; x=1786227014; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qxmLBep9DxGKAT2MJoLX8E/AhHBeKq4XjNfAEIUfYrg=; b=NxTX0h27w/VGzE93rfNyOzpK6J+sdh/hXQvZ6ayBF8r9J+3FLSH2Yp+Eb2JcMJ5stp b9vU71LlMREJ8GkJp2Vkn9wq/kwjTSoz78vgh+sQctQBzhYSfEAcf/j+gfwehBMFU+QA a45roYZYaGOqxOl/b5QLeoRmg6tBSDdAslbbzdE0fedvHfphSVxrxC+6IGYlVAYh9bkR 3Nfr9qrKiQk0ZBMpkFg0hTQuNGZckmDIV2GcnetxYbkUAiRAPiOMGdHH+mlhHsmqhCoe AaRvlSDe7kb/dkoBMha1Vu2heg3TfbbWnL40THj95EMssAYRiBH56eg8OA4A+RkD16bc 6aNw== X-Forwarded-Encrypted: i=1; AHgh+Rrbi2y4h+yqQtb8sMzhzf2BYFqRJErQOtdepQAI7x4zlcmw4frchnwP5BxLKZGr9WCI6GCLzWbj46hWQbQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyt2Dh05ijf63smXmcx6nixB5TbN2k9OYp8aNbXfyajFwH/34/N 6+eJc7wHAwakjvkSwRrhKbmyklZ10Ihmtr789XOTkd6l15ugYXx3bkJO X-Gm-Gg: AR+sD10LUJ7KTgehor4mB6N+IClCeapEbhgfuFBIHHDwCdZRr4mn9IXqEDTLjlI3CHY a4T/QhdK6RC1u4lZqUcaj/bPOmhwUVtwL/CGtELBbfTJdNkrb5nZ9hP2Di9xXkYuGqiY5QJiesV flZFc9lA+PJ9PWquzjGwKiUMJu19R0h6eS6gs74sveIJprSYJ2fACy75RspqnSDgCRtQolbrmnp vqe4p42TGAEIHfDsXqt0mGrMz7FKbKJB4oIiQENPFFqpYYU2HNXus8GpL3d07mg0r1c8rlcLC6T QNS8WoFdkIwIpGAOBMvVnAhHeX3bLlsZNzD18wmVIJk++NmJl/xKAgM9gyE6Y3Inbu0Q9e/CYAz 8TpuXsgPJLncZXjRB4dD8WCyuZmCFzCaR1nnzslVdvlef1h36FXRORpyEtREErbpFxex+LXNeEM k9/cKjLAAMhjJ3kv4oRS6fZo0YGhw/lcpLOo40YSJjANd4WCiPsnMEgnQ9j28EWwCXx5YVzzJgM O8caB4voOq8F3QdGaUR3bDce+4nG4qMDcLhER+gpR/uMF+nTrgf6CAYpw8fZcQ= X-Received: by 2002:a05:620a:284e:b0:92e:db1f:185c with SMTP id af79cd13be357-934a0aaee08mr1071570485a.43.1785622213700; Sat, 01 Aug 2026 15:10:13 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9349bc5ea6fsm350026785a.17.2026.08.01.15.10.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 15:10:13 -0700 (PDT) From: Yuho Choi To: Linus Walleij Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v2] gpio: mvebu: Fix optional clock enable handling Date: Sat, 1 Aug 2026 18:10:08 -0400 Message-ID: <20260801221008.456426-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mvebu_gpio_probe() ignores clk_prepare_enable() failures and has no matching disable path for later probe failures. Use devm_clk_get_optional_enabled() so clock lookup and enable failures are reported, and so devres disables the clock on cleanup. Fixes: de88747f514a ("gpio: mvebu: Add clk support to prevent lockup") Signed-off-by: Yuho Choi --- drivers/gpio/gpio-mvebu.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index a010604e5ff7..095881603b75 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -1153,10 +1153,11 @@ static int mvebu_gpio_probe(struct platform_device *pdev) return id; } - mvchip->clk = devm_clk_get(&pdev->dev, NULL); + mvchip->clk = devm_clk_get_optional_enabled(&pdev->dev, NULL); /* Not all SoCs require a clock.*/ - if (!IS_ERR(mvchip->clk)) - clk_prepare_enable(mvchip->clk); + + if (IS_ERR(mvchip->clk)) + return PTR_ERR(mvchip->clk); mvchip->soc_variant = soc_variant; mvchip->chip.label = dev_name(&pdev->dev); -- 2.43.0