From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4699B1DFFB for ; Sat, 1 Aug 2026 23:50:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785628218; cv=none; b=o0x4Bh58UzwNSxOnGJE5A4NS5TD+Qhc73W93/WBvKDpTDKhRv+SG58SCIWCfDgD2bJT84tMPHAr85qFC7KJdHQa98bqRpudlfhQ4qDIKviFMLMYr37zQx79MA2LsTyyKWB6IGFhlTRVy2uOPhaagxno5s4SXYmVbLkH4dYclZuQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785628218; c=relaxed/simple; bh=bdMOCer1bcVwv0n3WoG3pcELhcbf1GL7jdCrYJhts6k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AGjOfYJ2oKOGO48P6kG456mJsHmcaHteug/ENrf6Xl8s6yJvFAe8FxRd8rEQN7ib5jwebvZeiX6aYJxjNrcrKzdeqa/lq2vSWMrJCNg79X+jmMxmBmVcdiSHrskAEHdb0fNMDB8BxUV2TJ2WXffDUxqwRicGZOIVvKtU7CWoBx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cM8ZyKiu; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cM8ZyKiu" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-8ff20870ac7so13307656d6.1 for ; Sat, 01 Aug 2026 16:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785628216; x=1786233016; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=9v/DnH51uN08U9qv2qhSV9pzfF1H8nxjCJrgD+qcx2U=; b=cM8ZyKiu94wLIkPJuuqqnEmt+cynD3ZmJXaT/oZ16ZYK0WgHnDh3aual8AYZtlnIrK VJ6X/iJ8JtHYn3rDJ1mcGU+ReLfcdoIGDi15yjRcRopcmirKmXiEIxw3XUunh7RQM7hM Iay6udDKL5VtvJWs3ifALf3CmystOUE8XfvGVjf+NbRZ/xfHb2sPOm3bKCTzOgPPjnu1 c2K+CoyZ2RmqVAzCIq6t85Y76+askZpp4TP+ytJiTLfBgkNfxGmgSo8jY4VmC7x63gwa 0gxzZ+mwgSF+SjCYe4wHHdB/mCdH/fheHf7pyoPKrIQ5/gKiSy5GS43ISqK6+mgUmkGQ uwgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785628216; x=1786233016; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9v/DnH51uN08U9qv2qhSV9pzfF1H8nxjCJrgD+qcx2U=; b=Qy8U4Jj2N19fsRpAuJId9xjWNX+1nkXKzMiM43ZSpwj0y5/NXRrv5ZZP94VgJSX/4U 7sHKacfr2sP8KFT3SQC6UlhxLALlW8LPYMDAemt9vtQ5yOOerUOHUIRPzppz35VyYbHA GCjsacKBUuAcha6U/th5r6xVMTgZBdmZtclIOMagKv3VBNo1Iok509CI/XCLX8vfnOmC K0D0UBTuJ/HBAR86yHxqp2QlCahtv4qIgIEdY6vg+M1NMbaveRf3AT6KJ6336LlR/Avm a5hAvRCVs1Wov0UpGLufj1Mi4BIbv7NhNQ1p0iQzogVb5XrfrTh3Fwhhx5R51LCd2XkM NZcQ== X-Forwarded-Encrypted: i=1; AHgh+RppiQmPDKYNyPFVTLKGZOHu5afJRPQNUV3caJ/oWwddr3i3VYB5IgbEC0gyJ1Tj0CPUoNQrOHspXnn2XR8=@vger.kernel.org X-Gm-Message-State: AOJu0YxbjsQxSpiuzKXkeoK2naAN+ArRQdhfxNWm2hbSXtXWd+NO/Ez8 FZPAFMK2Tg2IgNKYEyqzP5hqN7+VX4qyzgQb+7JPSPsDT+j2ckGUg6am X-Gm-Gg: AR+sD10LCT9J7iT1zj3XgWK54KNfRvVtEGfyDNjoXtQdEbVUPNjbHTqm5cwZa7q1/Ka wt0CA8hs+3KT+geF4oRmBvFJ4JxGuw9D55Vr2eFsC/hyYQOjqH7rjyI1WrW/Z0z5h8cykOsdD+D Lxhyx2GWXscOwOaYAaaso55Gc0Hj+5XjEic5lKSVJy20z7iIW1azk/mrapm2e90EDZwWtK0zc7y sp3Z/y3ETANAYeZTUe/oCCuSCp999VJBhZOramClNK2rfmrgX2Ls1L9ZEOeQItZH8GhK010cSI4 8AxiKLXOEbKQoV3fDmQorxGa3UrbTtx8i+RLrpmCPlwXv19FoxZd5dCVXG+m04ZoN+qHFzK6B7d fB6Aa3VsOj5T4gttWtXtOhhQyzYautePZodcqmvFKXPAmaOMBS3Ynw6Lv3ZP5qSsbv1tmmkQ6Y/ 8Dk5jonjtOYZrOng4tZnbLtR1NWXYHsCL+E77h+ZbtdqEB2gfU4fKG3NU/Pk8D8Rib6yVhZ03A0 YkzOswyRJ5+Wwml2buoZyyX7vcfX9ZuRJjwPMUedChCjtNzMvm88qLWNBBrChY= X-Received: by 2002:a05:6214:48e:b0:8e8:199b:aad0 with SMTP id 6a1803df08f44-90849553e0emr119082946d6.7.1785628216114; Sat, 01 Aug 2026 16:50:16 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-908432a16b0sm42515566d6.5.2026.08.01.16.50.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 16:50:15 -0700 (PDT) From: Yuho Choi To: thierry.reding@kernel.org Cc: jonathanh@nvidia.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] soc/tegra: flowctrl: Release OF node reference on error Date: Sat, 1 Aug 2026 19:50:08 -0400 Message-ID: <20260801235008.475176-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit tegra_flowctrl_init() obtains a reference from of_find_matching_node() and currently releases it only after of_address_to_resource() succeeds. Release the reference before checking the resource conversion result so the error path is balanced as well. Fixes: 1fd09e5d884a ("soc/tegra: Add initial flowctrl support for Tegra132/210") Signed-off-by: Yuho Choi --- drivers/soc/tegra/flowctrl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/soc/tegra/flowctrl.c b/drivers/soc/tegra/flowctrl.c index 221202db3313..55e20355a470 100644 --- a/drivers/soc/tegra/flowctrl.c +++ b/drivers/soc/tegra/flowctrl.c @@ -195,11 +195,13 @@ static int __init tegra_flowctrl_init(void) np = of_find_matching_node(NULL, tegra_flowctrl_match); if (np) { - if (of_address_to_resource(np, 0, &res) < 0) { + int err = of_address_to_resource(np, 0, &res); + of_node_put(np); + + if (err < 0) { pr_err("failed to get flowctrl register\n"); return -ENXIO; } - of_node_put(np); } else if (IS_ENABLED(CONFIG_ARM)) { /* * Hardcoded fallback for 32-bit Tegra -- 2.43.0