From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3872520E702 for ; Sun, 2 Aug 2026 02:38:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785638309; cv=none; b=n32mtjEIeUoeS9m6EN1rSYBsuAnAjDvED6oj/EPUGVhl9efaUnMRx09p/y3176/AY0YJffSFWhIYA+eYzLPVpdN8DxMwZm6k71bemp+etR1LBZahXs5YvmEPseJes6tJ0hK9rfsKHVyTrzn3rkrLtDSXTjD4l0PCgW8FLqEmPQY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785638309; c=relaxed/simple; bh=tLgvoo761nGkRbnfBNv03h0op3SxaSojdDA3HCtP4qg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lNpE4h6OCGmtUqyYPU+dsg6NWK6/GdGK28snuW6bADsyvoERargfeE9i0sB65HvdxO3zUS/bMmaDg6XLMJHUpR1SQFYo4myABWlUosaj9RGEnyOshh6+4XNMtFlZBgwnV0KD8FW+VSouyZpMGc0qvto9AVX/RsMpjbiIHL5i45k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qHvHeuDo; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qHvHeuDo" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-92e65e18969so139246685a.1 for ; Sat, 01 Aug 2026 19:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785638307; x=1786243107; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=jvEB2bDegHBMEcT13eWZQWB2y3G1J1ZGbL4bUzfuXyw=; b=qHvHeuDo5sWxc8oASpeqkp9qwppoMtn7RZ65vMqXtaAc2pwQ4TthQWrNDQjdAR9jGE OYsXEpra+3R7hww0Q8QGzuKV1b820uGd8iw7OfV3LQFTtS4LFQ7NjbkrjjFwh2WtrNk2 Ub5OpF4kxnbdWeNrSVNdQvJI8FTVjh8gBXs0RDLRIg0JXeHoFpucYJfnyIGGaCwUVgUH w3KCrC1FUpPfTCLUIUtII+5G4zK+zcNpdpcLSXE7bTGIxbe+VzLCHH7hmZEaLdXNg4vP UyQ31VZcdZmuBCk/YpdHLIzeRMpW+9+JmDCMz7oOwlrra6IgRbmpoXUfNEEQgogcqbI6 8+jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785638307; x=1786243107; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jvEB2bDegHBMEcT13eWZQWB2y3G1J1ZGbL4bUzfuXyw=; b=EKW2O0V5egxQk0eEEWi6Ik1aa4r7rooSmtVXEFv5hvba9souTQ8fCOFyIk0fqkmb+u kElB/jXcjfoHTuZ4ukHgCvQXfRxk404LuvxEYQNrgrLQPXMQZgxLp9tWXiBFZuwONzk1 CbaFS2xxjvYF8ou4aOsZW2DBxDfwaDU/TPUV5Tr6RRfgmQlXwHXYxnkGpgOieK1NxsnT KvU0cRxQlhtC1FQKqQaloe7lsMI/7vq2VlamQbhzFM6NN6SvIWi4Ztgc5YGOHMQhfeZg 05O/cEyr9zrDdlzU5iQ2Q9x24y/SVQ2KgmBEZ620JQqR81voRwR+ASOp0/zfmmm5Al6u XOTg== X-Forwarded-Encrypted: i=1; AHgh+RpVC8QGmLCsDa+z7JLwNXVSfkvtCQVnNR1uxOL/tcYZs/NgtFqT6tXPahjykym4lbPFCbHGUhF2vuyMRC8=@vger.kernel.org X-Gm-Message-State: AOJu0YzTUiLRk1vxoI4Asgk9T9suB4Sa38/UgymXcC3EuKBU15xf2qBx Zur4dbDUD9+2lEe+dnKNElmLQSLafbjMOVGuJXWz19/AaKy18aXnxFKi X-Gm-Gg: AR+sD12LYN9UknMIcoEjHYx7kfMqr1/VjMq7GT7ur6suZKZ+vgVBhe0RyqIdVW1SOGy uJ3yJOALrT8BGZHC8OBk08lTWHhx1qKm9LJ/Qov9j/bId3+L23s+YS1ydr8r/+1NBnF/yKa5SNG 13WmC41f2RFr18NwMC/JldhySVDTADnGwGsPYQRnkiPrjQdTHdFfTC+HWN30fNAAKVhvyT+zxtJ u9Y47DWHRJbf7N51MoVRcvt+NBMqzKZOaxeIlOmc4S/RXnJZtT3cCrNV4Wzy7cAvBcDNdrlr1dy 7cGRJREZDull7yVQc61P0drUAwcsF+2DzXy09E8uSB4UqofwOndgBX4B8ZTYFK4PEHjZyD/hT5X 6kUqX63AWKaJAaHCMKxK4IiSf5MbRwAxQf4+Yomv3ELv8LB/6V8IeIe8JSvNaX4TGAmdHKgRgji HSkQPbfg9Mf60swTAGSp7EezA41WI1CQ09q1DsvEx/XRu+smVTCPBYIoNvxRHECwa1q80ay7wIU FG9hxxzcJ2BtUfKP9L6vQeQ+XZ0RglJuU973c81AIhRRGFvdxVq9ld8ZF/8N9M= X-Received: by 2002:a05:620a:4556:b0:8cd:d688:7aef with SMTP id af79cd13be357-934a1110c8emr1019405985a.19.1785638307016; Sat, 01 Aug 2026 19:38:27 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9349bc24ffesm384090985a.10.2026.08.01.19.38.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 19:38:26 -0700 (PDT) From: Yuho Choi To: robh@kernel.org, saravanak@kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] of: Put coreboot node after compatibility check Date: Sat, 1 Aug 2026 22:38:21 -0400 Message-ID: <20260802023821.494178-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit of_find_compatible_node() returns a referenced device node, but EXCLUDED_DEFAULT_CELLS_PLATFORMS used the result only as a boolean and discarded the reference. This leaked a reference each time the address-cells or size-cells warning condition was evaluated on a coreboot system. Use a helper that drops the node reference after checking whether the coreboot node exists. Fixes: 8600058ba28a7 ("of: Add coreboot firmware to excluded default cells list") Signed-off-by: Yuho Choi --- drivers/of/base.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index 6e7a42dedad3..8d04eaed9805 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -95,9 +95,21 @@ static bool __of_node_is_type(const struct device_node *np, const char *type) return !strcmp(match, type); } +static bool of_coreboot_present(void) +{ + struct device_node *np; + bool found; + + np = of_find_compatible_node(NULL, NULL, "coreboot"); + found = np != NULL; + of_node_put(np); + + return found; +} + #define EXCLUDED_DEFAULT_CELLS_PLATFORMS ( \ IS_ENABLED(CONFIG_SPARC) || \ - of_find_compatible_node(NULL, NULL, "coreboot") \ + of_coreboot_present() \ ) int of_bus_n_addr_cells(struct device_node *np) -- 2.43.0