From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E6D823909F for ; Sun, 2 Aug 2026 06:01:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785650517; cv=none; b=Uk7esNzK1oaq1589DXA2rayfFYSf+h73+gvygwyJT2VvTarvNZzNU8oX6D6xv+S509s6QDpalSlhPINEqhMxl2heTnDc448q9GiVOABgBefwk2+xJGZTipn2Z8zBj0YUQOYomXDTRVGrbtzH7cOFANwOLq1l/yxu3qOQCH17PYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785650517; c=relaxed/simple; bh=JjxDKQF3hAPKt2Y2c8WbHYN4lqyU3INe1BlKLG3Hs+Q=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=sAvdHSh6lzffWM9xJyIKmEr4KiST38b+KoEgyy7COLed9+dtnSDgPUK1WIArAigp6hoDpenOGB/QOMX9e4aggm+hT9FdOngtWeTWIfO6Ozm/gZ8+HW0mjNhmtIELdXiEJpnrhmRKY65lMf5R/fqOmO6/1JLpg3nci67jcqHn6wM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WiDDHE4I; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WiDDHE4I" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-381c51fde6bso2508830a91.2 for ; Sat, 01 Aug 2026 23:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785650516; x=1786255316; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=6Uf0TKCFjdWM1rYqDz7p4iU85M8ItTJOqGEGZ/I4vGE=; b=WiDDHE4IDoLmMPl01JzFPOIOHbv6ic0EvqZBgzaLBR+FfzAIXgONp8uMrMzgwvZUXu 95UIRBW5j7E5rrPsVRb5LPlqCix/VNo3DI6vu6I4TO4SeEzTPub0g8uVMJRNX/CzKPtm W3LIYFpdYdAwUa7B8LupkyHX776ARvfhwhmmTYQIUosjCKy4wtZGSxIb/pOxeo1FlIlT lZZ6HwcmFgIz0x/aONFz3KMtiWBEwClZQqyP8PAW0fnxtx/0XZEh2KgnGwifdQ55gjDD ICzp0lhKww1WUD4KE0GAAWZfcXqMksvtK+H9wP5cpDQwO/EyhG572H1vn3IYr//sa6gt qbXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785650516; x=1786255316; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6Uf0TKCFjdWM1rYqDz7p4iU85M8ItTJOqGEGZ/I4vGE=; b=rpyg14OS5Z0SBgHcOYRLNPjBTpt7r150gmjS5iuaKseH400+sS9142icz3Xmkys4X7 buwFJzLJ19eDZe6yZXaqKK6zao3t1fBUlAczMbyWx/v4O1oQ/jiphdDZenihItayiamr hbAZT9U3uEG3R882Uxa8HXhhqpPtc0JB6cnPhrRStj4KbpUc7ATceJeDTRwkmqKR5fvP 86mfWPr85/FbPfS9q6jzGrxNAGCCNZiWMHX5dn/6VNxF+semKxWw670T7miPGetZzKeD nA3tcaUgtG+SbqH+THfS9dKIaM/V7gHRhtskC3BDDR9KdED8uuM1EwUg6QDo93dZiNob Y5dw== X-Forwarded-Encrypted: i=1; AHgh+Rpw4vQogQqrb3qv8Twi3RUkQd0ZYRgwM092wl7GAfw4mpRrRT/jIlPhPyVN1UVxKqXW4N2zkvnm5iTqgmc=@vger.kernel.org X-Gm-Message-State: AOJu0YxHCNqkFjl/rkRsICQUhpEyJCNWiNGCCY1K3YCsWZI79MLHLqkL kLN9bqavxT3zJCkAHJI1i2my/QBiqHOJqKxQupucsjJ2fLNdNHwcSHzU X-Gm-Gg: AR+sD13wLo0h79NYvJ8etNMSBbBzk5y0RzBVnos7iojSFs8U4gnp/Z7DcSWfytAHl6/ jELPlgRsXda9gJw8P/SEgLtf5u3IbXPYCw5VbC4N3BYii80GhPQgCvAPJZI5rFvFmvkXNxjqC9p Q91vCS48O2vxT39/wcxJ2P3DTU/9I6yDv7UsEL3fJ2j3LeBOd9L3JOqlqNnPBcuw9ZNVv6IWhHA YHsxuS51EEqZ9VUGKu6iI/9TvAtNMvb8HKDdyezh4Ht0xuwImzCP4c5sNzPbPIrwVXBXEf7wWOn KyjNCMvsY5PPUGyXC9Hwq1m+0aGq27SGH2qnHDeJIUwG8EPHNdvPbGB+StnlY0fZhodsyjR+myV lu1LbKHr17OFzHX/Lw3+gCvJMkRc21S0zl9wM0VXMB+DRkCO5sT6TM0ktcc2F4ZJJfby+tZj88g Md6yQoQcS9EkyoLTCxMt6sO8W6tX6lfbX9wXABI2b15SvqInaYMgniXjNCUII/naE8uq8NrLdtX fB9aQ== X-Received: by 2002:a17:90b:5605:b0:37f:9ce1:cdb1 with SMTP id 98e67ed59e1d1-38fbc57a333mr5181193a91.31.1785650515828; Sat, 01 Aug 2026 23:01:55 -0700 (PDT) Received: from SGN-LDSENG.tasernet.com ([2405:4800:5cc3:11a:1ac0:4dff:fe8b:4a69]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fab132cc4sm18610443c88.2.2026.08.01.23.01.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2026 23:01:55 -0700 (PDT) From: Cong Nguyen To: Rui Miguel Silva , Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: greybus: light: fix leak of cdev->name Date: Sun, 2 Aug 2026 13:01:49 +0700 Message-Id: <20260802060149.3803224-1-congnt264@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit gb_lights_channel_config() builds the LED classdev name with kasprintf() and stores it in cdev->name for every channel during the configuration phase, which runs before the channel is registered. That name was only released by __gb_lights_led_unregister(), i.e. only for a normal LED channel that was actually registered. It was therefore leaked in two cases: - a channel that is configured but never registered, e.g. channel_attr_groups_set() fails, the flash configuration fails, or a later channel in the same light fails to configure and the whole light is torn down; the release path calls gb_lights_channel_unregister() (which returns early because the channel is not registered) and then gb_lights_channel_free(); - a flash, torch or indicator channel, whose unregister path (__gb_lights_flash_led_unregister()) never releases cdev->name at all, so the name leaks even on a successful teardown. cdev->name is a configuration-phase allocation, like channel->color_name and channel->mode_name. Free it in gb_lights_channel_free() next to those, since that runs unconditionally on every teardown path, and drop the special case free from __gb_lights_led_unregister(). gb_lights_channel_unregister() is only ever called from gb_lights_channel_release(), immediately followed by gb_lights_channel_free(), so the name is still released on the registered path and is freed exactly once. Commit 04820da21050 ("staging: greybus: light: Release memory obtained by kasprintf") fixed the leak for the registered normal-LED path only; this covers the remaining cases. Fixes: 2870b52bae4c ("greybus: lights: add lights implementation") Assisted-by: Claude:claude-opus-4 Signed-off-by: Cong Nguyen --- Changes in v2: - Add Assisted-by: tag to document AI assistance, per Documentation/process/coding-assistants.rst (Greg KH). - No functional change. drivers/staging/greybus/light.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index cab02b5da867..1ecca479b5f4 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -905,8 +905,6 @@ static void __gb_lights_led_unregister(struct gb_channel *channel) return; led_classdev_unregister(cdev); - kfree(cdev->name); - cdev->name = NULL; channel->led = NULL; } @@ -1063,6 +1061,9 @@ static int gb_lights_light_register(struct gb_light *light) static void gb_lights_channel_free(struct gb_channel *channel) { + struct led_classdev *cdev = get_channel_cdev(channel); + + kfree(cdev->name); kfree(channel->attrs); kfree(channel->attr_group); kfree(channel->attr_groups); -- 2.25.1