From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f225.google.com (mail-pl1-f225.google.com [209.85.214.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CA61340402 for ; Sun, 2 Aug 2026 08:39:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785659956; cv=none; b=OnR/6ERk41kWb0wyR+SvSo9Qr8P3D+/pgNIx4D+PlhnKBhDEpBd+iPI7t/JJCf3XHU8QQH8SHQT85v3o9Gou50k7/wv+qcnzfY1ejzEvssIL5PgBd1/1awM17G2LXIgx5o6so31ply117oEZFEbF43InCFCqOZzrZC71YsIc5u8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785659956; c=relaxed/simple; bh=jdjGUbkBcV0dBBL5aNWg2VRyEgEe8YXwInGBRXnUr+M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QGLc8rRzMQ7ozCqkebbBXP2eRS6A5bx/uhULQ395AWJwYvPviLW54qwU8HPANiOwZtZOqVukqM4QxpLQcZWMEnhCwEgDxPKh/i8wjkchmRzgiQL0OmrwM2HZ6gO70dFsfY0VYKn4dOweJkeXTrgmq1jn3iGWRkx6b3adwNoSlA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=MNSJJRjO; arc=none smtp.client-ip=209.85.214.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="MNSJJRjO" Received: by mail-pl1-f225.google.com with SMTP id d9443c01a7336-2cca0c5799eso19553685ad.0 for ; Sun, 02 Aug 2026 01:39:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785659955; x=1786264755; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PSsJZEdiBtDK2B70Vi/SVAEmECezuO0RlJM9j9BqAkc=; b=D9JrDrIQd6jTGBKz/o4QnZ0a6gaIyYgmIObKBwxhJUGZ9E9WwCvtbQANiD9iq5tZy1 ZCtp7yEsXKygK4tzihBGwU8ut3+Ka8F+ArjkqabqjT+tkit65olzWJOsHIln6eWumK5p CQ8z/2MxsO2L7RoLa1VsmweLfbSkvF89ecfGzT5zib5o0+h3nqjogundrAY5kIu+6F65 Sye9lc5L1BXTDq/jiVXq+8E4EhY6+WMNM18XfjQjZzSkaY5B5qNmPO3CWcTq6Q9XeVEc et4Wlt+aChoweaUpOkxkzr8hO7UWk2DLXqBSPH6Fyvdeu8Oy31Ax680Zsz3V0GPZTfjG eL7A== X-Forwarded-Encrypted: i=1; AHgh+RpUl2WE2HRtncHyKkFttX1reSPyEMRic29YZw5x1yOz4HwSjY8v7bgOMS0/qxN97pBSBMHX6IjtPmmt3XA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4SgcUFosI0dt6iisjQnZjAkDBGUmqy3gQzk6QoISyZSt3rveT OVTUEgRumcX36yQZSdYu5+NEhFEEstKftcWWewgbxccHkkLtkwTblzMupWhkK5Gtx+y+hUM3JQv VHdcjWyv0GjAvxTLZZriCwM2NfAGO6akWJHYJKuApzwf44vPNiMT3e5zXkIJ7jo2kfV1Lo90uns iutfkswOwhpwUNozNKa6YLL7ae2mH8zUIzRvtpdWDfE8sINPbodKfIh6KinmeBIsZBRFp/DpO0G mVuSksFEz1bbXFIPQ7IyaIGsQ== X-Gm-Gg: AR+sD13PFJz0xMRK5vDgs5TEOx/tn4jCYJm5yVlJf9RhhVblKbUocUjDcb0RAQaYGlf 5wyR/39GlKu3A3BB2qyUyGZ3cl12ucddTsORn2CF2WcQz2qHONcTebRtI12OZ55fwnunMyvm9Qa s4pfTjTOOq+sIDGUXcvOtvKGV61ljhNv/VhTfhijFERmPpuwTwFbqj1C+Na50C2vBavAPoBerwm LIDd4REFmiA4QOL8IYzYejUPLfTNBdyQ46WJlN2jKcFNIywjJBxkJ2fZQ3zJaOcRMH4YYW2+Snh VNJgrTljWk1LHkK6rZpk4XDOkXY+UKCMBl0wGm7vQm+EpJ5JB5CjJpuws/BzQgo2IfZtecB1+Ve wr5tx+5kDn4y/QFk2/2gqrNb0KKersKIsKp+G+2357OG2bkVo0rdHVX1CjdmkvLFftRqHMe1L2N yTgl47OveT7+Ga/dKDqiO8zgD49GQryeWL8RRy0YI= X-Received: by 2002:a17:903:185:b0:2cf:bf1e:36f2 with SMTP id d9443c01a7336-2d0522983cbmr61406665ad.25.1785659954452; Sun, 02 Aug 2026 01:39:14 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-22.dlp.protect.broadcom.com. [144.49.247.22]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2d04b16d188sm6360975ad.48.2026.08.02.01.39.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Aug 2026 01:39:14 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1a9764f0so24314151cf.1 for ; Sun, 02 Aug 2026 01:39:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785659952; x=1786264752; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PSsJZEdiBtDK2B70Vi/SVAEmECezuO0RlJM9j9BqAkc=; b=MNSJJRjO4AMo52+Us9XXHZHO1kqXx+FQ5hDLWNrupVBxrXPy/UFSZxEJQwMRABQTGw 5oERSDsjiJgNnJKyCILuaDfuBFKuNl/DWhB6p0zWDPuGfnjyOijS01wDHZeJajXisfSO J6H4mnuYTafq2/O2UC9IsNMtiI2io6WZ4anXU= X-Forwarded-Encrypted: i=1; AHgh+Ro3GrcjDZsAZw9F/288W/506lt9jajhTZYB/61tOM0IY+yqvVQGRDomq4GPbvEA6TQWXvy8uy8/ai2UtWM=@vger.kernel.org X-Received: by 2002:a05:622a:141:b0:51c:7d0:7ed7 with SMTP id d75a77b69052e-52b567da7acmr119734341cf.39.1785659951952; Sun, 02 Aug 2026 01:39:11 -0700 (PDT) X-Received: by 2002:a05:622a:141:b0:51c:7d0:7ed7 with SMTP id d75a77b69052e-52b567da7acmr119734161cf.39.1785659951525; Sun, 02 Aug 2026 01:39:11 -0700 (PDT) Received: from bld-bun-02.bun.broadcom.net ([192.19.176.227]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-908435def8fsm49457956d6.38.2026.08.02.01.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 01:39:10 -0700 (PDT) From: Arend van Spriel To: Abdun Nihaal Cc: arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] wifi: brcmfmac: Fix memory leak in brcmf_sdio_read_control() Date: Sun, 2 Aug 2026 10:38:59 +0200 Message-ID: <20260802083905.3819981-2-arend.vanspriel@broadcom.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260722110713.115988-1-nihaal@cse.iitm.ac.in> References: <20260722110713.115988-1-nihaal@cse.iitm.ac.in> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On Wed, 22 Jul 2026 16:37:12 +0530, Abdun Nihaal wrote: > The memory allocated for buf is not freed in some of the error paths in > brcmf_sdio_read_control(). Fix that by adding vfree() calls. > > Fixes: dd43a01c5cdb ("brcmfmac: use dynamically allocated control frame buffer") > Cc: stable@vger.kernel.org > Signed-off-by: Abdun Nihaal > --- > Compile tested only. Issue found using static analysis. > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 +++ > 1 file changed, 3 insertions(+) To be applied to wireless tree. Acked-by: Arend van Spriel Regards, Arend