From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f227.google.com (mail-vk1-f227.google.com [209.85.221.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C27FF390601 for ; Sun, 2 Aug 2026 08:39:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.227 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785659959; cv=none; b=V/YyaxNMhDD5moXzjrtP9vJmix+Pw6il8oc0uVZax5k6kMT5it5Eg7YNA8uqHoqf9h4SJRKlF70rSByoho8uP/bwHcmVAXCi88dkliOnIOaKzdfFtxREon1OAFAv3TG1Uc6N2kIxi5ux1mHVfNDkbDx7/g/y85/UEpgaUpuhb4k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785659959; c=relaxed/simple; bh=qBzJRPSIwfkZH2tMi/hPWOxxUFCnhOzk5IKDuNq0wkQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VlSEahPH5DDsxQSnP+pAQnTq3MagrGf6lg+4Oyr7zysQcOGj4UmTyGNlyhWrlB69Ai0O+29cq9N5GV9eRlpZ3eLrhi3RFNYk1VlmeH0AMbx3yExCQE6pNaMBr2UGsLFX2fecaH1T0Cz7hTs8b5iSZ7rXvH39e79Tx2WnxOzl7ms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=IbvAdpek; arc=none smtp.client-ip=209.85.221.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="IbvAdpek" Received: by mail-vk1-f227.google.com with SMTP id 71dfb90a1353d-5c2c0e261aeso610159e0c.0 for ; Sun, 02 Aug 2026 01:39:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785659957; x=1786264757; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=B+VjNc7Cj5tMz12o6jEVSiidd0PWIOvTtdYHTchu4Pc=; b=RNL+JdHuJnPQADAo8VFu5vc6Vc5XI+Xi05kce6/ib0EFy101t2FQHA/Xj8zicnN7SM 4wxu8TR7DMSFTWmJPGns9FFHH6s4IsZAvGrwBWCSc5IxXMtrhEVS2VjY8n0vyniFJYb6 yQ5BX3qzZk3XQS2tYYob1CQeguYNH6MYq96neA9bw+kFaMOeUHtjtvgbpOAtuI8fVGb2 VEQe1fIbRHTcGnaV/x8F+4853Q52c5PC77iN4ztHq0HlJEw8aRg0qRkcSVCy0P3XQpOu WVrQrubkSfgUmk8cWN34rpb5MEy4Rp7A3z22FFjFpX+u5jB6aeOmIhwprlp9yLBZeXh2 JIyg== X-Forwarded-Encrypted: i=1; AHgh+RqAC8Sv7D3n0OqiHu2xdpOtXTLUZFVqyM6y8VJlMhgp+JPLvw4BbkAXXUOqYozE/+8uzxgzZfn1VTk/nRA=@vger.kernel.org X-Gm-Message-State: AOJu0YwflTUuS+HmKHZBWGAuOQd1uvlkFjxYLxnB/qkU1QXSoaAEYDV0 B9ABunNhXM3KF78DV3AsOKrINlJcoxY9FOJ/q4zyau1Yk/a2Mz0RV756Hx7/G+SNN+x2hvGKo28 5Mlf7FUldZS1M1OhnCjvFo2OBJYKH0Ay39SOSd5L/QpGRkgocH9EiGUb93rjXc7F+Jdx4hmkiHP gw70Bwo7ft0jmcWoAxMD2OlP+qRof8GdgQrU4pEjTL/YYUrxkymZ3MtBbNW+o5hdoq6BKIW8gH/ n6CC5fFKA/ieM5weVeTJHwVTw== X-Gm-Gg: AR+sD135Dmdk4Cxsc7bd2fnIav4H0F8scwEYVXMD5sll22O8cVmgvxANGDTrU33kqnZ ff+Ci1BCCpa9d2O8voT85dPf0Ny2xK7YRodfQoCIGrpeRCj6TD0CK7JxlX5Hjl083dqFTBfPI9k DnjT0eX6kYdb2ab2U1p9oFLEdncM+wU0RZoGqWgqd9uOAvnQfmLyLIakIC3AvBc12c+DaAm7I4y 8LzbbojenhZpDfjRQwlbem4XtvGV6Ff9Wg2n3ViD+/zZ4xlAN/2TJqWAXgNNORRAnD1t+lxjnUm qteV4LeWGbKpvDoJYa5Oiv7wMjGB5at+GcY7AcYGpaTe1n+w3WqSRkF3yOSTcdU8ka+maNKZ/C1 fMA8bkiJyifwr2E1O2il8Gcss4eU/RVPtNzQIFGFeqJ5Sl8FUlVaiD/Du/8JmU92i6T3XNVCPUc iHWs/Eo8iThzAVlsHsq7pHPpAihHNUWotKljrvRIs= X-Received: by 2002:a05:6122:4f9d:b0:5a4:ac74:f5ba with SMTP id 71dfb90a1353d-5c3877e572cmr1888988e0c.11.1785659956548; Sun, 02 Aug 2026 01:39:16 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-26.dlp.protect.broadcom.com. [144.49.247.26]) by smtp-relay.gmail.com with ESMTPS id 71dfb90a1353d-5c37ead0131sm756683e0c.2.2026.08.02.01.39.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Aug 2026 01:39:16 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8fc92c5373bso25793646d6.1 for ; Sun, 02 Aug 2026 01:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785659955; x=1786264755; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=B+VjNc7Cj5tMz12o6jEVSiidd0PWIOvTtdYHTchu4Pc=; b=IbvAdpek3Jo0xD0dF7y6swqc875XcsMNT6C5F0Rn8KlqW1ualijI6k02MZq7edf4WO B/+0uk8mPS2b8pXmUHIUCmNwFYUmJCmf1ai1NnKLiOgsjGzIjT+odFK8kRn9rHzNiEWj KaLK4IQ6OH5jk2aBhF7jXPYITKnUkf5hJG5qA= X-Forwarded-Encrypted: i=1; AHgh+Rqn1UPrQbIqw/ykr5Mg2VMvtaYlXRyo1L+4df89Qc8tXJP7CE0UN+sMX5A7pJnvcKm3/OFG2hag+BceqWs=@vger.kernel.org X-Received: by 2002:a05:6214:5b06:b0:8f6:2588:778a with SMTP id 6a1803df08f44-90849558b55mr131975766d6.4.1785659954714; Sun, 02 Aug 2026 01:39:14 -0700 (PDT) X-Received: by 2002:a05:6214:5b06:b0:8f6:2588:778a with SMTP id 6a1803df08f44-90849558b55mr131975596d6.4.1785659954328; Sun, 02 Aug 2026 01:39:14 -0700 (PDT) Received: from bld-bun-02.bun.broadcom.net ([192.19.176.227]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-908435def8fsm49457956d6.38.2026.08.02.01.39.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 01:39:12 -0700 (PDT) From: Arend van Spriel To: Can Peng Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Arend van Spriel Subject: Re: [PATCH wireless] wifi: brcmfmac: validate msgbuf flowring IDs before use Date: Sun, 2 Aug 2026 10:39:00 +0200 Message-ID: <20260802083905.3819981-3-arend.vanspriel@broadcom.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260723055618.550834-1-pengcan@kylinos.cn> References: <20260723055618.550834-1-pengcan@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On Thu, 23 Jul 2026 13:56:17 +0800, Can Peng wrote: > Firmware messages carry flow_ring_id values which brcmfmac converts > to an internal flowid by subtracting > BRCMF_H2D_MSGRING_FLOWRING_IDSTART. The resulting value is used as > a bit index in txstatus_done_map and as an array index into > msgbuf->flowrings and the flowring state. > > Validate the firmware supplied flow_ring_id before using it. This > prevents flow_ring_id values below BRCMF_H2D_MSGRING_FLOWRING_IDSTART > from underflowing and rejects values outside msgbuf->max_flowrings. > > In the tx status path, complete the packet with an error after > removing a valid packet id so the skb is not leaked when the flow > ring id is invalid. > > Fixes: 9a1bb60250d2 ("brcmfmac: Adding msgbuf protocol.") > Cc: stable@vger.kernel.org > Signed-off-by: Can Peng > --- > .../wireless/broadcom/brcm80211/brcmfmac/msgbuf.c | 46 +++++++++++++++++++--- > 1 file changed, 40 insertions(+), 6 deletions(-) One nit: there is a double blank line between brcmf_msgbuf_get_flowid() and brcmf_msgbuf_dequeue_work() in the resulting code. This comes from the pre-existing double blank line that was between brcmf_msgbuf_remove_flowring() and brcmf_msgbuf_dequeue_work() -- worth cleaning up to a single blank line. Minor enough that I will take care of it while applying if you do not send a v2. To be applied to wireless tree. Acked-by: Arend van Spriel Regards, Arend