From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f225.google.com (mail-pl1-f225.google.com [209.85.214.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6081340402 for ; Sun, 2 Aug 2026 08:39:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785659962; cv=none; b=Z/110Qn+sWSeyG8sh/YzKkLPd39r/4uAuqhDwpDpH3syLWaskrswkwhP7q5j3Ht/ZDSNq4UdlqAmrKRevqM8z6ETSo8UMhPjSg9WB8UGbe+P0fcT82e78yRjMKXIeUc8/moge9KAWU29709MdPFKOqW0Ghf+CnF5bzRufRU0gyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785659962; c=relaxed/simple; bh=paEteDYu+VpkpJUu3TA3jGp19kJt8vUY/SRmIaxxzXk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GMcHKAqAg1wx0n8bLUFFkU1igYE1Ar9kDaEStjkwcpPlwodLh96YYIAALlTy9pFCqMGYNOGF0ovJsmfQU3/xL7k3Dl2RPAz80WLysj9cMASpym6nwaILiAxaVv6+26+Xb7R1J+BKUIxqPkP7EHVNaM3Xcu4jCA8UwDEag+GXSb8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=HQCw9lIO; arc=none smtp.client-ip=209.85.214.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="HQCw9lIO" Received: by mail-pl1-f225.google.com with SMTP id d9443c01a7336-2cc97653887so25733835ad.1 for ; Sun, 02 Aug 2026 01:39:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785659960; x=1786264760; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=l0BprMNy/y+4QZvQsdZngDdHnMLVEPPrcOP8U8U2Ffw=; b=l/nePln2NkrMUgaZXjxgqMHytjxw4yLMZR/eUUvaRYtbsAXIpjDwNeus/lBk/XOu1w An5k0qxnII+1wiWwFMPPWSmxRc8skRy3bOVAwd083O3+PKuxc176YRiVuMDlmt2weAF2 grbaKHuwKYoVj1nzIOB/uwYk3scqGLm7EiQNKJ9GySIkKpkHWiMGRc1MRcvBDj6NFGfo Vdss+3yotPMhbpecWtVd9kS4cXZJqvluQU6gGbkAky0YOgz7fTTY+azYg3VTvnuWsOz7 pLp1ErZyjJjGQOIwle2jJlLxTO0Zmn3/E/LlUQhuZzCspEAtmvnlh5YdDrD7g7DJDLe1 2Neg== X-Forwarded-Encrypted: i=1; AHgh+Rr7luz6yvlci43MaA8WuQfcFoUBuTVCVqtyCzdjaLqIRmr6H1AlnD5tx8dvBlq0sbyzQhpsk2szRRq+u3E=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9+8SE3cJS7/vlrP9GDRzQQIcn5vwNizr+oQ3iTA2sUGCKVn4m fos2ekEkxzUCF3pRw46rX+z0+TU61cbJciPk83Al/PQeSxLllYoSDq+HJg5ysXlFgSgoikvPs7K 8vWhodcwsN9wYnTxEU7vdZB43uANKobx0vohyoU25ICdPlH+urB32DP9mWp+hhDmMaIdu+7h4su R/s6/cpmGlIHhW7yT7xAuOrQF/qHS+ScUbOBOcUYdKxzjGBsxhoH8A/fUna5kMtLOBToM9LJ0wn 74LCu6m00K/uoa6/vc2uoyOsA== X-Gm-Gg: AR+sD13B26pF9pdAHwVeVfzOH0TdOazRxZlzB6ufz+EYABD2AEXxs3xN/DEdcLn7QDR EZW1mnjIIPye6fMvwVFbKtrcp285wGmQWklk2rgXHlcG7+KTxn/TId8q+ni5LJtHIDPnzjs2zNY cEsjajsJJPKUgybKKU+ulnINHsJrdvLGewk1nsPYaC2dnpFzz+pnIkexSUXLi0+sSO3Pu5TPKXA DzJlz44v/WhVQZQe5L6KBpRj2Gsp4uVMI8NLGu1lzHWCx4I6HzHD4NGSRb/Rl54pRpF2Vlt4dcy BjzrYIkkIE44hFUcD/CELn7KiWR6AeY183xNCWpAihZrbQHTKhJRYnbk+NNt7E52ZLgUPIqlZ74 YkIThyrrje2jcBWOOqjKHR1loJS6nRZA+KTzEh5kRztT8ebBlDbvMoahPJ4XSdOdT3/X/0ZHDuk 6XmZhAlCSXyNDhtzpeEaZwFX8K/7Liv5QXMJDuWOo= X-Received: by 2002:a17:903:19d0:b0:2cf:906c:7d1 with SMTP id d9443c01a7336-2d0522978f8mr61488875ad.20.1785659960228; Sun, 02 Aug 2026 01:39:20 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-26.dlp.protect.broadcom.com. [144.49.247.26]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2d04b0fcaa9sm6324955ad.33.2026.08.02.01.39.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Aug 2026 01:39:20 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-930edb4362dso189296285a.3 for ; Sun, 02 Aug 2026 01:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785659959; x=1786264759; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=l0BprMNy/y+4QZvQsdZngDdHnMLVEPPrcOP8U8U2Ffw=; b=HQCw9lIOFaAuU41r+HXMD10ZE1QSUn1yz+NgyCr3DYmnu746HcBbIdTC7eYVeu45z0 KK0C/ntXVTxyT+sbtdM/1dtQqMzFPzkFmPVu1o5G4ktlZsVbH1/Fnpe2ngIcqnjW2PYi WcmMKmKSuQSvfoamDKNIRJPLk94laxSwnC4bU= X-Forwarded-Encrypted: i=1; AHgh+Rq0FrS7Y8rxqWK2EK+6XetAFthhfWkmy+bODlSHSYLJdcbqdFoV806PXNjaFyzWg1zs3ktUOx/pWY/AVfc=@vger.kernel.org X-Received: by 2002:a05:620a:a405:10b0:930:e48f:47c1 with SMTP id af79cd13be357-934a0a8b208mr890886785a.35.1785659958788; Sun, 02 Aug 2026 01:39:18 -0700 (PDT) X-Received: by 2002:a05:620a:a405:10b0:930:e48f:47c1 with SMTP id af79cd13be357-934a0a8b208mr890885385a.35.1785659958263; Sun, 02 Aug 2026 01:39:18 -0700 (PDT) Received: from bld-bun-02.bun.broadcom.net ([192.19.176.227]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-908435def8fsm49457956d6.38.2026.08.02.01.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 01:39:17 -0700 (PDT) From: Arend van Spriel To: Bogdan Nicolae Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, Arend van Spriel Subject: Re: [PATCH v2] wifi: brcmfmac: cyw: pass PMKID to firmware if present Date: Sun, 2 Aug 2026 10:39:02 +0200 Message-ID: <20260802083905.3819981-5-arend.vanspriel@broadcom.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260725013528.169218-1-bogdan.nicolae@gmail.com> References: <20260725013528.169218-1-bogdan.nicolae@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On Fri, 24 Jul 2026 20:35:28 -0500, Bogdan Nicolae wrote: > Zero out auth_status on initialization. Otherwise, garbage will > leak from the stack to the firmware (when ssid is less than 32 bytes > and/or when params->pmkid is set). Then, pass the params->pmkid to the > firmware (without it, the firmware caches a garbage PMKID on successful > authentication and denies a subsequent association request that includes > the PMKID). > > Signed-off-by: Bogdan Nicolae > --- > v2: Split into a separate patch > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Please add a Fixes tag and Cc stable: Cc: stable@vger.kernel.org Fixes: 66f909308a7c ("wifi: brcmfmac: cyw: support external SAE authentication in station mode") Acked-by: Arend van Spriel Regards, Arend