From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f225.google.com (mail-yw1-f225.google.com [209.85.128.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A53F0390CB9 for ; Sun, 2 Aug 2026 08:39:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785659969; cv=none; b=Cdd/2Ov+8Pa9YsHTfUwd2TjYvw2HlRJJ+jxb20scEQPYppAXq4OVvibz7s69femR+I0ZR/NIYQcLJ/muz250J4AgtxMgugiJdjDrPZWF+1VHZv0pwiftzney3eOWCyHDV1ojwrXjEXuA9/aFPWkI9wRzsWc++VaS1wtCI85g6Nc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785659969; c=relaxed/simple; bh=x4Y8UA5H6X2wKOtHY8Z9P3bq/NuZ+t9aLxAr2agzmGY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UgtYrJ8VfsWd+PfHuppThsjcgisiOyOpewPW1geeKt71O4dj+l1ZxizcfG3Sv0UHfK0C4cw1CoeQbdbZbWXKH0UgJg+CE2N+xCDc1QLh2Ybt7tkrYLIHk6xmPoMvxzOioedDlzipi0PcnsdBN6LUrVy+o2TI0uciG9jdzYWy+eE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=SUaFKJrn; arc=none smtp.client-ip=209.85.128.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="SUaFKJrn" Received: by mail-yw1-f225.google.com with SMTP id 00721157ae682-81f64e8dfbcso33076217b3.2 for ; Sun, 02 Aug 2026 01:39:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785659963; x=1786264763; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HU1HbP/1GwFKiZ4VPAfRk1yIp0CwwbjTWU4LCl4Ielc=; b=E3oJD2pDP2jOmG4ZFCtqlGll266Hq/CxO0s6MiJTUXTs5CbSPOSL01boBJjEY/YqGS 5ejSz5pFfnkQfAkWxlhKLw3lDbJ9uxM/QvO3cIvhTfRobGICSFJlG5KBwKESD2UEPqXr 4MFewTPkEGLtd4TaNjRQJvmRhEr2ToldWXZvOyYaa+kn/lD0EPyUgfBmLnTcLBEUhzyH 3zwcarVeawCWTao4vWipLcgTNaeKNjT569Du1usBt0bQI1aOwN+AEaFzPg+l3QKx8SVM ItzGqXB/F1KZkOBchfPR1mu7DadOMgSFk/+Ux/Ul9fVptrgOQBHxXQAD8L7Wa6gvT/DZ YO2A== X-Forwarded-Encrypted: i=1; AHgh+Rrf2WNUgXYyJK1u0GTSsgT/NjdiVhkwe8D/GyzVbCACJAXsStfXG9micW1vEJO9m5iOYJZGZztaMrGX7fE=@vger.kernel.org X-Gm-Message-State: AOJu0YyNvlOlwmOa7K6gOfqwPOMAIXQYP0kNHd6r547WFLqPzFjkUEZs 5uv6k7JslSx4IKj6yta9fJN3S+Fl+aovp2+c84yvpId0HhpswRmooEjTHjNEai1waFYpwF+fiX4 t45DTQ0G6HbdiQMBzxeBhZZGBYoSghm5OdiQudPMTjQlFKGxtgNWQhlKueYfbXdP+KHh/iBv9KV 9j4y+9Ah564Ed/2k2hmVUQJibfIFK/vq93aCFSOfiVwrDUdUtnjzgPB90bxGvS9hJN3cLkQxEG5 OLHMkSuCrxl1H9svelEwRQzYQ== X-Gm-Gg: AR+sD10AR2UccwaQuo7aFEwkJXtL8Lu4lNKF7JR85AhDaPjP7ZByrEBrYvWLuba2lg7 T1FymiHAfmO8QxWgvLZ7wDB7dardLgAQXL3XS3ewLz4mvhJg5tiVJ15t02Zsf4H9n4Fn50VVPdZ /Bca9ubuREz6KeenwaqTV2XMwzZwnMmHCSQrVBUsYGDGfZqiQEbX8mU7jrB19rTqDwKG73NHhXD ATPr/TVTZfN8hHl0UGmpNEABzdam5bHLrB+InWq9hxszgII7DXXrfVa9PifI17+rUAxVbAMhHjO TJu8n4NlTll+ET6k94gdtNKNBwfsCKY5gbWae0DQaxvh9s2GCm7KmH+e4xvo9iN6bfl/pP6It1Q GLzvXge3Bbcc+d9/LIc1TjRrRXO7RKq8N3kwqcMBrqGwC9raWVdHy643wD7v31L0cSMQ8uZaw6d AC5VnjdN9O4SkCx0h1kElnKq3RJ0o3wXb4MoSIgzQ= X-Received: by 2002:a05:690c:9983:b0:81d:a225:ecc0 with SMTP id 00721157ae682-81fd4b9e4c7mr83266467b3.27.1785659963236; Sun, 02 Aug 2026 01:39:23 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-26.dlp.protect.broadcom.com. [144.49.247.26]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-81fccf61afcsm3448947b3.9.2026.08.02.01.39.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Aug 2026 01:39:23 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8ef18406878so22935136d6.2 for ; Sun, 02 Aug 2026 01:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785659962; x=1786264762; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HU1HbP/1GwFKiZ4VPAfRk1yIp0CwwbjTWU4LCl4Ielc=; b=SUaFKJrn20rMNin5mVptfkQ/qNFtcSlkdQ2+0+B40jWhgtHPFen2hQiQqTZnwhAByi GSkBIqvOJPcpW1w0d9zj8/8iRYwF0mpKnNoaJ59BHAmcUJMh0FD1904VCSm6dfIaSp0L e2wGGnt3/qX+im5Sl1UtUcXxSm48BG5cbDnAY= X-Forwarded-Encrypted: i=1; AHgh+RptKaHCQAj12+PGUQjggVVImEHNzso/5ZuqcOohoaDAk4R2oztc66yYhwxERAOifpu9MX547AFaL8WsvxM=@vger.kernel.org X-Received: by 2002:a05:6214:3da0:b0:907:c6bb:5ce4 with SMTP id 6a1803df08f44-908496b0b3amr146522046d6.32.1785659962517; Sun, 02 Aug 2026 01:39:22 -0700 (PDT) X-Received: by 2002:a05:6214:3da0:b0:907:c6bb:5ce4 with SMTP id 6a1803df08f44-908496b0b3amr146521736d6.32.1785659962028; Sun, 02 Aug 2026 01:39:22 -0700 (PDT) Received: from bld-bun-02.bun.broadcom.net ([192.19.176.227]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-908435def8fsm49457956d6.38.2026.08.02.01.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 01:39:21 -0700 (PDT) From: Arend van Spriel To: Rosen Penev Cc: devicetree@vger.kernel.org, Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: net: wireless: brcm,bcm4329-fmac: add nvmem-consumer reference Date: Sun, 2 Aug 2026 10:39:04 +0200 Message-ID: <20260802083905.3819981-7-arend.vanspriel@broadcom.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260727225311.266596-1-rosenp@gmail.com> References: <20260727225311.266596-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On Mon, 27 Jul 2026 15:53:11 -0700, Rosen Penev wrote: > The brcm,bcm4329-fmac binding has unevaluatedProperties set to false > but does not allow nvmem-cells or nvmem-cell-names, which are used by > DTS files (e.g. bcm4709-linksys-ea9200.dts) to supply MAC addresses. > > The driver already supports nvmem-based MAC address retrieval via > of_get_mac_address(), so add the nvmem-consumer schema reference to > document and allow these properties. > --- > .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 + The problem is real but I think the fix belongs in network-class.yaml rather than the brcmfmac binding specifically. ethernet-controller.yaml already defines nvmem-cells and nvmem-cell-names for wired NICs, but the wireless binding hierarchy (wireless-controller.yaml -> network-class.yaml) is missing them. Fixing it in network-class.yaml would cover all network nodes at once instead of requiring each wireless driver to add the same reference individually. Regards, Arend