From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f226.google.com (mail-pl1-f226.google.com [209.85.214.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5416F340402 for ; Sun, 2 Aug 2026 08:39:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.226 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785659971; cv=none; b=cVV6be13l5LDrOqmmI2YzW73gOfwtOTDT5EHsXKDDps9XJT/RcpkMkufBWHxq1u4JIMrZ7r/ebvIvimcKPrEkWdsF2Pw/E8IFj6bEuIgWIzg/TGCmYQwhKFwZ0JRlid5CD5Eq/yBuSN996Ioxn2L9kGA4q5YfY1ggNlNmAvJ22U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785659971; c=relaxed/simple; bh=W3h7P7UQ6JCc4szLwupXzyRq863Ul8K0GSnjj2bwl+I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ffg964avzMntrDsu5e5RMmmMITkx0nKFhrHVDvHDHpg6/rXYzdIr46BDgTUsWSZn+fE6rSp3kD/kB1q0C/BwnXHdHM/xt/W40zu2E83DodBqiWi1SiBY6BzzKbnmzeONcklVQriSTm5trwHbYuakwH9Wrr+Vap1GOnHLy63/5UM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Cf5ztD9b; arc=none smtp.client-ip=209.85.214.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Cf5ztD9b" Received: by mail-pl1-f226.google.com with SMTP id d9443c01a7336-2cad8076b01so27038675ad.2 for ; Sun, 02 Aug 2026 01:39:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785659966; x=1786264766; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PNoZ92uFtSux85DfpCBQ1jLiUM/x2tYkPs+r4OTGkvM=; b=QQF6zKxX3d2pKBuijXYar5Y1r5MM/dPg8/Fkaz/wVuAPFfo+znfo6n51vPU5gAgCl2 isWeLgaqPfUYf+DFtLI6vvND9u1Zf0eN/Ys64DrKoBgwD9XlPqr1ln/QUmGSAztzWfhy 29ACcK1cMDX7aoAlutZnO0qaSF0d4//oNOBXKLCktagP4SC8IgpnezPDcq44DjUpozc+ 8xo0dNVrMjZj+1Obj7mEx518g//LL6QLlT7dsK7Mb91SPi/m7DK8QbIvuWFiBhDxTrzp El6XhF9T9SrrLC7VkhiRCmdyrnyEIS6Z++oZAVc7GmA4UJJmx1R804Ve6pwk6TIFzudW NKFA== X-Forwarded-Encrypted: i=1; AHgh+RoqI2aw6x3S5Otm7tSTBXhR/sNcYdC4NinBz0IfXT5ZhI7pPIsGFpih3hf8uREy9qT3oJ+oxYt9vlaFuHw=@vger.kernel.org X-Gm-Message-State: AOJu0YyjimqYGvcEMwBmBNpXzg4DiDJbR+rUvS0P0QKdKYPRzb0x0Nkf u82RAhcyu8Y/AvbQ+KawnT3CJ2+hMihxA+y2e1ac13LL1HTib1smKK2nWJil/XxOCA+5N1QS6SC 2iCgbgJG9HEZARBC5CfJvUcQHLSIrCdWie7xEjDLwmQjAoJhXrcy1V+L45cQGVu79bmyJN/Kele kx6W/0cItwrM2UIhBzsu+ZDVdpAS8Df4Sgp4qACfKf75GvPytNBLPD84gRhYMCVnm4NfpuDt2IP ItS74b+Vj1bQP1fIGoBgnf0zQ== X-Gm-Gg: AR+sD13RVAzIMgoeLNifBEuq2DWVkKRgQ5ThA52J2F5RkDiF8N15CeHoL/dOdIGuhdk F6fbdNuXpqqAUtQdokJvxzvsdbequRxraKp9bE9nqi4Veo/PxHQHpnqfE5ShtYY0fhE780V8xOl +UM6sVicumcsjyev+fl/O5+tr2HtaEP8jMPN1VLT9vydTLa3O9t2bRXcHjt14b76ZZg/mJCYKxq ETUeJ772aHErNYOBUqBXz7SKfJtOtHu3zKrsuFM8EyXSu7gUqPbuq9wJY7wTCS13nlmcIY9al/F UTQV4ZnIP+29Td0e3LljbESCtmn8eXkqptj10RIbVP1dBFoijGEEFz4VAHAG+ccfCVHWF/J+bXR M1Fxmz8es+fyuR4MzYw+iCEHXBbIUx03lCVYQXMTMEFtyTHn23ZAzlwfFOslSsUm9TM9nih2ekp ziZLSEDtMY+Y7uripMRa8M3liIpxA2ww3fcgwK8xQ= X-Received: by 2002:a17:902:f541:b0:2ca:5970:732d with SMTP id d9443c01a7336-2d0524810e8mr61952815ad.41.1785659965650; Sun, 02 Aug 2026 01:39:25 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-26.dlp.protect.broadcom.com. [144.49.247.26]) by smtp-relay.gmail.com with ESMTPS id 5a478bee46e88-3153e29175dsm445561eec.22.2026.08.02.01.39.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Aug 2026 01:39:25 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-90410c668adso24375446d6.1 for ; Sun, 02 Aug 2026 01:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785659964; x=1786264764; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PNoZ92uFtSux85DfpCBQ1jLiUM/x2tYkPs+r4OTGkvM=; b=Cf5ztD9bkTUZuxLbKPc1hCX9Te8MUMfphQptUtE13ixQHkweW/Q/PQMhjfBRuXXbFT ja9eH7CRCjZc/OGRK26jnC5brhmhDDY0aRwp8/HkyD5jE+md3Z6UbItHB3WLaR1p1O+d 1AsqAwmkkaPatdG5XOpM29ju1xmsRnDHETae0= X-Forwarded-Encrypted: i=1; AHgh+Ro0p9rw6WMAOKqjRGt0xp8BkGgTveswvgzgBLXuosAgIfjDJw0ss+HGsWe4beIpIaek2ZI1s1jQEUScKkA=@vger.kernel.org X-Received: by 2002:a05:6214:5015:b0:8e7:8d53:2417 with SMTP id 6a1803df08f44-908496389f6mr108159906d6.27.1785659964074; Sun, 02 Aug 2026 01:39:24 -0700 (PDT) X-Received: by 2002:a05:6214:5015:b0:8e7:8d53:2417 with SMTP id 6a1803df08f44-908496389f6mr108159676d6.27.1785659963646; Sun, 02 Aug 2026 01:39:23 -0700 (PDT) Received: from bld-bun-02.bun.broadcom.net ([192.19.176.227]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-908435def8fsm49457956d6.38.2026.08.02.01.39.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 01:39:23 -0700 (PDT) From: Arend van Spriel To: Bogdan Nicolae Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] wifi: brcmfmac: configure SAE PWE method for external SAE AP Date: Sun, 2 Aug 2026 10:39:05 +0200 Message-ID: <20260802083905.3819981-8-arend.vanspriel@broadcom.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260729053408.13715-1-bogdan.nicolae@gmail.com> References: <20260729053408.13715-1-bogdan.nicolae@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On Wed, 29 Jul 2026 00:34:08 -0500, Bogdan Nicolae wrote: > When bringing up a WPA3-SAE SoftAP with external (user space) SAE, the > driver never told the firmware which SAE Password Element (PWE) method to > accept. The firmware was observed to corrupt its heap over time due to > this omission, leading to firmware trap (data abort in heap allocator). > > Parse the beacon IEs on start_ap() and set the extsae_pwe iovar > accordingly: 2 when the RSNX IE advertises H2E, 1 when an H2E-only > membership selector is present, 0 otherwise. This matches the behaviour > of the upstream/vendor driver and only applies to SAE-capable APs when > external SAE is supported. > > Signed-off-by: Bogdan Nicolae > --- > .../broadcom/brcm80211/brcmfmac/cfg80211.c | 75 +++++++++++++++++++ > 1 file changed, 75 insertions(+) As discussed the extsae_pwe iovar is vendor specific so the fix needs to be gated on the CYW vendor. The cleanest approach would be to add a fwvid hook (following the pattern of set_sae_password in brcmfmac/cyw/) so brcmf_parse_configure_sae_pwe() is only invoked for CYW chipsets. [...] > +#define BSS_MEMBERSHIP_SELECTOR_SAE_H2E_ONLY 123 This is already defined as BSS_MEMBERSHIP_SELECTOR_SAE_H2E in . Please reuse the existing constant. [...] Regards, Arend