From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f97.google.com (mail-yx1-f97.google.com [74.125.224.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 499BD3939DE for ; Sun, 2 Aug 2026 10:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785665739; cv=none; b=F0FMNtCnD3GzWvPI/XGjxCsT8OusYNTCzQ0JSWi1YFhJuXhrNFSnpmfpR9R4lpk6vDJhRB4okNIxtvX3wie8vYyyZ0C51IXOcgpK5xz/Fqc0yFINDiHbcS9tZsvp6cNY52Txg2itccA2QclWH4UrTOukodd2xuFnE45NZVV6Uso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785665739; c=relaxed/simple; bh=MSSkEb803dp1gP2HBNhK12c9CPsMaiZ6pLgHJaHNeqY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oLDeSSu3Gj+0C2fGQLHMpUssFz2El0O7u4LmdhfGUpLJawFSsBZ72Lk+zdYMCt42elEucbaIWD3KzNFuxBYDgSGOmqOAVMe3g5z9To28hARaYJ65ShD6ZML0ds2xhUX4Lnt0v294Q6hSHcIMyrp6sbJOx/G0WLJMMsukdbgkTl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=RzPYTaDa; arc=none smtp.client-ip=74.125.224.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="RzPYTaDa" Received: by mail-yx1-f97.google.com with SMTP id 956f58d0204a3-6626b5ace23so5374894d50.0 for ; Sun, 02 Aug 2026 03:15:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785665737; x=1786270537; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1lDhnz0ePlnIggUFM9dMYWIu/4DcgouywlgpSKZ0Fo0=; b=J3Pb/ftpEC4IuTKRJQByF/28uPJNaE0h9J9vx4P02p4+Ae6yl0UXo7f8C+laNVwVjj H+9iiaMfauQjDGMLHGsrC8CpjTFi51yvw0hLcbhtPaRxB1wsdToflQn3Q19kGdXlOxDO A0JvzPRcrxNjcmloNd+fKOf7vxgAkeMLuXV4ypfBdiz1MID0kFd7x1tcxaJXKFk62ehm Exh18nFNoTReO0RyhHDNBu8X8cFk6KGUaNN9EHzFz1AzKqliIbcEqcDa4UuSVBrKsCq4 99kDIl8bN+9GDMQOmweWSHlbsuR0aR3q4Q2mw408JBOxZvXRghVTgOz9Pa+lQSIbWyeY Zfag== X-Forwarded-Encrypted: i=1; AHgh+RpM3G+zGljXxPMseVzO5ZsVyH+tuEj5LXR006ykL4U/2NNNrdvFVTKXH4QjbOzgnt14zJUL99EHVKoylBo=@vger.kernel.org X-Gm-Message-State: AOJu0YwfrsNp57Dnys6LasWk2TAH/R4TiSXOVdIyoW9UMOkFRHM6uurj e7WekBbMQHYcZ6Tuj/l+bfXE7f2PyuNcNU4SN2iJogG5GhvAb+P/vQhDggRuT7sWw39wdEVCZEW 3dWrsdlPfpLc83UbWdLosQJP2HznnJHvPhw/BlNqJL4fm9fm2FJTTpmt/62oWElD9Qs9o+jR32S x37cGtsLU79CDVjgrBUd0tU7o3HAxnDFycBgZj70AR5Fg79nGvFhnYkEE2Mxq1+lg2RkKph6Z+Y hQITGstTFc/deAh6GjW77esUQ== X-Gm-Gg: AR+sD12nBN3QjmkRFfovUtJ8TUqJt0HdzExbIzKgpPWo/0czywpMu+P6gmAB6Lm90GF u10K4/fURlsKzDvt9JVDows/uu4sdX9T6gw13gip3ECDOBeAwiHUcAlSdkO/wa3xDGN6HzdCTjE JTctRis8rAqfv1T/oHjhNRUSz7v2kqZFenDNgoRZnQvy/AzqFynkRIr6xz7WpUuaaNowhplbzAm 2TrzxyrgjxwBIJ1xnbyZlzR+D6bjxMTYyO2SR9Rcr2yvLRqtSj1pkGvletGAgH7K52fkDjoHHoI NFIGMzoBHjyxGV4rox1l+Oj4l88N1rz3UI8x1eAUCQkXNjWn9Pq1ccoAAPBIILC5LMo0ZoCoIw/ JO4aiqK3n8l/ZLZwHyiqDdzb2qQNSGgnC7F4gyYRzH4RkaZnjRL/c+j4Vj5T2gy8je8oBTXdhQu wGkcEBLmuaHT4YBE8xUVk2cCHSJjgNw4vwMIfUe5g= X-Received: by 2002:a05:690e:43d9:b0:668:9fa5:b9b9 with SMTP id 956f58d0204a3-6694f89df99mr4528183d50.9.1785665737073; Sun, 02 Aug 2026 03:15:37 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-22.dlp.protect.broadcom.com. [144.49.247.22]) by smtp-relay.gmail.com with ESMTPS id 956f58d0204a3-66948ea7383sm292200d50.11.2026.08.02.03.15.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Aug 2026 03:15:37 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cb6ef846b33so1694896a12.1 for ; Sun, 02 Aug 2026 03:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785665736; x=1786270536; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1lDhnz0ePlnIggUFM9dMYWIu/4DcgouywlgpSKZ0Fo0=; b=RzPYTaDaEAtWfHQ1MtPCLY9UeDr4TDtbRLBMXLeznFenABMgzjI7WiwcXCUwkEbhGH 2KSWQLU48MxEvkk2JFyf0H1LYjPAkeF23MtwRc3d1RgI/aqaLVfRAwQgfFDYL033Ob1Q dv+aiWA2HokC0BibmGqWu18Hrmm3mvb0iijAc= X-Forwarded-Encrypted: i=1; AHgh+RrODLmG3qodzGUn9KJ/7vfpMhO3HXUE7acOixilDvIC84acQXiJzS6qkq3GLFsWH3+fw6wVbeiG6yExPhI=@vger.kernel.org X-Received: by 2002:a05:6a21:e598:b0:3c6:6f25:594 with SMTP id adf61e73a8af0-3c91aa0a4f5mr8073842637.38.1785665735750; Sun, 02 Aug 2026 03:15:35 -0700 (PDT) X-Received: by 2002:a05:6a21:e598:b0:3c6:6f25:594 with SMTP id adf61e73a8af0-3c91aa0a4f5mr8073833637.38.1785665735336; Sun, 02 Aug 2026 03:15:35 -0700 (PDT) Received: from bld-bun-02.bun.broadcom.net ([192.19.176.227]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153dd9be04sm24193719eec.9.2026.08.02.03.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 03:15:34 -0700 (PDT) From: Arend van Spriel To: Shivesh Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/8] wifi: brcm80211: performance and stability fixes Date: Sun, 2 Aug 2026 12:15:30 +0200 Message-ID: <20260802101530.4028803-1-arend.vanspriel@broadcom.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260731160646.3812-1-chanelshivesh@gmail.com> References: <20260731160646.3812-1-chanelshivesh@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On Fri, 31 Jul 2026 16:06:17 +0000, Shivesh wrote: > This series fixes several performance bottlenecks and correctness > issues in both brcmfmac (PCIe/SDIO) and brcmsmac drivers. Two blockers need to be fixed before any of this can be applied: - 2/8: num++ was dropped from the subframe-parse loop. cnt is always 0 on return, so rd->seq_num += cnt - 1 underflows to 255 (u8) on every successful glom receive, corrupting sequence-number tracking for all subsequent packets. - 4/8: pmksa->fils_cache_id does not exist in struct cfg80211_pmksa; the correct field name is cache_id so this does not compile. Beyond the blockers, please split the series into separate submissions: 1. Stability and correctness fixes (3/8, 5/8 TX-stall fix, 6/8 Fixes tagged part) 2. Performance improvements (1/8, 2/8, 5/8, 6/8 performance parts) 3. New functionality and comment-only patches (4/8 PMKID_V2,7/8, 8/8) This makes it easier dealing with fixes that should go to stable trees. For the stability series you can add Cc: stable@vger.kernel.org and a Fixes: tag in the commit message. Regarding patch 1/8: the patch also fixes a race where a ring state changes RING_OPEN->RING_CLOSING while blocked causes a permanent netif queue stop. The fix relies on the atomic counter so keeping them together is fine, but this change is primarily a potential bug fix so rephrase the subject, e.g. "fix blocked-ring race permanently stopping queue" Finally, some of the commit messages seem to use LLM lingo so if there was a coding assistent used please add an Assisted-by tag as required by Documentation/process/coding-assistants.rst. Regards, Arend