From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A901397E64 for ; Sun, 2 Aug 2026 10:35:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785666949; cv=none; b=Oz3Ve23sCE+/CApmT8IBayPaKZPUL7KC2l1bGwbKiXoNo9dIliRWeVzN1z+AoS/Dv80X96ipS9yl26pfSFErc3J6eyxvgQHRlxAlGV1dXiXU9d3zvu7mlsstdpPQPSC6teYmsNbmApfeAUQjaqZ5+Vvh1jK9aC1gHr6pxtV2dVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785666949; c=relaxed/simple; bh=t35LtrHrvAj+5G4uXnmpwWQkMKS7VxycgcaRFW924P0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UUIdw7DZ+PYJfm7q+5JdcbIeIH3mT+nKCBOmVmI2RaTEFrRZw4hevNAqnoKGMI85ngDC0ZyUiOQtDlwSM7QEgSOEhbszrREG9cnwcCePDmTyTvWuJWFFkIKsnKRoIo6FYQpD5ZhvtybtsJLUAdsz6wa8k/jPW2L0jgJCB9ETjbQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jQ1FiCIe; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jQ1FiCIe" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38dfe910e9dso2299872a91.3 for ; Sun, 02 Aug 2026 03:35:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785666948; x=1786271748; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=t35LtrHrvAj+5G4uXnmpwWQkMKS7VxycgcaRFW924P0=; b=jQ1FiCIeWtJn0QX/apwMRy8XCeTGpwvmbmTk5QrkTSjH1H2pf7t9ZHUPhSX59xqBz2 GwkMyi3Lyjew3iqsHMJdCJuydZ9TjSl/DlrAgc82IYa54eIDoOLaTf2M2C9oejW5PtMx DA8YtFW/WgTENm12HGf86GRi03X9B3gzydTwO827jXOUZA64SdoyXNGFV8truAuIFl2U 7V7RM2mcPkJZeWafksGGdLLv9tyTsSpdFee9DN2qH2utD/85E6ToLZzqb6PNys1UjdsX 8kIBqpc1PDKaq/w94e6VKe2KffIA66rbf6rAM6M269shzZFmYqNlWgE9Bfd4nRRH1K1m hd7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785666948; x=1786271748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=t35LtrHrvAj+5G4uXnmpwWQkMKS7VxycgcaRFW924P0=; b=gPhnxgFmxsl530WuaH+YRs1PXMSTuTQbXlmO6en3gL0woP8q87JFyO9P09IbJzkGq1 UBo/I2NoejUVLwLipwdF5lQ7X1ZqIcsuM2/jF3z6hzRf/QCFm95YhZAHZSOPJSpseOIS pOzpVcms5A/kMH5Tm2Bbjy+tsMOg+cYXf87N7Z6YRvHl5QpdPqB+c49fv7d7+zGjQRiM s5aDYrVm798wdiX/iqCchK+d9C8s0oF78bItbn8dsZ5eT6s18sbgRrqvFU5vcQcMBQFV vqJ1U0yLfvIZvgw6e4RWKciQoX2K2WTonv0fYMW5uc963bRV12esut1Cbd7g/VS0mBxx mg+A== X-Forwarded-Encrypted: i=1; AHgh+RoAvpiIh6X3rvXBff70yVokzKY6Fkv1JE+B0UdgfQN5dlY5XPgBoJ7mUrIknmvLPq7h80pMYDDvdzj5/sE=@vger.kernel.org X-Gm-Message-State: AOJu0YziwL4WHt2ldrVoP9XWoJ94rqjkVr8WczETPKbFBJCdoXIjO7gb eAiX3G2EIyTcAZ5t1/b+D0o180giNqY/rra5HNEzEty8dfeiz+L3/0T1 X-Gm-Gg: AR+sD11L9oqwZgDKPe/eH8l5NEHL2w4m8XaY/6C13t8zHjiZSswMimR5vxtCdPJLjBE uSt/B4JUUfTO/JsQ1Vtpfo9W7+amt9OOKzSi/GWpCZcqg1LFrR7v3xMsNXxajVsA0usJLDrAaxo Bdi/sO64oZiqnufkt4+uaQveDryuo82CwP/27BrbVQt1fN4bJxXxGjc10FqCSP4D1eOE40Twswp S3VUrsNLJop2mTIoje/KCXaW39FXchyr8YS2v/ZuOew75guNA7AlhCnLzr8qqCaODg8/4YlP1xI Y90wmUqIRBa1DfaGrAkBcUDOgOM5INMY1uhKGevet4HpqazJ4dIPyZHPR+mBK8FaDn+Jpsj9g2a hxUtN8e8zite/o3TzGH6VBeffWBEP735zuZMrxHO1EA2zaAanmlZHciJOEdLeeq1DKyJ1wlMrOw 0Va2a4VbN9Ay6nVy8zP0eH49ir+ppq8wwYs1iNsci/e+Xq9Wa1/dZiRC0UVho= X-Received: by 2002:a17:90b:3a43:b0:38e:679f:3b2a with SMTP id 98e67ed59e1d1-38fbc4dd615mr5362391a91.30.1785666947686; Sun, 02 Aug 2026 03:35:47 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:a836:ada0:6830:9b96]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fab13255esm18687092c88.3.2026.08.02.03.35.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 03:35:47 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Andy Shevchenko , Joshua Crofts , Broadcom internal kernel list , David Lechner , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Mohammad Shahid Subject: Re: [PATCH v3 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() Date: Sun, 2 Aug 2026 16:05:20 +0530 Message-ID: <20260802103520.114582-1-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260802030433.696454fe@jic23-huawei> References: <20260802030433.696454fe@jic23-huawei> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid Hi Jonathan, Thanks for the detailed review and suggestions. I'll address the formatting comments in patch 3 and also reduce the unnecessary churn in patch 2 as you suggested. Regarding the suggestion to convert the probe cleanup to devm_add_action_or_reset(), my intention was to keep this series focused on the dev_err_probe() conversion and submit the devm-managed cleanup as a separate follow-up series, since it is a larger refactoring. Would that approach be acceptable, or would you prefer that the cleanup be included in this series? Thanks, Shahid