From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0098A286409 for ; Sun, 2 Aug 2026 14:49:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785682147; cv=none; b=OqVUVme/MkQV5Mrtt6rVTlkvYZ+feew208fPMKIwNJTAq0j0UvHOU0sLijTjrU2RxDdPzNs8vBHg6ZhvJekoXOF/cQ5odCSu1zeXMQITK1fnDIdqVDbHxRE+0Teg0VvJhioi3SxAtzOwZXToBdTx9jbt9KXGyd8CmdrC40W+8T8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785682147; c=relaxed/simple; bh=ngj4b8n2tyTE5tYCn196ZFhAf6O+AMCj14WGjH2lwX4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CUyyFGlKK38IAYQzkA2nNPZB5FVg/Mk3Z44CTjb5P5eS3nF2mrD2OINGkcegyZXs5z2OOoTVnPk28P66CKn0p5M6Y8kuR6OIcKUqicNXgDyhb9bW724WdnQaQqFAfkmGr2HhFvs4gTq/0PqVOGF/v8vXKdcras9fmTKQp+iH2Fw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=inIUcUWd; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="inIUcUWd" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-49800c6a846so11014385e9.3 for ; Sun, 02 Aug 2026 07:49:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785682144; x=1786286944; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=G89zE9K0cJl3MiaghXF7pZIuJbVf+x+jpLd1Z0Q4ABc=; b=inIUcUWdCzTdSXlms0aOUmt7c7M6TqKTwa4m2d3enjbMQ8Geul6fBVFuIHvXr2lpCl V+TPu/81Mvebrlork2UeVOl6H29gtagtbOdvQpSDoSbgF6mwAXNMTFABzefuPC01X7SN aJ3btiP+gojEec11/DZkkZXUzq+dGcan17d773xvk05ggebmew3p4sa52bMfN4Xvwjtx 66ooc6Isf4LG66dniHqKAF7Tkt9lfXS7hdqVjXLyZVt+WjJJtZOg3Zfv4EDlQN7OuWeE MBnO7MlZLSlCc2ZiYlV5XWb6YuNieEy4HBRyOCesWHLuoydoh4veZ4inAOhXA7chSu8z 2VRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785682144; x=1786286944; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=G89zE9K0cJl3MiaghXF7pZIuJbVf+x+jpLd1Z0Q4ABc=; b=n1HkYf1bOTQ0XirrQ/DTQML3UPZeA1SXBCSRgnDQXsXP942JR1xuBrvEx5dxAcJ5PZ mvjdhYDwc6Wdu57Bbu5dLJQmnf9U3f8akq1zdL0YpZj2v+ZBPrmgtt5MeXAyt1zDrfXB nsE54SJmshM0TzUYgfcN3x6HU2tlYAKDd7WkODtjtWVYA+jRD8LZ1fAefVLRKfGEaU0U R9VDA72KhlPQuswgE7NbgD0HUYz7pQtw9UVQPDP8MwgDrlFFwAdqvHNygG9DdzFeHC6j IHI5aJwzsciMuCPoiZPiasQKRZcxiC2OsPBgI41Vyzg/dnrEuFtEOiuAwPG9Y6PHCg8R Sgag== X-Forwarded-Encrypted: i=1; AHgh+Rqjbq0J793CGHmizrmUVNeGPpfeaB0wuhO5QBtTBzZJikvyAjZwN7H6jRXCnKG8IBhcns9jeKSCSyujWUQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0Upu9u0I/hjRo9HRSgfxATcKC/ugzBt2vn2U3xFcA2oIPI8bW xFDHQHwWI+nESGPr8Us74daG8Rtfo99o7s1TsEAMbTFjb/8z5vK6F4jw X-Gm-Gg: AR+sD10sQVqc/1Ps6749qdmiWPG3QrgXeUgJz3qq4EpCrZXfkCzjXC8oC90xrDjEdsD Y4A5b0OiKYTMLlTpIHlLJiHcVWLJcVOplM5zn6BeG2tP+9OIW5hHvmw3sPcjNBQdFr52EUelAV9 nYfkbzNlHbUufKZiEKKM5PpoiHq9w8mUIWtT2JIv4DZ0Xd58PiihFQsPaT9MeYASG9TjlYfNguM yOsOpUYSW//DjLS+NIwKR9Wx9vYH4087xKVjE6v0b83sF3ZsYKahHeicQaFFEGudH2Ru2bwAc99 7C01yz+AyUWCpdnX0TBngFEehDwc7+bcrWY8iJTF98tpZn7St5P53B8H0Pg+eIukIqn+E8RX4Hd nbvb/7aNNWmLJ1sDaX6VHi+D03UTC0X2sJz4y3n8rO+Sz6OuTPK11wGjXDMWavPU+t9j0nZrscX fSEHOSXL0/JfcSSxUDBtJggI7XodOsfPNAob0NL5sze0l6u0feJVNDqxJnngDDsnculuVHxzg6C /K5uOJXaKa2SG269fhbks++uHZuS74OidZ4Benz66t+A2Vy7b89 X-Received: by 2002:a05:600c:19cf:b0:493:bb29:af40 with SMTP id 5b1f17b1804b1-4980c674808mr124471625e9.14.1785682143958; Sun, 02 Aug 2026 07:49:03 -0700 (PDT) Received: from nixos-office (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd45a1abfsm23844189f8f.37.2026.08.02.07.49.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 07:49:03 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com Cc: arnd@arndb.de, rosenp@gmail.com, chancel.liu@nxp.com, jonsmirl@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Julian Braha Subject: [PATCH] ASoC: fix unmet dependencies on PPC_BESTCOMM and SND_SOC_AC97_BUS Date: Sun, 2 Aug 2026 15:48:55 +0100 Message-ID: <20260802144855.3596995-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA both select SND_SOC_MPC5200_AC97 without ensuring that its dependency on PPC_BESTCOMM is met. This causes unmet dependencies such as: WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on [n]: SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_BESTCOMM [=n] Selected by [m]: - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y] SND_MPC52xx_SOC_EFIKA also selects SND_SOC_STAC9766 without ensuring its dependency on SND_SOC_AC97_BUS is met. Let's resolve all 3 unmet dependencies by adding the dependencies on PPC_BESTCOMM where needed, and selecting SND_SOC_AC97_BUS as other, similar options in this subsystem do. These unmet dependency bugs were detected by kconfirm, a static analysis tool for Kconfig. Fixes: a9262c4fd404 ("ASoC: Support for AC97 on Phytec pmc030 base board.") Fixes: 6ffee43ecf8b ("ASoC: Fabric bindings for STAC9766 on the Efika") Signed-off-by: Julian Braha --- sound/soc/fsl/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index 8ae59c094878..a5d7cf534391 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97 config SND_MPC52xx_SOC_PCM030 tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712" - depends on PPC_MPC5200_SIMPLE + depends on PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_WM9712 help @@ -253,6 +253,8 @@ config SND_MPC52xx_SOC_PCM030 config SND_MPC52xx_SOC_EFIKA tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" depends on PPC_EFIKA + depends on PPC_BESTCOMM + select SND_SOC_AC97_BUS select SND_SOC_MPC5200_AC97 select SND_SOC_STAC9766 help -- 2.55.0