From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82B8F3B8BDA for ; Sun, 2 Aug 2026 15:55:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785686155; cv=none; b=uPEdy+D+KhHFRLb24r8gGsR3VGwx6D2eQCVPDxEQWcqIpf/VWniJhxszTAesvKbhL3wCRwem1qIjl5hWVkbwvCiT8LNC/P0twz2rgqNKDmo7VKwicSt0Z/fvdqIPdkfWIpzyGPOegOxAOim7/p3aNHYH4OfoyWL2kWYEdJXCXUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785686155; c=relaxed/simple; bh=xcmHUCE5IgFboJHmroyLqqW8EiS5ElHFHrQPDGoU2iU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gpk2TbJHLXab16NYsprk7pErBq+3NANYR6tUYgQ74HMSliTeY8z+l3ahKKv5I02qwPUsC3DF5sdDvyzT03qOGXeZ5H1l9HULRhHl8CA7npMlQpYkvGhug6Nmki8AVx/CTP13XqmX1HT6PIa0DPf4ZbsGzgNaJifU/07yDQyKBLQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jm8gqLru; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jm8gqLru" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-6a0c8283146so1299156a12.0 for ; Sun, 02 Aug 2026 08:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785686153; x=1786290953; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ikcYVMKfm2PfttYrRPgFLnBVdWxWGxC5+Pnq2dtQCtU=; b=jm8gqLruSj+mLThjTFSBZKTybI8bB0uyKuuAdOJvVRR7YqYnlYwwrN934alOPJenHP toSX6mMMMTulhBpO7HenmXoBeyc01l9idKhUycpSl5aC/OY/v3sVFNyks3onOEboyilb QJ57jvP7s3cjyWh/i5E4PIRpKWIINaRgz46K0Baim8CvdaLH6TOxIG367Wn/z5LvpzmX 63AA9p0n5qB7C3dPG3+Ux4tjEbhz7+nv8FZDs/PT+NnMGH8HAQCc1/Rf5fIZiXNTvgHc 7VZFUY2V0PXHNdY5b31ZV30kQ3Sz4KV/1/yUJqs16W3EstNZ9oqSHIfg1KCYehT5+vWz BPvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785686153; x=1786290953; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ikcYVMKfm2PfttYrRPgFLnBVdWxWGxC5+Pnq2dtQCtU=; b=Nk5sZlOPyLebRLg1cXOcP0w719BfLQhn82NcM8W5aA9eqyUsOko5qcxCBQQSZefYB5 VUUCDvfIJaAlvpjoNpAXX3SZ4xym3bPgzh7LQk9o8wGKWlA6Ij9ErltG+AdIBqPO+PcS inv95Pm9UzL7RoTmLhNmq+hzg0yzYpglbD86a1wj5EgSkmegTXuxLqzcwSJ5p+84Qvi7 QVoR6rZiE5k0KZ8x1DOpjsd61VBeria3ESd/BmoWuoCykbF/wCv1+CnWc/o9ld8tNaVm 7hzKkDOW3ssv43mA2ZOGsFTFnjA4TmBeD/S45MMHcLMnC2DA9j7yyaGPM5y89e6zKTY6 8cIw== X-Forwarded-Encrypted: i=1; AHgh+Ro77yetZ3U1UANI/lGChqa0qDlM5Gt7+oz5lOfW+EE2usg8rTGcluyXOewoLrtcIkcETifaAjhB/KAUAXw=@vger.kernel.org X-Gm-Message-State: AOJu0YzYPjxndevkeNQZpXVo4oAXLvkL3yphedsIWJBn6yKzgKa66Y2H TEjRHJh1gyggHFSngBWf5ib4iZ8HT9Gxb+MCd/UPRJbicXnNrqFw5DtR X-Gm-Gg: AR+sD122Tpxjc4SwP1BhoGv+603hl8poIhf14VTEqotX6dlXQwKt3ChewPWtHAWtoL+ +Ugxe2baZvTAhbUu1HbtpjpkldSBLWUR7jAOltTLuKTN6qx8Cr8QqbfVasm307OER96r5XUJjxt +12tE+pxLqUCQvLmZj8UaeE81KgyES01NqvP4pGOqmyQeoYSyBSkFLeWh5NDkaEXk+P6kAHJsTj IzzPMFrxZnFwvFTB6T6WFL1nCn4Me2+9S5Ni5/o0N5LD4Lw1TCA+hJnchiwzvug2fIw51rz0jy2 Prk18VmIR6RXGuMFiO+cMiVmsgdew8JpbmB6o+sd23ryWvmAzr0YkSubM2/l8jupvbMITrFq2wj iDR7n3pqvrfdEvvCC2JJHAXCw6hHROZRpl99KWHTfWKl+Pfjc1GgaauKa+Z91ntECPy5sbrGfE2 R9dy4V0VK0RKd/CYvyEBWq7M79ru0nQDQdw+wO07cH746P3lxoF94ZV4KDvdlR26UkeJATZq7Ku /Urki2gP90glrOnHIXQG8nRLCU3KxS1dGowfvCKhJ0eXR2Ieudhm+R9aCMn5I3wp5uv59nr91/4 ERHm5FPFX1aMoWpeVqTp4YeQwBikQGQR82KJ0lbvzcsmCQSDhce9kvd6mwxmjHN4vn/G0HQCBjv gZvHcbFMUfjfVIu9B6sFTCKHDLjzvzFLVobzQp6jYqkeJJHQ= X-Received: by 2002:a17:906:5054:b0:c1f:983f:d8a with SMTP id a640c23a62f3a-c1fe7f13483mr399043766b.24.1785686152655; Sun, 02 Aug 2026 08:55:52 -0700 (PDT) Received: from systembl0wer ([185.94.52.228]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd44542ddsm462288566b.29.2026.08.02.08.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 08:55:52 -0700 (PDT) Date: Sun, 2 Aug 2026 17:55:47 +0200 From: Joshua Crofts To: Cong Nguyen Cc: Linus Walleij , Jonathan Cameron , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: gyro: mpu3050: fix sign of raw angular velocity readings Message-ID: <20260802175517.288bd5a9@systembl0wer> In-Reply-To: <20260802065540.8120-1-congnt264@gmail.com> References: <20260802065540.8120-1-congnt264@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 2 Aug 2026 13:55:40 +0700 Cong Nguyen wrote: > The MPU-3050 gyroscope output registers hold 16-bit two's complement > values; the angular velocity channels are declared with .sign = 's'. > When mpu3050_read_raw() handles IIO_CHAN_INFO_RAW it reads the register > via a big-endian regmap_bulk_read() and assigns it with: > > *val = be16_to_cpu(raw_val); > > be16_to_cpu() yields an unsigned 16-bit quantity, so negative rates > (bit 15 set) are reported to userspace as large positive integers > (e.g. -1 becomes 65535) instead of the correct negative value. > > Cast to s16 before the assignment, matching the temperature channel a > few lines above which already handles the sign correctly. > LGTM. Reviewed-by: Joshua Crofts -- Kind regards, Joshua Crofts