mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Philip Mueller <philm@manjaro.org>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
	"Alex Lanzano" <lanzano.alex@gmail.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] iio: imu: bmi270: Match PNP ID found on OneXPlayer X1 Pro (AMD)
Date: Sun, 2 Aug 2026 18:58:14 +0100	[thread overview]
Message-ID: <20260802185814.431a6425@jic23-huawei> (raw)
In-Reply-To: <20260731195325.44453-3-philm@manjaro.org>

On Fri, 31 Jul 2026 21:53:23 +0200
Philip Mueller <philm@manjaro.org> wrote:

> The OneXPlayer X1 Pro (AMD) uses 10EC5280 rather than BMI0260 or BOSC0260 as PNP ID.

Groan.  That's a realtech PCI ID not a PNP or ACPI ID.  Those can be used in
ACPI but far as I know realtech never made IMUs.  

More of an issue is this ID is already in the bmi160_i2c driver.
If they are using it for both parts we have a nasty problem
and it is probably a thing to fix as a platform quirk rather than in the
drivers.

There is a bunch of history of this ID 
https://lore.kernel.org/linux-iio/?q=10EC5280

IIRC Bosch provide their own mega driver supporting all parts from one module
and then do part detection.  Thus wrong tables often work :(

Jonathan



> Adding the ID will enable the BMI260 accelerometer on the device using the bmi270 driver.
> 
> Closes: https://github.com/ublue-os/bazzite/issues/4805
> Cc: stable@vger.kernel.org # 6.18+
> Signed-off-by: Philip Mueller <philm@manjaro.org>
> ---
>  drivers/iio/imu/bmi270/bmi270_i2c.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/imu/bmi270/bmi270_i2c.c b/drivers/iio/imu/bmi270/bmi270_i2c.c
> index 036c6f0f7cd4..d7faebcbd2fa 100644
> --- a/drivers/iio/imu/bmi270/bmi270_i2c.c
> +++ b/drivers/iio/imu/bmi270/bmi270_i2c.c
> @@ -45,6 +45,8 @@ static const struct acpi_device_id bmi270_acpi_match[] = {
>  	{ "BMI0260",  (kernel_ulong_t)&bmi260_chip_info },
>  	/* OrangePi Neo 2026 (since BIOS BCPH01_V1.20), etc. */
>  	{ "BOSC0260", (kernel_ulong_t)&bmi260_chip_info },
> +	/* OneXPlayer X1 Pro (AMD), etc. */
> +	{ "10EC5280", (kernel_ulong_t)&bmi260_chip_info },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(acpi, bmi270_acpi_match);


  reply	other threads:[~2026-08-02 17:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31 19:53 [PATCH 0/4] iio: imu: bmi270: Match PNP ID found on gaming handheld firmwares Philip Mueller
2026-07-31 19:53 ` [PATCH 1/4] iio: imu: bmi270: Match PNP ID found on OrangePi Neo 2026 Philip Mueller
2026-08-02 17:47   ` Jonathan Cameron
2026-07-31 19:53 ` [PATCH 2/4] iio: imu: bmi270: Match PNP ID found on OneXPlayer X1 Pro (AMD) Philip Mueller
2026-08-02 17:58   ` Jonathan Cameron [this message]
2026-08-10 19:04   ` Andy Shevchenko
2026-07-31 19:53 ` [PATCH 3/4] iio: imu: bmi270: add BOSC0160 PNP ID for gaming handhelds Philip Mueller
2026-08-02 18:01   ` Jonathan Cameron
2026-08-10 19:05   ` Andy Shevchenko
2026-07-31 19:53 ` [PATCH 4/4] iio: imu: bmi270: fix typo found in dc757dc Philip Mueller
2026-08-02 18:02   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260802185814.431a6425@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=lanzano.alex@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=philm@manjaro.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®