From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E57C3803D3 for ; Mon, 3 Aug 2026 10:32:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785753133; cv=none; b=l3wX3NQsCo6f87nXL9j1wZV64nxuEU2w6r/L5MYP468Z9eDspLe4UZ4e79P6mjiBSBcis0gHW9msZU4AlKx9StlFCK/qhmIroV8vcIUWuLOj4gEOOjh5E9wirXhV3R0MS8+i2I6D2ul3S9h19baQFX1m1lw2A2HUm4h6sQi0mEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785753133; c=relaxed/simple; bh=YQodrxLZXGti3XmvW8nwU9lpi/9j4ifCS2HxijUaHDk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=epZ3pXZNoTGpSco2nEV0zfo1JWBRVGDqWu4LZ/PrFPGXh1vWcbDXOkGIGaWiL3midkxYJpvPNqztmlvbQfdTTPqsEoRauUr4UjRbgryVi+9QrsY7FzayMz72VU5WKC1YQWvbi1MN0Pm7zcclPPRBHxMXmV3d/tC0IjW7K9z0as4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Vu4Jb7gB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cbIdnpCd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Vu4Jb7gB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cbIdnpCd" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6736bXVr3957265 for ; Mon, 3 Aug 2026 10:32:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hhWKGvX0bNeNwHOozHVzgVNQHnYcAVFkH32Yo6rHh38=; b=Vu4Jb7gB3declPWK TI3ECB0a8FvuRnE+D/jzRkJmWnbzJac120CngS1IhSZayxc7b9m4tP74KA7HjzI0 +Hr4EmydHJ/DbcOv5kOQ83iOgtoNvmG06zuFKdriQHYHbp1PSU3aENjow4ucZbmg DOidSr8lKRiL8ntegXqq0+5mO0vfXX6G+6pZvhhQQO/38cQ+JB8Kht/drncw1GGJ +kWFiQuNIvA0+o773xfVNWk3oNepwb9E151S+Ji/WULvobiHMp7evIdT5hIBn+sx 4AjzSC2+A1KUEa0UKvSnu4sYplS7jMo07ulsrleYdoBQayosyJwfNMx8AlFfhFyo jHfApA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ftnvnh16p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Aug 2026 10:32:09 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38f283baf1fso3100857a91.3 for ; Mon, 03 Aug 2026 03:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785753128; x=1786357928; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hhWKGvX0bNeNwHOozHVzgVNQHnYcAVFkH32Yo6rHh38=; b=cbIdnpCdJdN60W+wVZCuB0cFQzbgYAr1ZjxF7W2lJuF3RhmJWtipwTtFi5jE2HkKEK NNbZb4DGAKPnf0/PBRLNXi8KQ5XvDl0KlMq4J6Wo9x1dAqt6s3d5mB05e8ib3AzIE33s qLLoWTMOdWqDkZm7yrgwmsrWc8mj5COoP4zLQo4miVdp9Kby9147Jv7inAnYhZaiTqQ0 iU+JJ/B7LorBsMw5W+4CU7XAvucxU4I843UlOBuzAOgMn/Z2amTX+LGTB8Lu2MtnTbOf MHlFYOzzsZn6xnW+itjyBt+PQkquoJtfywPbf+ALq9yueIr1DjWzWgvG2ijvZ4aNJf1K YmLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785753128; x=1786357928; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hhWKGvX0bNeNwHOozHVzgVNQHnYcAVFkH32Yo6rHh38=; b=X4fgKC26HoxLKzoRXyF0lJrZVW9XNmXGIN63ic65CGbD1anaSVEhDFiclEELdltjQt dvPI/1jOt2z/YyGocJe8zvRyYoSJtab/nvkzcnN9jDKesxUvyPsLI++IqgvvhzsjfAuN jVWv6XET5FI9mWdf0qvIspeh/Lj9srMz9elk+xjyJsN3QZEusTXcr1U67T40s3LfRNmL wKhaQ4P8q8tg5yxU5mSepJ1vESunAld8VII645h5RY/DZuWHGET+zVuVPC4c5EIMjt6A BATeIyTpio9RRwArS/cwXBT9wR+q3oMBzMkmeGbUw0ou2ImVFMyL/O9oFsd4ocx2lP8G BlPg== X-Forwarded-Encrypted: i=1; AHgh+Rr7WWsDBTaDNj5+qy8bsnfSrRjORFdJaKkqeNvAODEF1QDY5Tum4LUyKecPqLXnYE6laJKTyxeTDKer9As=@vger.kernel.org X-Gm-Message-State: AOJu0YyB3qHXsM3VaN1LcNsOcMQxVl65joAJU3WUoKittljhvdjq5Pf9 Jvv4PYSQI7Zx7Q5RP+qD7zzQxGRgW7qVpTwoX8vIicyg/T6BqqniDjmZQHMHnYjTuy8qJ2FlDlB GEofy5tSvXcevUNPLjvSIvkJsrRubMx0wtEpQ6OgZF4pENUVM5BKK3nbBP0Vxm6bVIXw= X-Gm-Gg: AR+sD11eLXBSFxkSbFN39aRPJjN8FXrDPwy/Fhp1KOXNtgBm62/jrVezdXIaEDXu4SK 8r1IHUWSsPDTCxvQ35g+D9aAVDzwXOTsYIT9gKI6J6G1hsBo5TSIWalAaPO3vH9vSldE1e8pfE9 24Ig1vleeKNTojmfL0FB2HhWo0+EHjGEyZHZi4RmXb9Yy/Y/CK107KQRlXEfdMA1PjabBcZRoKw EHIjE/VxAoEo5fj6FeIhTlubBeSTNEf2OOqHz36K1xccIvYa3KDwFriA8yJHatqOzaeaoSGN82r W78967NWkAKHnuTzIePiMxnOsQ0vN+a92pltZwiPwQPSftCbXmiHeMsq08R4/ojK1R0McpLBTbY nxWDF6krhyxnj3wC/Qz6U4hzcug== X-Received: by 2002:a17:90b:58c3:b0:389:8f6c:4d59 with SMTP id 98e67ed59e1d1-38fbc4bc3cbmr8623154a91.24.1785753128248; Mon, 03 Aug 2026 03:32:08 -0700 (PDT) X-Received: by 2002:a17:90b:58c3:b0:389:8f6c:4d59 with SMTP id 98e67ed59e1d1-38fbc4bc3cbmr8623122a91.24.1785753127669; Mon, 03 Aug 2026 03:32:07 -0700 (PDT) Received: from hu-sumk-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fb2b1244bsm3693427a91.0.2026.08.03.03.32.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 03:32:07 -0700 (PDT) From: Sumit Kumar Date: Mon, 03 Aug 2026 16:01:45 +0530 Subject: [PATCH v2 3/5] PCI: epf-mhi: Use a define for the DMA transfer timeout Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260803-dma_multi_sg-v2-3-c12bb05e42d6@oss.qualcomm.com> References: <20260803-dma_multi_sg-v2-0-c12bb05e42d6@oss.qualcomm.com> In-Reply-To: <20260803-dma_multi_sg-v2-0-c12bb05e42d6@oss.qualcomm.com> To: Vinod Koul , Frank Li , Jonathan Corbet , Shuah Khan , Manivannan Sadhasivam , Jeff Hugo , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas Cc: dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, Sumit Kumar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785753106; l=1737; i=sumit.kumar@oss.qualcomm.com; s=20250409; h=from:subject:message-id; bh=YQodrxLZXGti3XmvW8nwU9lpi/9j4ifCS2HxijUaHDk=; b=rcBxb1zUyIP4s50AcsJ6tkSwDs7jalf+WtVec3AVWiM+5ZsHiNUzXBYpOlzh8jiw2Jacuj4Ec tl6wkE1qXPxBIdwVaF+mpN3ZJYM4JlQEETY7EYgWiO8hxuAAq1WXNMf X-Developer-Key: i=sumit.kumar@oss.qualcomm.com; a=ed25519; pk=3cys6srXqLACgA68n7n7KjDeM9JiMK1w6VxzMxr0dnM= X-Authority-Analysis: v=2.4 cv=aoaCzyZV c=1 sm=1 tr=0 ts=6a706e29 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=K2uzCxK3BSS_9ZXfCP0A:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: MnAOLPLxYN12lLujy9LFgFcsR0OO-5CI X-Proofpoint-ORIG-GUID: MnAOLPLxYN12lLujy9LFgFcsR0OO-5CI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAzMDA5NCBTYWx0ZWRfX9ApjU/UPQWAn /EvO87Lo32VcUUNpENaiDMJvdfJKKbMuF1r4gvCd1yNqxzlWgGU+NLG9MGL4+1YeIN5z3w5HXx9 dZ6fj09llSFeoT/Z2lKE6l8+R+7FFGRSSUSU4amxThlJhLgK2keGRwv4ng1f1ceQnxO4Q7tdNmk IRJQev9ASM9zcZ6RVcW6keh+JFRDBs/HHxHzlWi2aJBngHGbe3+CDTxrzp6Wj7evJ6QuAtqaURU B9AjVwg1u4jj1WMJCK9Gh8CZwft6lnA9UnI+wyvWnrabH+IBgq2xLBlQ/8OIHRrRWg4J4rImokI co0zPMVG2hAyPWyljwB7MFXS6QOgnQvF3RRK8bbx0uRERKEHu246n09YrS/wRWlmDE/iMR6IhOM qCwiWfDV6hQ2zWdP5x4Tvukql0XJLc02ELWZwIfG1n+QSWtjQfnddHeBYZTm0O5Jca4xCTfGnuB 4Wj407nOwAQVnWF307w== X-Proofpoint-Spam-Info: AW1haW4tMjYwODAzMDA5NCBTYWx0ZWRfXy2sduUpVT0PO Egs0XH6wECjV6+E1UaLqPy09H3wbU5my2w0qxG9a6De4uOJ9Iv+z3vANtKnr+IcCA98p286N3Xm if+lfP2nK5lgE5WLYM7tadxJQAoyrdk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_06,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030094 The eDMA read and write paths open-code a 1000 ms completion timeout as a msecs_to_jiffies(1000) literal. Replace both with a PCI_EPF_MHI_DMA_TIMEOUT_MS define so the value is named and shared. No functional change. Signed-off-by: Sumit Kumar --- drivers/pci/endpoint/functions/pci-epf-mhi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-mhi.c b/drivers/pci/endpoint/functions/pci-epf-mhi.c index c3e3b58fb86cd75e175b69ca45530610c500b99e..6bac69fc84b472c5f1abbeede2b441b5db73c784 100644 --- a/drivers/pci/endpoint/functions/pci-epf-mhi.c +++ b/drivers/pci/endpoint/functions/pci-epf-mhi.c @@ -21,6 +21,8 @@ /* Platform specific flags */ #define MHI_EPF_USE_DMA BIT(0) +#define PCI_EPF_MHI_DMA_TIMEOUT_MS 1000 + struct pci_epf_mhi_dma_transfer { struct pci_epf_mhi *epf_mhi; struct mhi_ep_buf_info buf_info; @@ -357,7 +359,7 @@ static int pci_epf_mhi_edma_read(struct mhi_ep_cntrl *mhi_cntrl, } dma_async_issue_pending(chan); - ret = wait_for_completion_timeout(&complete, msecs_to_jiffies(1000)); + ret = wait_for_completion_timeout(&complete, msecs_to_jiffies(PCI_EPF_MHI_DMA_TIMEOUT_MS)); if (!ret) { dev_err(dev, "DMA transfer timeout\n"); dmaengine_terminate_sync(chan); @@ -425,7 +427,7 @@ static int pci_epf_mhi_edma_write(struct mhi_ep_cntrl *mhi_cntrl, } dma_async_issue_pending(chan); - ret = wait_for_completion_timeout(&complete, msecs_to_jiffies(1000)); + ret = wait_for_completion_timeout(&complete, msecs_to_jiffies(PCI_EPF_MHI_DMA_TIMEOUT_MS)); if (!ret) { dev_err(dev, "DMA transfer timeout\n"); dmaengine_terminate_sync(chan); -- 2.34.1