From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92EA343552B for ; Mon, 3 Aug 2026 18:46:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785782812; cv=none; b=fnsV4h6YBvcaUNluiwuXJIZNBqnTA3jjlSRm4FtzkOMcJTzhmKVAcJQ5NMyhWkX7Jt+DQ9OQFZ97NUgNGI3HJuYksj1cvFV6MFY3gKnSe4gnyuL4aClW0v9b0x0KyHs5hvACFpaB1LZfGgz8lIq1Zm8mF70uHf+QfrhfPSPHkbw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785782812; c=relaxed/simple; bh=Uf8he7nAsG/KRuBT/yGn3TrZ1ExEAQm9BaOvzIjqfp4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fZFn+/Uf+hhSEbT5ZIduW36gTSQqm/ZJ3vnhshYRcQIH2VOrs+zeb/htRVe/Pv/tzNRgfoNTjwMRCYx/SA5dABlIK4y0kjdmoyrYcxDlTHZEic7LXChXjpl/XeEW5DxeNTCUoaPUZl2vgq+ErVLI2twIEA297S4Nh6JKdtwdtD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V7/0T1m2; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V7/0T1m2" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-84a4d8fd6ecso4011799b3a.1 for ; Mon, 03 Aug 2026 11:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785782808; x=1786387608; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=87bvLzjv5ZZpsa24dDBIH3Ak2KXTk9+GG+h8XVlqydU=; b=V7/0T1m2pKy5JIoxdxw587Ans8MZ52s3+7VT5Otak3wz43+yBND7QqRp1pTalwv/IP 5qvZlyrfUUYHLXh20nPCPWn8C9w6Fn9f2ocz2uf3rwmqAm14LDaZ3z2Xfe6pc11NlW/q jnG9akAG6xcDjkJg+uDc3+DF3+dffYXkURl+CpyfWOlFeykOE3iHuZVqIoRrGQk5xPTk s+B39781ZYOGFe8siOO0cal1RwjZZNTyDUj4SCVzk6SnIPkqH6iVze/9fkf/ERA4L/EP 7UNBLxowUXw5VpLmgNBurqAUk5DYbWc7lH+VEjZLTik75bh5ZIhse9v5L+p8K1qFHKxm 8/0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785782808; x=1786387608; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=87bvLzjv5ZZpsa24dDBIH3Ak2KXTk9+GG+h8XVlqydU=; b=r7m3+tkcDxkkPVwBX9r/jQgEuEOC6Z6mCqXugUiI9/L/J8mcEIA5gBU4Zwk/wNdzYA p5fFCIxlSzqDamyuVvJ+dDoMugPNUgYBNkfSFTBiNFhVe0X3Pof7+SQ2Sjc5sPbbnyup 5vS1gAkCrUD09vSOxND/86PW1VmtLsXDKrGvbJDpusHt7LIkFQZ1xR2zQNsQ4A4SYu0f Y0AOt1DBXsR5eJVQ0CQIQjXVMYRxbubzSAcOsd3UwEi63H44rP9dX1ShmzuUYERU/W8A Ww0G3YfbdNjozGIwqPDzcBJheKchYfJsn6uUNbeHgNWUe+qllqp2YDgLzHMDVjB4N+LH MfoA== X-Forwarded-Encrypted: i=1; AHgh+RpsUYpg76A/2etbRIgvgS6r2yPsuYJuFTSukM5TjyHGISq3y8E0jgKUu5qRhlARi2vzO96HgNJ5f8/CUqQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywm15ACm9JTAWMoszjKqtOR27fKcQWw8WKwWSZI2+hjl8PY2hUG 9fClcSsZZeyidEIaJEQniH59CxxmQt9RYy4J3nLo0wRW26Ba0rDJWV7y X-Gm-Gg: AR+sD113LoruOlh4WWPnFTPjp8CwbGPlDzd8glLQ4iR7xFC68+/zvwKC+xgPTEmMn6j tlBlZS4YblvhhwRHR0f/E14r2cvxhh+ykV7wmpN/TWPx6eqbs/I6I3SkRqHwESOlhcCla1XJf3R 6not3nin7EaHw3QOC5zCxzC2cfykZm7Xbc0gz5gKQzCCDSJUEfiiwQNAEY4n4ibe9Njbsd2IXSQ aYbCzSm/SRfUT0ZyCkuldCFxNML+Fy6vNMNhNDJaisxwR0Bw0x8wivbK8yGFW9gWi0fAGyoWZEa +NsX6Z2KyJEHa5m1qGNbqTcdu6A6D9UzOZdLyif8iF1i6N++7jWBpkZdLRcuH0Q4BBmnvAQrd3E 1Gc4SXbqI6i+2VOB8+wgRoBnF2qN7K7drDP/c490ETimDmgmm8FaBf64R/7UBQfOJLkN1oFeXAz dpJ9Y6HJ+EBmqFFHbOP7kYiyJi5tUwh4oWg8PdoBYELIj/NEsR5d9OCcDo7rkxHLJj/OQSBafWr bXTuOmtvnRTpzb2DArgHR7SzS6q39NZ1PHeZ9PFTCJC8pKEW8in X-Received: by 2002:a05:6a21:1fc4:b0:3c3:c185:f334 with SMTP id adf61e73a8af0-3c92a95073cmr13139560637.66.1785782808357; Mon, 03 Aug 2026 11:46:48 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:d109:cdba:8a20:74ad]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fab24ec10sm33935472c88.6.2026.08.03.11.46.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 11:46:47 -0700 (PDT) From: Dmitry Torokhov Date: Mon, 03 Aug 2026 11:46:35 -0700 Subject: [PATCH 10/21] HID: stadia: move FF initialization to .input_configured() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260803-hid-ff-input-configured-v1-10-1dc9bbacd88c@gmail.com> References: <20260803-hid-ff-input-configured-v1-0-1dc9bbacd88c@gmail.com> In-Reply-To: <20260803-hid-ff-input-configured-v1-0-1dc9bbacd88c@gmail.com> To: Jiri Kosina , Benjamin Tissoires , Jonathan Corbet , Shuah Khan , Julia Lawall , Nicolas Palix , =?utf-8?q?Filipe_La=C3=ADns?= , Bastien Nocera Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, cocci@inria.fr X-Mailer: b4 0.16-dev-b242f The driver currently initializes force-feedback in its probe() function after calling hid_hw_start() with HID_CONNECT_DEFAULT. This is racy as the input device is already registered and visible to userspace at that point. Move the FF initialization to the .input_configured() callback to ensure the device is fully prepared before registration. Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Dmitry Torokhov --- drivers/hid/hid-google-stadiaff.c | 41 +++++---------------------------------- 1 file changed, 5 insertions(+), 36 deletions(-) diff --git a/drivers/hid/hid-google-stadiaff.c b/drivers/hid/hid-google-stadiaff.c index d6a73d210599..0214aae6b0fa 100644 --- a/drivers/hid/hid-google-stadiaff.c +++ b/drivers/hid/hid-google-stadiaff.c @@ -74,20 +74,15 @@ static void stadia_input_close(struct input_dev *dev) hid_hw_close(hid); } -static int stadiaff_init(struct hid_device *hid) +static int stadia_input_configured(struct hid_device *hid, struct hid_input *hidinput) { struct stadiaff_device *stadiaff; struct hid_report *report; - struct hid_input *hidinput; - struct input_dev *dev; + struct input_dev *dev = hidinput->input; int error; - if (list_empty(&hid->inputs)) { - hid_err(hid, "no inputs found\n"); - return -ENODEV; - } - hidinput = list_entry(hid->inputs.next, struct hid_input, list); - dev = hidinput->input; + if (!list_is_first(&hidinput->list, &hid->inputs)) + return 0; report = hid_validate_values(hid, HID_OUTPUT_REPORT, STADIA_FF_REPORT_ID, 0, 2); @@ -120,32 +115,6 @@ static int stadiaff_init(struct hid_device *hid) return 0; } -static int stadia_probe(struct hid_device *hdev, const struct hid_device_id *id) -{ - int ret; - - ret = hid_parse(hdev); - if (ret) { - hid_err(hdev, "parse failed\n"); - return ret; - } - - ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT & ~HID_CONNECT_FF); - if (ret) { - hid_err(hdev, "hw start failed\n"); - return ret; - } - - ret = stadiaff_init(hdev); - if (ret) { - hid_err(hdev, "force feedback init failed\n"); - hid_hw_stop(hdev); - return ret; - } - - return 0; -} - static const struct hid_device_id stadia_devices[] = { { HID_USB_DEVICE(USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_STADIA) }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_STADIA) }, @@ -156,7 +125,7 @@ MODULE_DEVICE_TABLE(hid, stadia_devices); static struct hid_driver stadia_driver = { .name = "stadia", .id_table = stadia_devices, - .probe = stadia_probe, + .input_configured = stadia_input_configured, }; module_hid_driver(stadia_driver); -- 2.55.0.629.g250fe7f194-goog