From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 265424322E7 for ; Mon, 3 Aug 2026 18:46:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785782818; cv=none; b=bx1Eak/qKoLyYPypzfrEBIRO/zZpaizD/mf44BMcAPAA2M4rTcYrxmB0svB3M5bnoYHe9ziDyMVJ9wVT7v3oUJtnRcajXh1HLLsKcHdgtlo7g4JbZsdjy/DWYTkWnwaGGeF3elCF8T5grPC5TBMLMEVAHNIwd6mbSp/vi+2R3n0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785782818; c=relaxed/simple; bh=65jOuI6e62BcdMsXySY+z4DsuyFq45DZBtqvCjGRPWI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZoMYBtocwQIcRK9uOTP+5mJuokNXith9OxQVVrVjAjtIvpF/aF8T3VaZPM09pvbjDC4KUG95hA4bR1TWKIK0x7WzCT8tDj7WcrmYVAh1GdpvRYL3eKVs6rUOsdqcJQ8zwVZHobG6s2cFbn2WFfMhYrs6Hqo1HUdb8mvnbPAwYRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IIJlvWKi; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IIJlvWKi" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cee9b74ee1so29454655ad.3 for ; Mon, 03 Aug 2026 11:46:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785782813; x=1786387613; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NXKKFDhD/yFBZfYuq7/G58wNu/C7P3oEAv/AO5ZEFrk=; b=IIJlvWKiCj4bOwpeionY4joiDi8A20b6omQAhV61Byj3xw/h8kDbj9JBdzm+TeJIGd q7YoNOTXQ+nl9w9xv1dgBtMF87KXv00g8rCaN+MeO9hwidDD+Dx1wPXUVq+/GB/Wpkx/ GcHkynaqovDbzdiufju3FbGmv0CircAyjICIIJIZ8Su1qdIkMU/B1oQ50qk6+sftI7UW 3Ynejh+uLwtFleLfR2SSd0156m4Ej8xhC/VUFDgq9cuR/RJCyRQzSg0SJzqlEPlI/AGM f0eVv7eGSGZ34Fp67B9IOhCAIzEUrYRERmBeDl+VFi2zdOLofeOmmMsabdXzZyiF6Fh+ Lrkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785782813; x=1786387613; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NXKKFDhD/yFBZfYuq7/G58wNu/C7P3oEAv/AO5ZEFrk=; b=pA7GQPyt4KGf3f4dyYfbOOqkQbo6ijcO+MBijWD78TqMsUuzDEZR2/6mYisbRVmJ0D 8InF3EusaXAtBwF2vOLy7ODUUbNcKlpE3Igum7pVkMok6sIyZFOGk6IysGeU5oDIHEZd IHqLQ1zjeSkxcpCJ/bgfSUSmI4ik6bBjtCkBrhLulvrgooWh3n1OLpiYvbfuSIuezcGm 8/m2sDPvG/rbIvi3V1khDDTwQivbpVkAJ22yeDd88A7shSI+eVHxWFztlks4lCmKeRbC sr2u+Af7YH1nE9DtgH2KWAu3YdP9sQ6R6XkEg603RjdzHoPG5MEfXDcQ0Ym8YYFzOvoP kwQg== X-Forwarded-Encrypted: i=1; AHgh+RrOYnqJb/Rj55WvfRPoO3L3wDXfbHG/4MzG+1iY9IoHynctmGixojPs/Gn9bnhTHDIlnKEihDGNQJA2gOs=@vger.kernel.org X-Gm-Message-State: AOJu0YwWkkxN7DGC0Kbb59A2idApL7w6sZV3P+2r/JkGM6zaK3DvozPK lK671gESyDuLff2nmQrWfSrL0MS8WUml3SmtWF1cAe+x2D28VE/w9tve X-Gm-Gg: AR+sD12Hlc+onCyyQDhFom0reEFXVT24UwYjiMg1xDhbPV3Mo+BM5SJyjnD2XY31jZI tqBP4E/o1/8UMGihpKD88fIRNmLJLWlNhiDpzgA30WtnFToR7eFCJGbFH5TvA/yqU3MM5b1ebIZ iUCUkiyKJDva7q1Y7eLi31v8AdEbjrAY9XzG9EHt9RQGpmqBAeXcfQQ1XiD/JmFQbqypey+s8cV 00jRLToYmPHZVA2dnnVwEgM8cfof+87cpcBwV2QU+m8cl/0GC+6gN5YTZTdL7mH9POyJkRDF8JV XIMeFz6zSvlCqqy53fyOD6Klmfk34nivUze/euOcTIwZaCR9PXyGwhnLWtvLV9bqqufQHSarICY DvIgLqdsTSNt99pfu4SPCKcefCiU+KXEmMDpoufOEJ5GcDyIXk2DWVP1RvUJiD1GcoNigr9TUep QTFvfiwjFUtsv0PHcsRDRZRy15ALu647bGCxjvbU8Mejaijv167Rl172n60m9VNDJKpCHTbpOhm wjgb3XwQcdUUJ9nVKHrEvHWmx0P9moLtDBeE0oL4rNi3JWRDHlg X-Received: by 2002:a17:90b:53c3:b0:36a:5d1f:7b6 with SMTP id 98e67ed59e1d1-38fbc40e148mr10108506a91.2.1785782812925; Mon, 03 Aug 2026 11:46:52 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:d109:cdba:8a20:74ad]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fab24ec10sm33935472c88.6.2026.08.03.11.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 11:46:52 -0700 (PDT) From: Dmitry Torokhov Date: Mon, 03 Aug 2026 11:46:38 -0700 Subject: [PATCH 13/21] HID: microsoft: move FF initialization to .input_configured() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260803-hid-ff-input-configured-v1-13-1dc9bbacd88c@gmail.com> References: <20260803-hid-ff-input-configured-v1-0-1dc9bbacd88c@gmail.com> In-Reply-To: <20260803-hid-ff-input-configured-v1-0-1dc9bbacd88c@gmail.com> To: Jiri Kosina , Benjamin Tissoires , Jonathan Corbet , Shuah Khan , Julia Lawall , Nicolas Palix , =?utf-8?q?Filipe_La=C3=ADns?= , Bastien Nocera Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, cocci@inria.fr X-Mailer: b4 0.16-dev-b242f The driver currently initializes force-feedback in its probe() function after calling hid_hw_start(). This is racy as the input device is already registered and visible to userspace at that point. Move the FF initialization to the .input_configured() callback to ensure the device is fully prepared before registration. Assisted-by: Gemini:gemini-3.1-pro Signed-off-by: Dmitry Torokhov --- drivers/hid/hid-microsoft.c | 38 ++++++++------------------------------ 1 file changed, 8 insertions(+), 30 deletions(-) diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c index 18ac21c0bcb2..a7d3493a6141 100644 --- a/drivers/hid/hid-microsoft.c +++ b/drivers/hid/hid-microsoft.c @@ -323,22 +323,17 @@ static int ms_play_effect(struct input_dev *dev, void *data, return 0; } -static int ms_init_ff(struct hid_device *hdev) +static int ms_input_configured(struct hid_device *hdev, struct hid_input *hidinput) { - struct hid_input *hidinput; - struct input_dev *input_dev; struct ms_data *ms = hid_get_drvdata(hdev); - - if (list_empty(&hdev->inputs)) { - hid_err(hdev, "no inputs found\n"); - return -ENODEV; - } - hidinput = list_entry(hdev->inputs.next, struct hid_input, list); - input_dev = hidinput->input; + struct input_dev *input_dev = hidinput->input; if (!(ms->quirks & MS_QUIRK_FF)) return 0; + if (!list_is_first(&hidinput->list, &hdev->inputs)) + return 0; + ms->hdev = hdev; INIT_WORK(&ms->ff_worker, ms_ff_worker); @@ -352,16 +347,6 @@ static int ms_init_ff(struct hid_device *hdev) return input_ff_create_memless(input_dev, NULL, ms_play_effect); } -static void ms_remove_ff(struct hid_device *hdev) -{ - struct ms_data *ms = hid_get_drvdata(hdev); - - if (!(ms->quirks & MS_QUIRK_FF)) - return; - - cancel_work_sync(&ms->ff_worker); -} - static int ms_probe(struct hid_device *hdev, const struct hid_device_id *id) { unsigned long quirks = id->driver_data; @@ -385,29 +370,21 @@ static int ms_probe(struct hid_device *hdev, const struct hid_device_id *id) ret = hid_parse(hdev); if (ret) { hid_err(hdev, "parse failed\n"); - goto err_free; + return ret; } ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT | ((quirks & MS_HIDINPUT) ? HID_CONNECT_HIDINPUT_FORCE : 0)); if (ret) { hid_err(hdev, "hw start failed\n"); - goto err_free; + return ret; } - ret = ms_init_ff(hdev); - if (ret) - hid_err(hdev, "could not initialize ff, continuing anyway"); - return 0; -err_free: - return ret; } - static void ms_remove(struct hid_device *hdev) { hid_hw_stop(hdev); - ms_remove_ff(hdev); } static const struct hid_device_id ms_devices[] = { @@ -469,6 +446,7 @@ static struct hid_driver ms_driver = { .report_fixup = ms_report_fixup, .input_mapping = ms_input_mapping, .input_mapped = ms_input_mapped, + .input_configured = ms_input_configured, .event = ms_event, .probe = ms_probe, .remove = ms_remove, -- 2.55.0.629.g250fe7f194-goog