From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E058429CCE for ; Mon, 3 Aug 2026 17:32:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785778352; cv=none; b=rcuoBwHp1DVsqT0fQD7mRJhwHxGY1eaTJiJ5o884soRgxJ68V72bSUk0i5LAiyPGP9NnTqDStDOE2Quz7ER6CcubLqCWKXVXX3kK99jgXQ++uE40N1aUJgUZ6psf8YLnzE0tp2Pt+9LPGLDpwkwCLsgEAT5FullJsICDdSiTKOQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785778352; c=relaxed/simple; bh=krxY0lu1oFLcj0ILTcjLHRmz1mRM3E8GryNvXf+BdVc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RRcTl9ea69LVmlSOwqwxylddUxU0ZL9/dM1oVxeKBqoxWHyuHdZ2bom8hV0lcZ/I7DzYdPELfhWCsleeQb+sSG68E/q6c+ZodVOeVQRkjyFxQNnIX8u1Bd2v9iX+jIKNxP982zQaKuaFOBnv183FzUCLWOHa12Ef2yqjStp3HV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cTPz8pID; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cTPz8pID" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4954aff6088so20705955e9.3 for ; Mon, 03 Aug 2026 10:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785778349; x=1786383149; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EwJsI1vUB3E2f0JzSuTW59bUIwuJOClS3FjW5yqPnhU=; b=cTPz8pIDcEdgKHb95RWHcXVNx2uWBgwMHfDaOxz6buo52mKlgzy4QqZ1ux76xUGAMz Bwj6eL/7W1l+njVRl46MWIUmdeFYpHjgpi33o+se/c6CikU0MA6HmDnocboIWYa12G05 qU5MmfmA1wPfeiMFPB4UuckGzHY/HkhR/Qv/zbgmkymPaxe4t3vd9Og/XR2/TVpFBet0 KPOeHIcj5XXi7etD7LRJcO1Wb52liChIgy6CZgoe90wOjryZ6FrRMK4wTif2JRK9WXV4 5/gzhnJN/Q+9NS5R4/bTO/kvUoeI0rUr9j+pv98JfhLQxMcxbsnw+HwsQkfFQYlX2v8p C+cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785778349; x=1786383149; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EwJsI1vUB3E2f0JzSuTW59bUIwuJOClS3FjW5yqPnhU=; b=YM1FgMOu5WVVqUYgBa9cso1fuMaohxaCZFswax6d+80zvZcGn8JVQS1UhbLvjcdqg7 IXz3IpHkbuUFx+RUyJd7U94JkHhcZLiCSJrgEumQ0vHSbDoip9BEmhAdWYwbjCyWB2a+ m9P3DjuaKL/BDRx77ZgTKu7aVcy3mqqkOcIxNjKXqvQ4mikOYi/TSVhlQB8w//hdburE BRT1fU9OCSxAUkck/XM4SZzovWmTYxZUxXheUB5ZKsCLdYWd4fTlWhoyUp2mPWgNeI+w 63Obu2Gt/PdageivR5pCDm/cbe0Cix28JwYbcxzzUExhStY6jpbEiOWjpjSOpee5Sv7U sMwA== X-Forwarded-Encrypted: i=1; AHgh+RrIWsEOyYSJ1C3KuDYY3iWHmY9jYlQPKscL2Ltz268I+ErOISjqEXX41ANhGru88N56Otucx8betbx/KXQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxbAyuAOZ950boQIuot1FOpKSzINiEy44+ahd66NB6iclaLxqnb gi/SeMvD0pT5a7ab+jfDYpYYIqL4HJ4xdkxpWAsGlcChjcHqLH/Rp6Ii X-Gm-Gg: AR+sD13WtkG9ST1c5TaXNbTGxUBT7SqSz0mnRJO81YjpMEna59Tzd7fydG4mLK/6CrE hR3Gc8Y1XOpiiJf2X7JL2e5p1RsKEpXw6sEeu0ulcNsHLZPzYRXxxTydtD7DsUWJ9jqChnO64oa 1gDVAWKrbccHnXqf+A4IqssRqmgdVxXSCvfdQSbUMQMz222TeFzE97RDwje8t3A8/zTxWTW9WZk PzWUJxG4rSJvHDRwHKHL841llsA6p7DfGOE6rkyYgWWs9zLWoR01G2X7CVL+jPAm7Z9SrKgl6hv 3wuJQLTM4WVYjwValwKRADKfTSJZgg8X+8oTgdsmrjxe9njBkVk7hlp7hOcvFClOC4r2Jr1v5VX TX3YhR0Jkak8jXOboilw3NPUpEqQn27CLRQlJRRKXMXmUdOKuqyaz4Q1vAnCcBYiQr21YKW8rbY jSamWJrBsMbP61A7jITfPorbd9Vy9+h4FNdsfEY3E7rOTl2Yoca3tY3FMqCmz7wAzX+3P2o0j41 carfSOYAr8hSJPmqO2n52dRRob6UUtpZKPE/JfktXz6+J4a1MVICIZbTVHqm1A7gRqz80WD4Y7A 7vHJV8hc9c2oHoBstl2gFc72cDql4jYDWV4raRIx+ySXc3l5FYGWrz+f9L7x7XrHq9JIY6ornts 5AO4HBDm/WbpRM+pYwls0w9qXoB2dqQRW/4fNVQ== X-Received: by 2002:a05:600c:840f:b0:495:4b24:1b64 with SMTP id 5b1f17b1804b1-4980c601d19mr230022635e9.0.1785778348683; Mon, 03 Aug 2026 10:32:28 -0700 (PDT) Received: from [192.168.1.187] ([2a02:8308:4092:11f0::f9f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49808199a68sm176259975e9.4.2026.08.03.10.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 10:32:28 -0700 (PDT) From: Joshua Crofts Date: Mon, 03 Aug 2026 19:32:26 +0200 Subject: [PATCH v3 2/2] iio: dac: mcp47a1: add support for new device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260803-mcp47a1-add-support-v3-2-540e71b4fd2e@gmail.com> References: <20260803-mcp47a1-add-support-v3-0-540e71b4fd2e@gmail.com> In-Reply-To: <20260803-mcp47a1-add-support-v3-0-540e71b4fd2e@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785778346; l=6466; i=joshua.crofts1@gmail.com; s=20260530; h=from:subject:message-id; bh=krxY0lu1oFLcj0ILTcjLHRmz1mRM3E8GryNvXf+BdVc=; b=vDcJNkdVI+bS9hrsfRn1RgDsgMN/O0hw/0Rl0c/N2XEJeB0Y9CqnhdgmM3cdWVbY0fLCCEsE/ Edz/PjDKHFhBuxytaUZyeVchlcI+ZF7dFjGgvO5+d/5u5uofRhXL0SD X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=RTDOoVwgeL4oFdASj9U+cxJuIjXuXk73zkjnGOJKbEo= The Microchip MCP47A1 is a 6-bit volatile Digital-to-Analog converter which communicates via I2C. Signed-off-by: Joshua Crofts --- MAINTAINERS | 1 + drivers/iio/dac/Kconfig | 10 +++ drivers/iio/dac/Makefile | 1 + drivers/iio/dac/mcp47a1.c | 166 ++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 178 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8c8118eb4141..fc76a2159e1f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17703,6 +17703,7 @@ MICROCHIP MCP47A1 DAC DRIVER M: Joshua Crofts S: Maintained F: Documentation/devicetree/bindings/iio/dac/microchip,mcp47a1.yaml +F: drivers/iio/dac/mcp47a1.c MICROCHIP MCP9982 TEMPERATURE DRIVER M: Victor Duicu diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig index 18a27785e28b..04c90d98f86f 100644 --- a/drivers/iio/dac/Kconfig +++ b/drivers/iio/dac/Kconfig @@ -582,6 +582,16 @@ config MCP4728 To compile this driver as a module, choose M here: the module will be called mcp4728. +config MCP47A1 + tristate "MCP47A1 DAC driver" + depends on I2C + help + Say Y here if you want to build a driver for the Microchip + MCP47A1 digital-to-analog converter with an I2C interface. + + To compile this driver as a module, choose M here: the module + will be called mcp47a1. + config MCP47FEB02 tristate "MCP47F(E/V)B01/02/04/08/11/12/14/18/21/22/24/28 DAC driver" depends on I2C diff --git a/drivers/iio/dac/Makefile b/drivers/iio/dac/Makefile index 5d20d37e44ce..992f8930f95c 100644 --- a/drivers/iio/dac/Makefile +++ b/drivers/iio/dac/Makefile @@ -55,6 +55,7 @@ obj-$(CONFIG_MAX5821) += max5821.o obj-$(CONFIG_MCF54415_DAC) += mcf54415_dac.o obj-$(CONFIG_MCP4725) += mcp4725.o obj-$(CONFIG_MCP4728) += mcp4728.o +obj-$(CONFIG_MCP47A1) += mcp47a1.o obj-$(CONFIG_MCP47FEB02) += mcp47feb02.o obj-$(CONFIG_MCP4821) += mcp4821.o obj-$(CONFIG_MCP4922) += mcp4922.o diff --git a/drivers/iio/dac/mcp47a1.c b/drivers/iio/dac/mcp47a1.c new file mode 100644 index 000000000000..0bf994aa0e4f --- /dev/null +++ b/drivers/iio/dac/mcp47a1.c @@ -0,0 +1,166 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Microchip MCP47A1 DAC driver + * + * Copyright (c) 2026 Joshua Crofts + * + * Datasheet: https://ww1.microchip.com/downloads/aemDocuments/documents/OTH/ProductDocuments/DataSheets/25154A.pdf + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#define MCP47A1_CMD_CODE 0x00 +#define MCP47A1_MAX_STEPS 64 + +struct mcp47a1_data { + struct i2c_client *client; + int vref_mV; +}; + +static const int mcp47a1_raw_avail[] = { 0, 1, MCP47A1_MAX_STEPS - 1 }; + +static const struct iio_chan_spec mcp47a1_channel = { + .type = IIO_VOLTAGE, + .indexed = 1, + .output = 1, + .channel = 0, + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), + .info_mask_separate_available = BIT(IIO_CHAN_INFO_RAW), + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), +}; + +static int mcp47a1_write(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int val, int val2, long mask) +{ + struct mcp47a1_data *data = iio_priv(indio_dev); + + switch (mask) { + case IIO_CHAN_INFO_RAW: + if (!in_range(val, 0, MCP47A1_MAX_STEPS)) + return -EINVAL; + + return i2c_smbus_write_byte_data(data->client, MCP47A1_CMD_CODE, + val); + default: + return -EINVAL; + } +} + +static int mcp47a1_read(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int *val, int *val2, long mask) +{ + struct mcp47a1_data *data = iio_priv(indio_dev); + int ret; + + switch (mask) { + case IIO_CHAN_INFO_RAW: + ret = i2c_smbus_read_byte_data(data->client, MCP47A1_CMD_CODE); + if (ret < 0) + return ret; + + *val = ret; + + return IIO_VAL_INT; + case IIO_CHAN_INFO_SCALE: + *val = data->vref_mV; + *val2 = MCP47A1_MAX_STEPS; + + return IIO_VAL_FRACTIONAL; + default: + return -EINVAL; + } +} + +static int mcp47a1_read_avail(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + const int **vals, int *type, int *length, + long mask) +{ + switch (mask) { + case IIO_CHAN_INFO_RAW: + *vals = mcp47a1_raw_avail; + *type = IIO_VAL_INT; + return IIO_AVAIL_RANGE; + default: + return -EINVAL; + } +} + +static const struct iio_info mcp47a1_info = { + .write_raw = mcp47a1_write, + .read_raw = mcp47a1_read, + .read_avail = mcp47a1_read_avail, +}; + +static int mcp47a1_probe(struct i2c_client *client) +{ + struct device *dev = &client->dev; + struct mcp47a1_data *data; + struct iio_dev *indio_dev; + int ret; + + indio_dev = devm_iio_device_alloc(dev, sizeof(*data)); + if (!indio_dev) + return -ENOMEM; + + data = iio_priv(indio_dev); + data->client = client; + + ret = devm_regulator_get_enable(dev, "vdd"); + if (ret) + return dev_err_probe(dev, ret, "Failed to enable regulator\n"); + + /* Delay after device exits reset state (see AC/DC characteristics) */ + fsleep(20); + + ret = devm_regulator_get_enable_read_voltage(dev, "vref"); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to read vref\n"); + + data->vref_mV = ret / (MICRO / MILLI); + + indio_dev->name = "mcp47a1"; + indio_dev->modes = INDIO_DIRECT_MODE; + indio_dev->info = &mcp47a1_info; + indio_dev->channels = &mcp47a1_channel; + indio_dev->num_channels = 1; + + return devm_iio_device_register(dev, indio_dev); +} + +static const struct of_device_id mcp47a1_of_match[] = { + { .compatible = "microchip,mcp47a1" }, + { } +}; +MODULE_DEVICE_TABLE(of, mcp47a1_of_match); + +static const struct i2c_device_id mcp47a1_id[] = { + { .name = "mcp47a1" }, + { } +}; +MODULE_DEVICE_TABLE(i2c, mcp47a1_id); + +static struct i2c_driver mcp47a1_driver = { + .driver = { + .name = "mcp47a1", + .of_match_table = mcp47a1_of_match, + }, + .probe = mcp47a1_probe, + .id_table = mcp47a1_id, +}; +module_i2c_driver(mcp47a1_driver); + +MODULE_AUTHOR("Joshua Crofts "); +MODULE_DESCRIPTION("Microchip MCP47A1 DAC Driver"); +MODULE_LICENSE("GPL"); -- 2.55.0