From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70D1739A4BA; Mon, 3 Aug 2026 06:34:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785738863; cv=none; b=IEgdPXxOJ/SZeeNdGHxgUdSTjeZR3pGoSOSH+gbki0pkdrrQLXtYo7vr9BIRYi1Y5SY6s6qzU+wZFtWFWRPu486LPQaHXAVT/obhhNMsqxKusSO4fi//RnyU/DIHBRNjDMAPEwFA0fheTcOq0vmpAhJYyncJkGBg7F0REr+oekM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785738863; c=relaxed/simple; bh=DReL7/6vWhSTl0AJM01PqOXaRlEt5iFPZqOKbvYOgE4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nHCsZNCV0ld9VR0L5X16Mb6Kurm7wCZx9SNvCgFhVy17MW/RMdEhnuq9n56JYYOOdHct/+A7RFm+jQBI0L6moc0C1QVgECfMHf9O7NqVqk62rWaadE1+sq+XwqJzAE+wnb1kDPTK26BoMQUOTxGl6WlsHd9QJpkMCijvZXf6Bro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qIow42sc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qIow42sc" Received: by smtp.kernel.org (Postfix) with ESMTPS id 16094C2BCF7; Mon, 3 Aug 2026 06:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1785738863; bh=DReL7/6vWhSTl0AJM01PqOXaRlEt5iFPZqOKbvYOgE4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=qIow42scglKRtuXnJa10Z0yQhiyQUXnnVDmzX6HzRP3LgSmBGJRUxahqgHy/pLk5J WB1yZBBjXqCPiSpLXsi9Vc4P255I3BMDC8jFZ3qyX/SIWFduL1HcZIcbMpKndv1Yf7 oC3agYAzI43cJPo6alsp5yX6QWSmZVUkmFAKLZqrWZljnTMmN57VJaKF/b0Cr0z3r2 Xzv1bvvkjSCZLwUjfZdy3F3u+m3jo+XQVFPowkFyJ3eZwVi9ABmlTf+PnDDPBek/bM CdfV0JuxAB3A1CfHpn3MwaWGqzV5cNFaXz2Gtiewf7iXpTCDGZiUTN5sG4Ocl14wL8 uSnZlNLvzpliQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1EEEC55162; Mon, 3 Aug 2026 06:34:22 +0000 (UTC) From: Manivannan Sadhasivam via B4 Relay Date: Mon, 03 Aug 2026 08:33:59 +0200 Subject: [PATCH 01/28] dt-bindings: phy: qcom: Describe QMP USB and UFS PHY vdda-phy/vdda-pll voltages Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260803-phy-supply-fix-v1-1-5880630cde3e@oss.qualcomm.com> References: <20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com> In-Reply-To: <20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Manivannan Sadhasivam , Manivannan Sadhasivam X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5004; i=manivannan.sadhasivam@oss.qualcomm.com; h=from:subject:message-id; bh=V97d3d49T3Ee08UA2ANGKnoJaHfjqiGr+dmZjl7gLmg=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBqcDZhEYjetD5xsCIhq6BRmQLvzv4sSqmowK7vh L1GGmGwBhCJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCanA2YQAKCRBVnxHm/pHO 9QiECACV+yoFC7pE5pmYnGXoGG7FFf9w4afdXw7XUlEjXsJlvsfkwHzdyyrMytZj7U2cCWhqTJI gPYq9t+EN48ves/mp58BYPfis9YV9ewCvicSAYkgGASORq1C63QyBjql+4bH9bB9oiydkNsVBty w0v2oSwEGSwUIgg80+0cvFV4F+trc9Z9CetFrLOI0Z52/uZ9hR80JlMotmfG2YAGKuxk3pIGZt8 3ZSikojHUuZNiwMP64HPlgUrpFew4nK6plmV6oOGVyotb1orDafCrpnRZn5PUtkYMPAYDbbk3iX JzLKfmKX1GbGAZJjgAgO0mWFGV9fN1CbZsSLqUq78qr1Xvob X-Developer-Key: i=manivannan.sadhasivam@oss.qualcomm.com; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-Endpoint-Received: by B4 Relay for manivannan.sadhasivam@oss.qualcomm.com/default with auth_id=461 X-Original-From: Manivannan Sadhasivam Reply-To: manivannan.sadhasivam@oss.qualcomm.com From: Manivannan Sadhasivam The vdda-phy and vdda-pll supplies of the QMP USB and UFS PHYs are frequently swapped in devicetrees, as the naming does not make clear which supply expects which voltage. Document that vdda-phy is around 0.8V and vdda-pll is around 1.2V, with the exact voltage varying per SoC, so that the correct supplies can be assigned. Reported-by: Konrad Dybcio Assisted-by: Claude:opus-4-8 Signed-off-by: Manivannan Sadhasivam --- .../devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml | 10 ++++++++-- .../devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml | 10 ++++++++-- .../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 12 +++++++++--- .../bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 12 +++++++++--- .../bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 10 ++++++++-- 5 files changed, 42 insertions(+), 12 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml index 1636285fbe53..4cbcf54aef2c 100644 --- a/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml @@ -39,9 +39,15 @@ properties: - const: phy - const: phy_phy - vdda-phy-supply: true + vdda-phy-supply: + description: + Supply for the PHY, typically around 0.8V, though the exact voltage + varies per SoC. - vdda-pll-supply: true + vdda-pll-supply: + description: + Supply for the PLL, typically around 1.2V, though the exact voltage + varies per SoC. "#clock-cells": const: 0 diff --git a/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml index efb465c71c1b..9dbe49afaa6c 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml @@ -40,9 +40,15 @@ properties: - const: phy_phy - const: dp_phy - vdda-phy-supply: true + vdda-phy-supply: + description: + Supply for the PHY, typically around 0.8V, though the exact voltage + varies per SoC. - vdda-pll-supply: true + vdda-pll-supply: + description: + Supply for the PLL, typically around 1.2V, though the exact voltage + varies per SoC. "#clock-cells": const: 1 diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml index b2c5c9a375a3..968a700d2a55 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml @@ -81,9 +81,15 @@ properties: items: - const: ufsphy - vdda-phy-supply: true - - vdda-pll-supply: true + vdda-phy-supply: + description: + Supply for the PHY, typically around 0.8V, though the exact voltage + varies per SoC. + + vdda-pll-supply: + description: + Supply for the PLL, typically around 1.2V, though the exact voltage + varies per SoC. "#clock-cells": const: 1 diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml index 01342823e57f..532afa116ba0 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml @@ -64,9 +64,15 @@ properties: - const: phy - const: phy_phy - vdda-phy-supply: true - - vdda-pll-supply: true + vdda-phy-supply: + description: + Supply for the PHY, typically around 0.8V, though the exact voltage + varies per SoC. + + vdda-pll-supply: + description: + Supply for the PLL, typically around 1.2V, though the exact voltage + varies per SoC. refgen-supply: true diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml index 4eff92343ce4..865395fe1416 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml @@ -69,9 +69,15 @@ properties: - const: phy - const: common - vdda-phy-supply: true + vdda-phy-supply: + description: + Supply for the PHY, typically around 0.8V, though the exact voltage + varies per SoC. - vdda-pll-supply: true + vdda-pll-supply: + description: + Supply for the PLL, typically around 1.2V, though the exact voltage + varies per SoC. refgen-supply: true -- 2.43.0