From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5D59404BE8 for ; Mon, 3 Aug 2026 12:43:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785761011; cv=none; b=g4w4NEFe3UFWTxGZKouM/GvoPv4dvw6k/iNBeKOiXD0D9DZUNGLp8KhtWNyiQy/Hk8q553aNvndUZhGhaSzRPZqJSauuf7LHrZPp8gSIi5ivqYR5nzibxdZ7b1IoTB001bC7X8Iu8/1t9tPwtgaHNtN8KmN5Y0igzBLC7aoBA70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785761011; c=relaxed/simple; bh=tnQVRiKHBbJMgYskau3aHnN0bLEXgSPq8Kdh08EQFXE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=mvG0i6xR7s90T/L0Mglqikc9qmQTLhzr7usfHDPiLHPYAFtvGjSo5PO8Hg2YZN2q/bMV/yJkNsxWyQEEAGBxruYERtIoXY+KLiuOrsNJp2T7x9zO/BHdn1+HB2PyNV7E25G2dcCzl6rwMqn/EuLdiGDj9BLTjfPEmFf9MHRUpxQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Xs7zmOqM; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xs7zmOqM" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2cf27856f9cso32870015ad.2 for ; Mon, 03 Aug 2026 05:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785761010; x=1786365810; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Cw8Ms9Kan2k7tw2PC7Z5aIyl6oywbNO7qN+ujFMHGmY=; b=Xs7zmOqMf7jXmqO0SSSe03V3KihWfaiDuqIN4eefQYd0PsDmNr7QilsRW0RhdQCCJK H+EXpSXU8RB9GOTQfyKybi33RPgNbnW1F0dIu8RgYrqEvcMtL/t7nGssiwMk/cmdskmB PNx98WWvjq+YxhWxz3QfuonP8o1pkupoHQi4PDrLfc3J181Qct9Su5fw6qGzfQo7IxWy X7ZF9X3D1gkssC+0CKPrzImBmKMdm2zy68gaU/3YWO8Vz+mPd9dnX6sDEaAwd6QOThih APddUwYIoxsyPbmGnD/AB/nOYPEMuzFmekIi7CZ29zJs/fvL+jo/11WF1YgjQ1+H2Pgt h78A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785761010; x=1786365810; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Cw8Ms9Kan2k7tw2PC7Z5aIyl6oywbNO7qN+ujFMHGmY=; b=lK0Bg0LK7eFA3tK/aSn3U1pbq6eg7hMNsDL84K95iu/5ptND88swZ899+sVtI8rbhd zPPmWFXhOBPfpUc/vRZCRkosMrPqKS1D6N6xFyyrulXtPDUzt5J9c3eZmyiUTFd1pOhG ZokjsbbjRRjfGr5fvllmmDV0fejxpYiHZ/yp6+SPY5IoxkXath+mP+ltckYoUKCyyADs 1bgRb/FnOHR8Hkh85n+4A5qztGL+iSvbiv+NP/4uEzASlWodT7KD/4PeuS62HKCIe2Z3 NQDTnFdmBYxFE/4lzRo6NqcgDCURSP457S/65reIShaNZLGPFdhnMtKTtpo4RYkjLJSa GRRw== X-Forwarded-Encrypted: i=1; AHgh+RqR6tmKbyqft3KLDGgwTtAPGO3U8KBZq1QFFEj+rIw/oUntL9kMjTjtPDZRkdA0r5+sA836aHgcCXl7Lyo=@vger.kernel.org X-Gm-Message-State: AOJu0YzuqhxWsa5iFl+Af07B+/UjfFBqWWE+z1okec25ip62qv2qOGxt 9rrWCr8PjCbwMNWG0UKJ2EPma5lbJ12nf5hRTzZSrKoeeFeezqQlfqO3NB75Yg== X-Gm-Gg: AR+sD10OrLZTo+zX+5QgqAXb57/TsobuTkfrhkQIDxYrL3a7ylZvNuu3N0JiL+P3Svf 7owhSZKi8XUvceu/h75JInHUADq63DHxrRT3c/PMdOiGIP0yX4cwZx5QENjRLQrdBFxurL7W3XO w8FNB9R2wL732J/Kg5OuzsodhkX5ckTOhf6bBqyAxc/tyXiz1CQxv4qRLBW9WW5ZGjUWlc2oFlG jXXERx6U09lHqxKYG4o1F6v/qZBqJt3bFnJzQvkDIlDIuI3JpKpd8GBOSzt/c+Z2WC95Bd2P8Vu JcRI8tzAZpB9X7uA1KjGAUJosh4ckOU+LgEmINTmxHdLrNVgRY1c4oaKAxuXyjFvyAJmzSs9lsh aHygaWkT6uCbqRf325neRPar28NoePwNYBiaQPEqpnAEKAF9lcwafD2vBVDhW7mYJh9IO7LOWV3 s6sMKGgTfQcNwAICCblCs0SXFZK6W/gbMa9y+qzp/e/uq6M/v0193JLwPCcmgA73B6wxIUMPsZh FaWtR2fq7vW3Sv+bgz8pBoUDMamu3Sbwl84Lw== X-Received: by 2002:a17:903:2c0e:b0:2c9:97a7:71b1 with SMTP id d9443c01a7336-2d0524c91c7mr101881205ad.44.1785761009849; Mon, 03 Aug 2026 05:43:29 -0700 (PDT) Received: from [127.0.0.1] ([103.17.98.26]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d04b1216bdsm37869825ad.69.2026.08.03.05.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 05:43:29 -0700 (PDT) From: Felix Gu Date: Mon, 03 Aug 2026 20:43:24 +0800 Subject: [PATCH] phy: renesas: rcar-gen2: Fix double of_node_put on phy creation failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260803-rcar-gen2-v1-1-9aa35c36d7d7@gmail.com> X-B4-Tracking: v=1; b=H4sIAOuMcGoC/yXMQQ5AMBBA0avIrDWZViPiKmJBDcaiZIpIGndXL F/y8yMEEqYAdRZB6OTAq0/QeQZu7vxEiodkMGhKrLBQ4jpRE3mjtMURtXVDUVlI/SY08vW9mvZ 3OPqF3P4O4L4f0rGeA20AAAA= X-Change-ID: 20260803-rcar-gen2-140f014cd384 To: Vinod Koul , Neil Armstrong , Geert Uytterhoeven , Magnus Damm , Krzysztof Kozlowski Cc: linux-phy@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785761006; l=1122; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=tnQVRiKHBbJMgYskau3aHnN0bLEXgSPq8Kdh08EQFXE=; b=Dtvb2UdTIMEbYUuPteA4CV5qm9tyMojbVJ/54PyUJ4b/tVVtCnK2SbzUZ+Xhxjf3yqchmGzzh 2faWgB4i0y8BvFMYCg7LLc4GQu5haDAbQNbKUybtRElA2DHrSYzAp/c X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= for_each_child_of_node_scoped() releases the node reference on scope exit, so the explicit of_node_put(np) in the devm_phy_create() error path drops it twice. Drop the redundant of_node_put() and let the scoped cleanup handle it. Fixes: b64b32791fb5 ("phy: renesas: rcar-gen2: Simplify with scoped for each OF child loop") Signed-off-by: Felix Gu --- drivers/phy/renesas/phy-rcar-gen2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/renesas/phy-rcar-gen2.c b/drivers/phy/renesas/phy-rcar-gen2.c index 6c671254c625..5a272e25e051 100644 --- a/drivers/phy/renesas/phy-rcar-gen2.c +++ b/drivers/phy/renesas/phy-rcar-gen2.c @@ -405,7 +405,6 @@ static int rcar_gen2_phy_probe(struct platform_device *pdev) data->gen2_phy_ops); if (IS_ERR(phy->phy)) { dev_err(dev, "Failed to create PHY\n"); - of_node_put(np); return PTR_ERR(phy->phy); } phy_set_drvdata(phy->phy, phy); --- base-commit: 415606a7be939835db9b0d6b711887586646346d change-id: 20260803-rcar-gen2-140f014cd384 Best regards, -- Felix Gu