From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D30992A1CF for ; Mon, 3 Aug 2026 00:49:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785718185; cv=none; b=LKnJEibthAonxJ/AHRoDw24dYK2Q4Y1BHwx1pIOwmll/XvxvsNGtu5kTzSjItwUpgN6ARYqAQO5S3oyuxKzKNiyw5/vtqgj/UrmhrFZLpp6J3l9ZET/UCaN6b1V3hKuS02oMkgEDbQsCafTYp8QoIgZeEnGy1ZYmHKC8Y5hRAwU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785718185; c=relaxed/simple; bh=RmdWQ40WACLEfQuBEwRKYHDY2nwKyeglBCr2/+Semv4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aH25Si0VpMpzXd3TCm1sktFxGvXikrTY3QAG4L+25L6WGH3rAetqUBEDd7AD0jw/45L7ONuObzZb5UPZR9E9VyqlOPcQYhHUlcPmNkUMUYxaAgx5YmKmd7c5MB37nCFV2eBVds9jyEbFG97Z+qnwYwzysfwF9YcNXIFOnoEInuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GMntx1gu; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GMntx1gu" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2cfbbdfa60bso21369435ad.3 for ; Sun, 02 Aug 2026 17:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785718183; x=1786322983; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=cuNxYG+m1i3A6tq4bgitFIgN68FwLjQXK2bjDLK0VxI=; b=GMntx1gu0oOs4Y7XSshPNfMfBM0wCcLqPSQN0fXjv5u6L/EAvgZqa9GBRd1BgUFJZu dZ6j2ymklWaDaOXJcPm+8aLD5KZ6fyn+beC0GToohT/G3p7OYJKvt9R+fWphEw/QTTWL gCYE4aJnmAHKGa08w60Zs0EXBarCrlFrGcmgbz1RGvcqdbcGD6SkwE2HqO5YCBzYbPH0 FuPp+rS+lFsE0pA+dVHMiVR9QgUdjqDm4wSbOivdOmKfOEreHNyTWVjImSu50ayThmtt AK18y6+jkc23wRRLc5nU89VhcOqr90DXJIrvB2jVVqtzggltfXD6KnhJCTUOlN4yVHd/ qd9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785718183; x=1786322983; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cuNxYG+m1i3A6tq4bgitFIgN68FwLjQXK2bjDLK0VxI=; b=ch1SpPUMe+o/k5o5HbL0c/DW+pPIpEMC3gBa7jng6FKVK/A3R1S4rofFJJnn5awO5z lcZYqgFBbwp4FZ8QyeVbcFyMrFG51dJsKvcewPOQcYotgEkkhcn75IIm0l1LNPn9y/Io qUq2ZDZCehxiaExoCNUuviaOFtbtDRWNZ4AsdNHU3y49VngxLU7v3awxKEpCSwtZ4Unm rrPS6+Ek8WlYK6GbT9xITfwL4Yk4WAqEgvyBXIB4v0D8bKRoKrBQRaH+Lvkw2brnnkG3 Xduq/xQWgwu/cq9KR/W/WuIOPR/qFzpnQS4mxx5nLNojQiTeJEzAeQMrc/mkOjyb423L eIBA== X-Forwarded-Encrypted: i=1; AHgh+RqAyOukWnROBwKm6t1y3tXx7h010L68qLXp8w+vdObF4+Js9h4xWj7LMjo6LI/aHhl+JTaik7I+hIXfcic=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0I7SVeY02rFkDVyaq6TSUAhdBhgKiOnyiP0nn1GrQCGOkk7x4 yoRHrhPPynPqN6i6W/+MhyvS3iao0T5Vqpi6SemfGRG1eGOK2hztoxydP0nUattW3pA= X-Gm-Gg: AR+sD13rc/dqU5WYQ0kvfZH/ppBiOGwTnJr50jDLBC7YnpQIEei4dStcW46gkr1+EQ3 NDpFGyUB4hadUDL52fLeoDVEWwCStBtSSAn0FL9ui376CiRM0xzxd2mEOb/7OBleaSZH1sdVx+f PKNM4uvwSYJR8IaOiDGSn2/1TxWcbRBz+hTIsVrG3CHJ4kx2GxtCPUiXY9JwJdqvPbpZ+diZUII QEzHUFiowe3r9gN4WDgzPzDk5idrj0MTC/iCnhIHUhTp26D6IrIfP30KeecfVTt2totf0U2c/aE 2WD9BIdjq0FoQNL8jsSgMx1YxsnH578zzLzHXNEIrKPab4noAPHm3rHsYyM6+iSEi2dgIy/ZIHx og4uVqvfIvhripUTTsDCAen6bLx2MD/aN5rLlETRnT45e2Pomar4JGw9s/B2HHjlNJl7t11PAEh +KFuyaCyuj5eWwTnJ5kAXZ+DRAtN1VIu0wZUwkxk5ne5FOk8C0nDSk1aCFHxfbRL3wstOWJ4oCG jaohEn11SJaMYyizMUiosXmGfYqU90yNKvTHfGgIco= X-Received: by 2002:a17:903:185:b0:2cf:bf1e:36f2 with SMTP id d9443c01a7336-2d0522983cbmr84444925ad.25.1785718183097; Sun, 02 Aug 2026 17:49:43 -0700 (PDT) Received: from lucas-inspiron153525.. (host110.181-12-179.telecom.net.ar. [181.12.179.110]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e044912sm35807345eec.15.2026.08.02.17.49.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 17:49:42 -0700 (PDT) From: Lucas Jeffrey To: gregkh@linuxfoundation.org Cc: johannes.berg@intel.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Lucas Jeffrey Subject: [PATCH] staging: rtl8723bs: handle key setup failures Date: Sun, 2 Aug 2026 21:49:19 -0300 Message-ID: <20260803004919.901586-1-luquijeffrey@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The return values from key setup helpers were ignored in rtw_cfg80211_ap_set_encryption(). Propagate failures from rtw_ap_set_wep_key(), rtw_ap_set_group_key(), and rtw_ap_set_pairwise_key() back to cfg80211 instead of continuing after an unsuccessful key setup. This avoids silently reporting success when the key setup command could not be queued or helper functions fail to allocate memory. Signed-off-by: Lucas Jeffrey --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index 967cd1b34aed..8e5aa036d5eb 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -563,7 +563,9 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, struct ieee_pa psecuritypriv->dot11DefKeylen[wep_key_idx] = wep_key_len; - rtw_ap_set_wep_key(padapter, param->u.crypt.key, wep_key_len, wep_key_idx, 1); + if (rtw_ap_set_wep_key(padapter, param->u.crypt.key, wep_key_len, wep_key_idx, 1) == _FAIL) + ret = -EIO; + goto exit; } @@ -604,7 +606,10 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, struct ieee_pa psecuritypriv->dot11PrivacyAlgrthm = psecuritypriv->dot118021XGrpPrivacy;/* */ - rtw_ap_set_group_key(padapter, param->u.crypt.key, psecuritypriv->dot118021XGrpPrivacy, param->u.crypt.idx); + if (rtw_ap_set_group_key(padapter, param->u.crypt.key, psecuritypriv->dot118021XGrpPrivacy, param->u.crypt.idx) == _FAIL) { + ret = -EIO; + goto exit; + } pbcmc_sta = rtw_get_bcmc_stainfo(padapter); if (pbcmc_sta) { @@ -640,7 +645,10 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, struct ieee_pa psta->dot118021XPrivacy = _NO_PRIVACY_; } - rtw_ap_set_pairwise_key(padapter, psta); + if (rtw_ap_set_pairwise_key(padapter, psta) == _FAIL) { + ret = -EIO; + goto exit; + } psta->ieee8021x_blocked = false; @@ -678,7 +686,10 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, struct ieee_pa psecuritypriv->dot11PrivacyAlgrthm = psecuritypriv->dot118021XGrpPrivacy;/* */ - rtw_ap_set_group_key(padapter, param->u.crypt.key, psecuritypriv->dot118021XGrpPrivacy, param->u.crypt.idx); + if (rtw_ap_set_group_key(padapter, param->u.crypt.key, psecuritypriv->dot118021XGrpPrivacy, param->u.crypt.idx) == _FAIL) { + ret = -EIO; + goto exit; + } pbcmc_sta = rtw_get_bcmc_stainfo(padapter); if (pbcmc_sta) { -- 2.43.0