From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E26AD306D3F for ; Mon, 3 Aug 2026 01:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785722160; cv=none; b=kvNHqmqGPZtJK/vpF0Or2tXcji3k9HVeXiaGk9gJPdnbJs18BJsR293seBqBQeakzC6yF7g9p5FDwgMJILirFrItD791UJ4c2ffIcb9ub8WvWMSvm6twduB4gRs3gB+VakeJTph4+e9Mt0YmAbFZphEgm807LRQVEYBf/7k5fHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785722160; c=relaxed/simple; bh=g4H1hbMh90l9a38pV/EfPDTW1hnYvFjHlgNzZYSURoc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ox4ssjflgN9p1yMzprwGDb9ch7OMq6VHxXebM9S9COmtyWAnlCljzt4zJVK3GxtO1ilMyHW4sqUEhRTV9Kukr4wpJSG+ZpgMKQkIlaUpbfNMafi25YktcamZ9nGhad1i2U40i+DbWbIYRMtxntNL18RTXMFJ2XgtfWJ/0JIn12U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F75trzPP; arc=none smtp.client-ip=209.85.160.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F75trzPP" Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-52b3934af3fso27591201cf.1 for ; Sun, 02 Aug 2026 18:55:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785722158; x=1786326958; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=9Byze97zYiZuTfUuNyuf6+u9So07JOgTJYce4Esicao=; b=F75trzPPksJlullUVr/XEYej7VudhMEnyLw1vgWqJrMmrlWhBqwKyqs5eP7AufeTq3 Sg6HYW0mA7WNECyd+01C8oP02VVNHXJ3qFNVikgRpmVVwc8dOGyBFOQsEFHGKrOUzw3p JEMMmG1/sxUIx9XuqT3aIsYHuVcCqnPT3ysNy/TD5e/KxmLQJNgCDVXResGND0rC2Myb nY32PJqiE8o052mESK0zTyHX5NirpeSf3zsP8/zWw2Zbi56ZJgQE1SYKtt6nWfJUY27w 9q0HBcNKhtU2P66w2AjfqFihjZaylC1Ot2G+8QFUqBXEFgFD1hW0iLeY9Jt1YH7y6QGk Gi7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785722158; x=1786326958; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9Byze97zYiZuTfUuNyuf6+u9So07JOgTJYce4Esicao=; b=fRRlsMi11uLaYsicAxt91xH32f2mx3gcpeTjE4hzUAN62HGd8/47t/JsrX4PvGmbSg lkwBVOJBDHxLR3o75JqRmdSOCFu70MRMv+rfEAfTE8ghHYtz7RosZ4j0AqXESOD1dNFO 2Cn/lWxrMsotqIOGUf1FJJGjN6Shxtj4KBA1fcOjmXQ9+31NHkOdTjwSgpWOr2iKfLgY 6hKLpSJtd6j/AUJx+mq32tJqSfBlW+ggmWnmm0j/Pde4V9dWxYg8PKrhuZSRGVS9ODQD 93BhUmalM1COcVFyFOPY/A/Zubpsgii0olE6nWoCldXwnEGqAYBYt9n/KLRCWYu2uIMp TzIQ== X-Forwarded-Encrypted: i=1; AHgh+RoFMJFyqcr/OevKafpnKFdkBLfWIuwWBp0Xgv8Sbt7YcmI+eZpRnthQRTgh9Us3fAQF/raKy3qhp+SHasQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwkcmMiqmFpLKggteqTYNUBJLuaYGgfgsX1gBI3TVEdT5xsoY+S s8yL7PaikIj+qcUt4ZiplWRRgj6BqdYpmh9aSs4GZKkBjGFK9plLx65D X-Gm-Gg: AR+sD13pbeYkGSKp/LnU5usWzFwygPjdF7T0MELPi2WdgMclmqGgPNCNpajwhDxGjta SQu2AmkikbVLlUgAnLOrPV3mYDL1Tk9kbUf31evTBaJtgDbEDIYnSz/Cwr6+03paZAbmoFwr5x8 OlVxh98cJOYDsElbWh87Uo2TXOGjwWTz4Wedyd+HYi9SWiVqcz97AMqigsIC2wteBpYDaSBdLTl hWlBHlChUCCRflOcTzD2RGgdYtweXCZlIxYLoyjcDu0GMnZcmyENcGBzqOm6dRViORcX7Dj89mn Ht67m2P79ihdbKaDYLSKyIBL1mE46UOMwLDEj0Ha6M+/xhc8RIZN3Ydp4TKqQuQvamPMPdtNwIW v2spNAWifNKE/Ltn8ksiZH9WUDwjd5fX1LzvmgGoC8NLytdgK1UVc2x9A3dWwh9TXYhW2oTqgri QZRMJlvGcZ2CUUQOlvq7TB5ur7F1itcKgiWTqKqd7OngXI0LBsykOcTa7UuHOsdmZNtyn8tnb1m jZjDbFtXb99aJXzAfK91foH3/2C7qSC8C6iSMeXTig93KLt9iUNMZQWBr7injI= X-Received: by 2002:ac8:58cb:0:b0:51e:47a4:4851 with SMTP id d75a77b69052e-52b5666c02cmr154596361cf.8.1785722157687; Sun, 02 Aug 2026 18:55:57 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52b4eb956b6sm51590551cf.20.2026.08.02.18.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 18:55:56 -0700 (PDT) From: Yuho Choi To: corey@minyard.net Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] ipmi: Remove all sysfs files on registration failure Date: Sun, 2 Aug 2026 21:55:50 -0400 Message-ID: <20260803015550.618808-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ipmi_add_smi() creates the nr_users and nr_msgs files before trying to create the maintenance_mode file. If that last creation fails, the error path removes only nr_users before dropping the final reference to the interface. Remove nr_msgs as well so no sysfs attribute embedded in the freed interface remains registered. Fixes: 627118470fcc ("ipmi: Add a maintenance mode sysfs file") Signed-off-by: Yuho Choi --- drivers/char/ipmi/ipmi_msghandler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index ab4c85f3d6fe..546b7ca8d68e 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -3740,6 +3740,7 @@ int ipmi_add_smi(struct module *owner, sysfs_attr_init(&intf->maintenance_mode_devattr.attr); rv = device_create_file(intf->si_dev, &intf->maintenance_mode_devattr); if (rv) { + device_remove_file(intf->si_dev, &intf->nr_msgs_devattr); device_remove_file(intf->si_dev, &intf->nr_users_devattr); goto out_err_bmc_reg; } -- 2.43.0