From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADAF43469E7 for ; Mon, 3 Aug 2026 06:16:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785737789; cv=none; b=RXL+vPzDiRVtiHru1uSnWna13HTxGhK3Rxq/Skl4v0TY2p9v2jMg4vSk805+OFbOuh89hjVIE50KX5Xd2kQRGgbxJdNUpGjo6oxCXRakI24VV8am/f1Weqn6QOLo1wXZcgw7ZwQ7r+y0+ZqNUHSvTBiDuiaiJ1ftLv7CLLHB0Wo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785737789; c=relaxed/simple; bh=Eqkb0R/oIqXhkbE+UObfC6eqxJaNV4/C/YFAkbFv3A8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nXVTlbinh/PFoakZTSmLKXzbm7/JtmIMqJCNDsIhz3Z2fr1JlYpH5GVTJjkyjoB6yMj0U7/CPEVCItXCuTniWScjonhBUvCOoy9tiGL+oVU2SBD25nVjYaCfcJ3PwvCzF2BYxQ5FInp0af2S2+vaiDEsRWczmg8hD2MpL3OHPTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DKXO+FkR; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DKXO+FkR" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38e58034d05so2934972a91.2 for ; Sun, 02 Aug 2026 23:16:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785737788; x=1786342588; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MC5IkkkPZlTOt+vmXT4WDxhQwZYfZLHq19UwWIDKxFc=; b=DKXO+FkRnSUhcPuKbfREY5ymCZGuYv2jD2Ym+MJL8t70ipr7+btof2tJNpf5f5PbyR 8LannA7vaY+VIu3lTfqFI+Nnv8L+gAlzPRxcQrnlHZr9r5UIGXuqg0PQiKNdx3ZTlT+x 8k2eXhqVUclqDpE2nhhFQWUbrHcgMmoHbX3jCt7EBDwScHaohSLt8V3upQkhyNYvLmI2 QVVk5NzoLk1Gmvv2XdhSTOlxxUuZamXutPjwBn4GdHsXqc2EIjauknOoCEIjyoZcN2J3 01mp8BrH36mRUf0t9b/5beh0HOOMAQ9KjuX4j2/plIsnucaDCoyMfg/O+1nk4m8Rhmt1 3oqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785737788; x=1786342588; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MC5IkkkPZlTOt+vmXT4WDxhQwZYfZLHq19UwWIDKxFc=; b=Ac6yKa8gIO7gbYWi6yVlyZ1pgM21k47AIgIvOgC8pXo5JoYCihPl3sikev+gLNkpzY 42vzpFQQI88Vh8JNtkVVyIqOJaRPDPZDugJp56YqhXUtgO2CqztTTzdWnxKQy9eTjICe oZssBlJBIw3FSNYjk5eGM9CvQLe9/hXKtoFyC1XJBKD4av37ioCn7aujNHD6MK38OTjn tXkpSiECCGNrUSzRy4E0+rbiI9hXi7JW2NIIb4a+DSTAR84zx8bk6lu1eCsg7iJsTMr0 LyofFLIR/1/9JtUzSCQM+4yc0eh/VjvSrrjn51tlyTecPEtSZ5vroLRmUUs3m2iLuOht juJw== X-Forwarded-Encrypted: i=1; AHgh+RonrW9ek5K3zk1qAOi0DwCTUyPs2g343mIl/VJsO5/sOtVqQXF+SYrkNibN+eJ9wgUL/jGialcXg55NPSo=@vger.kernel.org X-Gm-Message-State: AOJu0YzSvFxvPm3AvFSJg70ZHmjFClVLDbwXwuFipqjQUmLEZtou3V15 rXCoV5k+pDE9n03IGY0FP5QGYBkgfJYGWR0bGqjurdcZn37WTvEOMAS9 X-Gm-Gg: AR+sD111wEH8n7zfHUx7PW2K9ZYjEXFDlhPDRR5xO5r/YStlxJL1wX4P/cKtnElT8CZ EXvJj9P/99CTclwhg3YrX+sucH1VH92Iwt+L0eBEJdwrmxIVH8fXRuW9tfzAqbNrQ+LFCQU43va 3lsZfiMPq6MZugXuGVs0IU1H9PTgaIeWHOunf04cikwzs1XSew+hy+56djkdh8anQSxoiR5iFdv pjEAG5flx+jNv7VxArKqX3ihSl4r2X2W4T7AMRfll8tmOLQHC3wsGFLACleqKLnBKcSgyLNgdZd O6EquTGcUeEnJiz7I3HY1SrVsiuzQ8sbzCgub2RFUdeEE+1GmqpEIqW9ZZClUSxoVcciL2r4HSn KnKB4jbN430kAPyrlGQ23EXzqypfbHI0eKMaLycEylBSr+PWb8TTqWZ8B6SE+xcEF9VWbpuOBJ9 rAhpvySnp27BCM5p9nC3x/Nd6iKsuP1xU9xiEOfzIcZJJk4h4E0M9zG/0nVkZ/SDi1sapgStl2V UN/G5n9q8WmKvgNa551efqtSCTXipnXJ9NgIUmB5hnIVbH9/XJau61EOz4qJHubJhN2lHQXLbQ6 UjqtrQ== X-Received: by 2002:a17:90b:48c9:b0:38e:c0f5:7c4 with SMTP id 98e67ed59e1d1-38fbc516011mr7192879a91.30.1785737787901; Sun, 02 Aug 2026 23:16:27 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fb2f6539fsm3469002a91.5.2026.08.02.23.16.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 23:16:27 -0700 (PDT) From: phucduc.bui@gmail.com To: Chen Wang , Takashi Iwai , Mark Brown , Jaroslav Kysela , Liam Girdwood Cc: Inochi Amaoto , stavinsky@gmail.com, sophgo@lists.linux.dev, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 2/2] ASoC: sophgo: remove unneeded devm_kmemdup() for DAI driver Date: Mon, 3 Aug 2026 13:16:05 +0700 Message-ID: <20260803061605.35485-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260803061605.35485-1-phucduc.bui@gmail.com> References: <20260803061605.35485-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc cv1800b_i2s_dai_template is never modified on a per-instance basis, so there is no need to duplicate it before registering the component. Pass the template directly to devm_snd_soc_register_component(), remove the now-unused local dai pointer, and drop the template's const qualifier to match the current ASoC API. Signed-off-by: bui duc phuc --- sound/soc/sophgo/cv1800b-tdm.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/sound/soc/sophgo/cv1800b-tdm.c b/sound/soc/sophgo/cv1800b-tdm.c index a97f775aeddc..4badb6e3e08b 100644 --- a/sound/soc/sophgo/cv1800b-tdm.c +++ b/sound/soc/sophgo/cv1800b-tdm.c @@ -558,7 +558,7 @@ static const struct snd_soc_dai_ops cv1800b_i2s_dai_ops = { .set_sysclk = cv1800b_i2s_dai_set_sysclk, }; -static const struct snd_soc_dai_driver cv1800b_i2s_dai_template = { +static struct snd_soc_dai_driver cv1800b_i2s_dai_template = { .name = "cv1800b-i2s", .playback = { .stream_name = "Playback", @@ -636,7 +636,6 @@ static int cv1800b_i2s_probe(struct platform_device *pdev) struct cv1800b_i2s *i2s; struct resource *res; void __iomem *regs; - struct snd_soc_dai_driver *dai; int ret; i2s = devm_kzalloc(dev, sizeof(*i2s), GFP_KERNEL); @@ -666,13 +665,8 @@ static int cv1800b_i2s_probe(struct platform_device *pdev) platform_set_drvdata(pdev, i2s); cv1800b_i2s_setup_tdm(i2s); - dai = devm_kmemdup(dev, &cv1800b_i2s_dai_template, sizeof(*dai), - GFP_KERNEL); - if (!dai) - return -ENOMEM; - - ret = devm_snd_soc_register_component(dev, &cv1800b_i2s_component, dai, - 1); + ret = devm_snd_soc_register_component(dev, &cv1800b_i2s_component, + &cv1800b_i2s_dai_template, 1); if (ret) return ret; -- 2.43.0