From: Andrew Morton <akpm@linux-foundation.org>
To: Hongfu Li <hongfu.li@linux.dev>
Cc: shuah@kernel.org, richard.weiyang@gmail.com,
reddybalavignesh9979@gmail.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, Hongfu Li <lihongfu@kylinos.cn>
Subject: Re: [PATCH] selftests/prctl: Fix non-anonymous VMA mapping in set-anon-vma-name test
Date: Mon, 3 Aug 2026 14:09:24 -0700 [thread overview]
Message-ID: <20260803140924.31bf563743a73653f65e2258@linux-foundation.org> (raw)
In-Reply-To: <20260803103046.14324-1-hongfu.li@linux.dev>
On Mon, 3 Aug 2026 18:30:46 +0800 Hongfu Li <hongfu.li@linux.dev> wrote:
> The test creates a non-anonymous VMA (ptr_not_anon) via mmap() with
> MAP_PRIVATE but without MAP_ANONYMOUS, using fd=0 (stdin) as the file
> descriptor. This always fails because fd=0 is not a regular file,
> and the failure was hidden because ASSERT_NE() incorrectly checked
> for NULL instead of MAP_FAILED.
It's remarkable how often code assumes that mmap(...)==NULL is the
error return.
> Fix by using mkstemp() + ftruncate() to create a real temporary file,
> then mapping it with MAP_PRIVATE to obtain a genuine file-backed VMA.
> Also fix the mmap() error checks to use MAP_FAILED instead of NULL,
> and pass fd=-1 for the anonymous mapping for clarity. The temp file
> is unlinked immediately so it does not persist on disk.
Thanks.
AI review found one glitch which I don't think we need to care about:
https://sashiko.dev/#/patchset/20260803103046.14324-1-hongfu.li@linux.dev
and one possible pre-existing issue which is kinda related and which
you may choose to address. Please take a look and let us know?
next prev parent reply other threads:[~2026-08-03 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 10:30 Hongfu Li
2026-08-03 21:09 ` Andrew Morton [this message]
2026-08-04 11:12 ` Hongfu Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803140924.31bf563743a73653f65e2258@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hongfu.li@linux.dev \
--cc=lihongfu@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=reddybalavignesh9979@gmail.com \
--cc=richard.weiyang@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®