From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f0.google.com (mail-pj2-f0.google.com [74.125.227.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 099922F7EEE for ; Mon, 3 Aug 2026 14:13:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.128 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785766408; cv=none; b=HxT7ZzqXkUrqlUlQiyILiP6iHU860vfuSUJEGUE/kT2xOoJ8BIF4anUbAX35CSfvCPsSk+cCif9qDsmxgjKGM+ltTWX1KL7Hk6nX1h4+lgaszN12l6PPB+7Kc01TQe2WSm/2DNxGW/wR3bwKUfro8bZ2Z0n0AfGRP9gYhKIc8KI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785766408; c=relaxed/simple; bh=SXp/5/NEZwyQ2T6u0pa5PIg41eZcqZD/pweYtKijIkA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bscleX2ljNnjOSSiGi1izyAit5iG3Ufb3+uXqFFevx6uN15uR7EJIjq+jTntSnmL86cqZ5AY/0qasE11Zx/8MeQ8sk9EJ4sxUo41ChHl0UXdygEfD9vso/EY5rApuhCVpfntCbe5iU3HMUpupAk71BLm63wwI9S1M7hF5bM1i5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UGGhO4e3; arc=none smtp.client-ip=74.125.227.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UGGhO4e3" Received: by mail-pj2-f0.google.com with SMTP id d9443c01a7336-2cc6bb7476dso4922975ad.0 for ; Mon, 03 Aug 2026 07:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785766405; x=1786371205; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=u40wfBemGswFY3vLVA1SulOXv0qgjlAi2ZUYZH01yXg=; b=UGGhO4e3FLuJaWaVXL3qg9GXTr2Lo0y+6EHe0EqbGl1yuDT6ipHhUq5qJx92ncCe9f oQtgw+A/zFSN7uiOTav+FndFUn+hqpkC0BWG0oKJ3mqETKN5qLPGN/hA5ioGoP6nWn+Y XTBwF5LzDa1DOL1Kw1XVTE5gXt3b7vPqrzYJ9x5azdyT/o7NEPMkZeAoCsRtkgONVFHR LIDn6jhCao6/xkdn1qE7yZugQJNBkxY58Jl2XHswmAKKdkewvf5d/HlaxC+7gg81FF5p h8lmCJnKqlMGWkExheMJEUm3vTjvno9XZTFIZK65TReNV6SH1OiQeN8hM8CMl1V6yI/l AJkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785766405; x=1786371205; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=u40wfBemGswFY3vLVA1SulOXv0qgjlAi2ZUYZH01yXg=; b=TCntcyB1+jkTNiPgMNHU6m/VoWXnj0xcmQCB7OcNwR3bcRr1mwiTEsMMehnHauJ+L0 LVr/2S5V3nHu+kac3xdHzSb1cTu+2OFy6O5re78xQJLGraxf8UW3FWQJsHWRF6BU81F8 dIjRz5Bp36zM46rLtuV5XXf8Sa+e9YQuYbn0M4auJajC7V1p6L+AiFUuDnbwSKNjzViU mTK15LwgdRXqjFr7CWM6oQI8htPZok3Ty64lD5aHNAvTS0lmAiSUKNNsdWaoKweE+O7a Ixy8hlx6GXoUW585s9AjRGXEXw2EcU9cKyTZWvieftSmUBEmNmZGkzDl/IrKFTsPnZk1 5mPw== X-Forwarded-Encrypted: i=1; AHgh+Ronl8Y9H1f0qyrN33laUXssRFO89KlzPqHKf+UyJBZT6ricMseXBQNQIJXXAcMWBXri3Upr9Fr99EbzZX0=@vger.kernel.org X-Gm-Message-State: AOJu0YwAgOibcVblUERFjFIG5zOl2R8WoyltnQ7Jy9byMilV4bE7dVDZ DWwBTGwHeKnjyJoNXY2DZMsEChpVwTHvzf5aeK0bXyzr9Usv+6KmbeTf X-Gm-Gg: AR+sD10oFXJV++xT3yWglUcgg+5Obt6EYcqNcckxBarQ38NoqLgr9OFFljhGe6RikPU 8ztnvkhYzT+XIHq4HoOvUeB4vQi13MHwz2ZQ6PFfoqWoBqR73mflCbrhV4NNSnugQ7KDpRJ9+mu 3B+rO2A7ZV3/G+Ejl089r5tmWj1aAQjqKHVwOCkZ50zYxTLlmUkz9Ps+kdPODx9M/v7xpYyb7FA HMgSyn0bL7rn/BgqcCb6yG8HpadOlXmwv/m6gCR0UBfsuTFAL9YwZ/4/1JWP0/K/n052L6jMj7i LOjgkkmBbM0yXa4vSTWDKSZVZnfVvD2+ZkcC2XBV5F+4hJTO1cmx49+c+Yu8y0CgLVWXEk8HkAs oDHoeGCUsOSyElzMxml5qWf3kbBnS+bd+jlx7COxOeIUmIsRBE6P5Bd5Id/vCychawmYXhuTmpF Uv0N6X3iJuqj7sqfkfM0XqTCxKEkeQ7r2KlDtsVJOK0vJDGD9EVtbMmpJFTzvy7TnoK2CY6FzA3 9GrDTLYlmx1cD2EvAIgLttfnA+GaLzbFycYI9Jr/jjh X-Received: by 2002:a05:6a00:338c:b0:848:7bcf:9a9a with SMTP id d2e1a72fcca58-84ee4811e12mr8876358b3a.1.1785766405283; Mon, 03 Aug 2026 07:13:25 -0700 (PDT) Received: from HAOQINHUANG-MC0.tencent.com ([2409:8a00:1a20:7370:cd52:f161:9c8a:ee77]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84edc29ebeasm3818360b3a.30.2026.08.03.07.13.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 03 Aug 2026 07:13:23 -0700 (PDT) From: Haoqin Huang To: Minchan Kim , Sergey Senozhatsky Cc: Jens Axboe , Nick Terrell , David Sterba , Andrew Morton , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Haoqin Huang , Rongwei Wang Subject: [PATCH v5 1/4] zram: do not release zstd global params from error paths Date: Mon, 3 Aug 2026 22:12:53 +0800 Message-ID: <20260803141256.60599-2-haoqinhuang7@gmail.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260803141256.60599-1-haoqinhuang7@gmail.com> References: <20260730060133.80233-1-haoqinhuang7@gmail.com> <20260803141256.60599-1-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Haoqin Huang zstd_setup_params() creates global cdict and ddict stored in params->drv_data, shared across all per-CPU contexts. The per-CPU zstd_create() error path called zstd_release_params(), which freed those globally-shared objects. This is a layering violation: a per-CPU callback should only clean up its own context, not release resources owned by the compression lifecycle. zstd_setup_params() called zstd_release_params() on its own error path as well, but zcomp_init() already calls release_params() when setup fails, so this is redundant. Remove zstd_release_params() from both error paths. Signed-off-by: Haoqin Huang Signed-off-by: Rongwei Wang --- drivers/block/zram/backend_zstd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/block/zram/backend_zstd.c b/drivers/block/zram/backend_zstd.c index d00b548056dc..5fabc3e7e975 100644 --- a/drivers/block/zram/backend_zstd.c +++ b/drivers/block/zram/backend_zstd.c @@ -85,7 +85,6 @@ static int zstd_setup_params(struct zcomp_params *params) return 0; error: - zstd_release_params(params); return -EINVAL; } @@ -161,7 +160,6 @@ static int zstd_create(struct zcomp_params *params, struct zcomp_ctx *ctx) return 0; error: - zstd_release_params(params); zstd_destroy(ctx); return -EINVAL; } -- 2.43.7