mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Raveendra Talabattula <raveendra.talabattula@arm.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org,
	Raveendra Talabattula <raveendra.talabattula@arm.com>,
	liviu.dudau@arm.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
	simona@ffwll.ch, james.qian.wang@arm.com, asad.malik@arm.com,
	vincenzo.frascino@arm.com, nayden.kanchev@arm.com,
	charvi.mehta@arm.com
Subject: [PATCH v2 0/2] drm/komeda: Fix GLB_CORE_ID parsing and initialize encoder clone masks
Date: Mon,  3 Aug 2026 15:21:20 +0100	[thread overview]
Message-ID: <20260803142122.4127851-1-raveendra.talabattula@arm.com> (raw)

Komeda currently decodes GLB_CORE_ID with bit definitions that do not
match the hardware register layout, which leads to incorrect hardware
version reporting.

Patch 1 fixes the GLB_CORE_ID field definitions so the reported product
version matches the hardware specification.

DRM clone-mask validation can reject Komeda display + writeback
configurations because the encoder pair attached to one CRTC does not
advertise the required reciprocal possible_clones relationship.

Patch 2 sets the display/writeback clone masks when the writeback
connector is created, making the clone relationship explicit for the
encoder pair attached to that CRTC.

Changes in v2:
- Patch 1: add a short GLB_CORE_ID layout comment and drop the redundant
  product-id mask and shift-by-zero change noted in review.
- Patch 2: replace the global encoder mask initialization with per-CRTC
  display/writeback clone-mask setup.
- Patch 2: include each encoder's own bit in possible_clones.
- Update patch 2 subject and cover letter text to match the localized fix.

Cc: liviu.dudau@arm.com
Cc: maarten.lankhorst@linux.intel.com
Cc: mripard@kernel.org
Cc: tzimmermann@suse.de
Cc: airlied@gmail.com
Cc: simona@ffwll.ch
Cc: james.qian.wang@arm.com
Cc: asad.malik@arm.com
Cc: vincenzo.frascino@arm.com
Cc: nayden.kanchev@arm.com
Cc: charvi.mehta@arm.com
Signed-off-by: Raveendra Talabattula <raveendra.talabattula@arm.com>

Raveendra Talabattula (1):
  drm/komeda: Fix bits parsing of GLB_CORE_ID

Vincenzo Frascino (1):
  drm/komeda: Set display/writeback clone masks

 .../drm/arm/display/include/malidp_product.h  | 10 +++++++---
 .../arm/display/komeda/komeda_wb_connector.c  | 33 +++++++++++++++++++
 2 files changed, 40 insertions(+), 3 deletions(-)

-- 
2.43.0

             reply	other threads:[~2026-08-03 14:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 14:21 Raveendra Talabattula [this message]
2026-08-03 14:21 ` [PATCH v2 1/2] drm/komeda: Fix bits parsing of GLB_CORE_ID Raveendra Talabattula
2026-08-03 14:21 ` [PATCH v2 2/2] drm/komeda: Set display/writeback clone masks Raveendra Talabattula
2026-08-03 14:46   ` Liviu Dudau
2026-08-03 14:50     ` Vincenzo Frascino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260803142122.4127851-1-raveendra.talabattula@arm.com \
    --to=raveendra.talabattula@arm.com \
    --cc=airlied@gmail.com \
    --cc=asad.malik@arm.com \
    --cc=charvi.mehta@arm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=james.qian.wang@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nayden.kanchev@arm.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®