From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B07930FF30 for ; Mon, 3 Aug 2026 14:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785767473; cv=none; b=cPhaoBsRizrT2KaTDF+zKqFYMPGm/XKFrfd+0YXq3TS9ytiDolFGni33McH/I3iYWrf8olDgWXSF+k3+aZkcGuVF8PrEDco/eeB4ZB+9LbgPXMTEscftc+Rma+aA86GtRGpgDvtZY+CrTwazp1ctlBMqjy0OpNrGOIpSDNWyzNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785767473; c=relaxed/simple; bh=rhIU1zG+Cz1JEJ/DZCxK23rcEZYVi7vpJbqoVBA+2qQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NqkhwSYp2oCiQuP+ubX31XJEUU8hLbvAYllnKD0LbtZfC7hWyrS/1rK1TnqWMOl7NKQCNFL7oVVRFO6hCiweIX/mdK0nb7Ty3EKptl2OUEhBTmMwg8HCi5B5pOAEZYbO9ZcDsu2hyNdQY+8d3WdwjNtdFg3Cii/hmNmToaZUj9Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EN5AsLZO; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EN5AsLZO" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4953de5be0aso14537615e9.0 for ; Mon, 03 Aug 2026 07:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785767469; x=1786372269; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TzXAlvJrvz8VJKZL5THLFAhA3g1WFYpeVuZ+6qv41B0=; b=EN5AsLZOMn9+iUtyfCYtIKMbFvHptztVv+bPHFA279POyADHOG7dixnM1f0411liHX 1PrbJZBzQIwEditG2W6wojAatIoBiGxAJd/wLzW/kS179E72gKahzvmNEdr2PUHZasCF /uNQUqpJbkQ89P/Y3YFc8EYUonMWW+Ti2KnKGvvSBL86ycM/ev7qHiO0plpvIbSrTDir hArKa/sM1Ld4W4vKlF86AIKp1P1m65B5WnJ1vkEQZJi2w/8XuEpWp1lqMgU2XXDYA15z MoflB0MCxFRLbu2mLz4rQcHentmwCMrUmlY82EnYk+iqO6meeg3u9jdeu4BYD0pu7crr FTng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785767469; x=1786372269; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=TzXAlvJrvz8VJKZL5THLFAhA3g1WFYpeVuZ+6qv41B0=; b=F99eMsIBA66WDEtMgHCbgkS0HdV6aecK/zuWi/L2KauKQDfYqV7buHMAkU53Yuu46K kF50mQ/AO7K1KsJfytrgRc94LdbJ9b6pHqjs9XTEzbz0aNiEJZdSv51tHa2B+i3VqPGU 5ezuR2kP0+gChtBKzdmCP0aD9vBEmyWNl8K0UJx80m+A2GL76f4BHH5jRbnZQkplwuLM HAZ2RoKyy4VxvDUxpl7jZD9GXRDhw2imfkEM7ZY8g5zVHGeO8kZz1iVj3CoPCBKw3FNV UJoeFr2fKcxGzBd3qv7BhDLxd+++XsBJ3AcUjCk3aFHPOITix+hD8V9UgaXnx1NjwuSi rQTg== X-Forwarded-Encrypted: i=1; AHgh+Rp1V4Qlly917clOoNKSKeFaWSDYi7gIsqj0EsH7hyF0lQE3KwF8e35Qas/gneW21HqYTEwo/GCXawAVyus=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8FUz7GmayE/TdmzIoKI31nRehu/NOZEXyTGeNa+OsA/S0IJoz 9YSx+Lqbnm4toJKw79f1N2gdOK0z55Mkwgp4qKmXUgcxwAjELXx6SUSu X-Gm-Gg: AR+sD11j155yGcLOQq97eoM13bPidtdDfOWQufcjvMXfaDpCPxLxEudsXBUs70LkXmr EP4IhQMVZ72KkD84EY0G7IYP952Ttg7ik5EO+mCUtUE1lOsuBE2lII2yF3VR8kgSxL8+lh25HbC Pl6aXkQ/SRsCvYBtnw663YE3Cr1vZ9OijrRpNsiAS3Aibsyhz2CW9ju7zSCup18ScOhQb7D0t4K 3HdOcJ3JDi86D/4kKDhT631jbx6gb8IkZ7m1pm6uzW81GJ6rAQcDPBgZHFDoeCp9gIlWLfoRnJm WYJeeLHXqjrJeNAFKAE0pIKCU1wUpfpnRewzVa5smeAkuPkrjJDWrSKu8y6Y7+KOamyCyuxZNHl is9z+q4CZksDkumbtDLT536PNsDnwR5mzz5G0pAJrfLO0cMj33QG3uB2vI0u2OBzus03dsJ2P+v CypajYihGJ+Arh6k5a+CErN1D3VGauIPb7AqVSNMFeMdUPmXEfQHVqzk+rOYbVhYgHLQVeQxJHf RJEu/4vKKdkL1srewFFfBPommuF9CqmjLu3T5cJ2Q== X-Received: by 2002:a05:600c:214d:b0:495:3e08:ad19 with SMTP id 5b1f17b1804b1-4980c653c0cmr169146715e9.9.1785767469327; Mon, 03 Aug 2026 07:31:09 -0700 (PDT) Received: from fedora ([202.47.63.86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b98284sm236575295e9.12.2026.08.03.07.31.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 07:31:08 -0700 (PDT) From: Muhammad Bilal To: platform-driver-x86@vger.kernel.org Cc: jorge.lopez2@hp.com, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, linux@weissschuh.net, linux-kernel@vger.kernel.org, meatuni001@gmail.com, stable@vger.kernel.org Subject: [PATCH 07/13] platform/x86: hp-bioscfg: fix new_password_store overwriting current_password Date: Mon, 3 Aug 2026 19:30:30 +0500 Message-ID: <20260803143037.93105-8-meatuni001@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260803143037.93105-1-meatuni001@gmail.com> References: <20260803143037.93105-1-meatuni001@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit current_password_store() and new_password_store() both call store_password_instance() with is_current = true: static ssize_t new_password_store(...) { return store_password_instance(kobj, buf, count, true); } so a write to new_password is routed to current_password instead, and the new_password field is never written by either sysfs entry point. Fix by passing false from new_password_store(), matching what the is_current parameter is meant to select. Fixes: 8646a3b5ee3a ("platform/x86: hp-bioscfg: passwdobj-attributes") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal --- drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c index acb123985ede..6bd56d3f5bd0 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c @@ -123,7 +123,7 @@ static ssize_t new_password_store(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t count) { - return store_password_instance(kobj, buf, count, true); + return store_password_instance(kobj, buf, count, false); } static struct kobj_attribute password_new_password = __ATTR_WO(new_password); -- 2.55.0