From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A29DB417BF8 for ; Mon, 3 Aug 2026 14:49:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785768563; cv=none; b=ApSl0Yu2Qnf1NjYikoDS8nQODW01ntd6GfBC4OOts/Hy6xcRSzCZ29vag704OlMX87pfBuf+8jApS90vRzazhsYh2JGfoIW7NYxKiridYbDnVYpdqOuG4HITX+SaCvk0vD30BOFZWHux4W9KTfObUCxzLLfA/mr6zMKd7qPvfFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785768563; c=relaxed/simple; bh=yXSrBtOlaEUAOxbBAS3EpuNazhUSLmm6d/PYmEb6PEA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CHlSGQR0uKUfEc3ENYCBGHii57VRpy8jT/Rz7SZSTHNIZKtW/L0m9ewEVINAwhJeK2qWccCOkk7129P92ypDaoP+2mpG5IjOfWGZM1bzP3EgFX/1wfwHlUy3GBWTF1ol0xAxlWPEmbAoilIwiigJ5eLBukeryTciwo9CYzNxWMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GztJD85x; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GztJD85x" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-38e347638adso4054247a91.0 for ; Mon, 03 Aug 2026 07:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785768561; x=1786373361; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=OSDW3CGfoOGO3/Bj9spSJOLGw2/wshC5Zc0x5JyYqew=; b=GztJD85xWgbqFMussKBLyxukUrF2EUK14f9UnA1l1AQNnn/AYIl5GpxEqhNCtkA7PQ Ftad1dvXgTLsFs7jiTCRWbOtY9M7mr2+oD5t23RsXQc3ThskP1W8aCJQp7EpSclAURVX m3azvqZxbtS53+Jq0LEv7K3H4twY0AuHtmM98hdWfrUCg/dqz91kxhUsclJ3Ifb4w5/k Ayp7HkB0ouyh2MFMu/BNiM4g7WAFv6k9atZw4n8kMJwrmqFj8zlvG8VXzPPo/M9ZCZ9b W1xuA219pmKp2FklxvltcXbPDAAqyZuRKJ4hYwHHKcU1c5ei4xvCGzJkDWj402LNjPP4 rlgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785768561; x=1786373361; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OSDW3CGfoOGO3/Bj9spSJOLGw2/wshC5Zc0x5JyYqew=; b=ClySIv8GMuB3iSDO0zvlNCqa2qWL7MuQPaARdS11bvPkw18QnArZSPDd7BY0MH5XNq g3Da+tipK31I1lfXRqZH9Surhw4PWagZmcjSgXdZwvgTMnONMTwiEQ+tjEq4qnfsH3q9 6Y9Oos6ZnjHWeOyESm+PIKwAKVFekD/PWiXdFlM/SUis+iaJbNik16nlsQp1zpZGLMEG 8uC1xiMJ4r7gIKn4bs/Uh0Cqw073097UCuB7xBNpaovWXHf6L6HBAZYKY+ZxSSfGCXaC WTb1VJvpRBvr3HFZ/NqbTEtIoDJpBIbcjwCCNlpV3vJUXGplDMhzlPIjkcgW0Z4TL7a3 haTQ== X-Forwarded-Encrypted: i=1; AHgh+RoQpXSS3SlDziTETCZ97zCry6pyNvwa+ZnxcUFZ2QBYliUxRU8598dzpWfAvgiZ5S2bTR5vWp1g2moPNDY=@vger.kernel.org X-Gm-Message-State: AOJu0YwiEcx2yYv5xpR1NXVIG5Cm2/4DsLlb++RkoIdjw0aTr93/Bzl7 t+g5hsuiG+dWe0b8zr+W6p1VXfvPZKS26pdkFs4Ov6SXYCW8/QCJbvPd X-Gm-Gg: AR+sD10KxrTGuOgIYEIMIicOB04fqQyofckQw+i00TK1dYV6OgmN9gHIqbmdk2dybSk RijTCjLg+tHAyhxG0YFfXNbZYAZpNBstwoqbGJCDQqPrtj+T763viwDgszoYlwJvJIJPrQKglKx Bw1MWu20nCZnDSODJKzVzjTYzX8J0zBHCbqLWIghQkYJJF6Xy/Pj0MUVJTBmrvAkqoWJdNqVJAm l0fJi4hv6iDOhXCIo5HuGLUPljvpmCAZUHChbQSMh5VxKJBS3YI92K3cdmbhhIg4T5Xit3tAIMH UCx1ljF13iPs5q/A+xSEL1vYeg+QKVThHi6jeW77xIbr7UJ3l/qZB3Dp3eNuq5njIiBtzSrae1Q gTDtszegjuA136rK9yfTJB+irYcaBDMQWOxzHOpE6IRs9Umw7OJ8DSKxQs979yZY2GXjUbgIf0O ZwgMhJ3fMlPGjhtnUVxrPLM0pmPL7gAHiw3ODPsn72tYbVUAtOTbKNKTynvkGf0rIUgtPhgbs8B 8Qdkw7yQv3Sa42utxRQgOtk X-Received: by 2002:a17:90b:2882:b0:38e:4482:ab15 with SMTP id 98e67ed59e1d1-38fbc4feb5fmr9634342a91.22.1785768560922; Mon, 03 Aug 2026 07:49:20 -0700 (PDT) Received: from Debian.tail44843d.ts.net ([183.82.161.178]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3153e04456dsm35979191eec.14.2026.08.03.07.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 07:49:20 -0700 (PDT) From: Mirza Ishan Beg To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, nikolayof23@gmail.com, seedandsyntax@gmail.com Subject: [PATCH] staging: rtl8723bs: refactor traffic_stat access in collect_traffic_statistics Date: Mon, 3 Aug 2026 20:18:26 +0530 Message-ID: <20260803144826.15980-1-seedandsyntax@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace repetitive `pdvobjpriv->traffic_stat.` dereferencing with a local pointer `ts` to improve readability and reduce line length. This resolves multiple checkpatch line-length warnings without manual wrapping. Suggested-by: Nikolay Kulikov Signed-off-by: Mirza Ishan Beg --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 25 ++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index ce3dfa1fee26..277eccba293c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -1109,25 +1109,26 @@ u8 rtw_dynamic_chk_wk_cmd(struct adapter *padapter) static void collect_traffic_statistics(struct adapter *padapter) { struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter); + struct traffic_stat *ts = &pdvobjpriv->traffic_stat /* Tx */ - pdvobjpriv->traffic_stat.tx_bytes = padapter->xmitpriv.tx_bytes; - pdvobjpriv->traffic_stat.tx_pkts = padapter->xmitpriv.tx_pkts; - pdvobjpriv->traffic_stat.tx_drop = padapter->xmitpriv.tx_drop; + ts->tx_bytes = padapter->xmitpriv.tx_bytes; + ts->tx_pkts = padapter->xmitpriv.tx_pkts; + ts->tx_drop = padapter->xmitpriv.tx_drop; /* Rx */ - pdvobjpriv->traffic_stat.rx_bytes = padapter->recvpriv.rx_bytes; - pdvobjpriv->traffic_stat.rx_pkts = padapter->recvpriv.rx_pkts; - pdvobjpriv->traffic_stat.rx_drop = padapter->recvpriv.rx_drop; + ts->rx_bytes = padapter->recvpriv.rx_bytes; + ts->rx_pkts = padapter->recvpriv.rx_pkts; + ts->rx_drop = padapter->recvpriv.rx_drop; /* Calculate throughput in last interval */ - pdvobjpriv->traffic_stat.cur_tx_bytes = pdvobjpriv->traffic_stat.tx_bytes - pdvobjpriv->traffic_stat.last_tx_bytes; - pdvobjpriv->traffic_stat.cur_rx_bytes = pdvobjpriv->traffic_stat.rx_bytes - pdvobjpriv->traffic_stat.last_rx_bytes; - pdvobjpriv->traffic_stat.last_tx_bytes = pdvobjpriv->traffic_stat.tx_bytes; - pdvobjpriv->traffic_stat.last_rx_bytes = pdvobjpriv->traffic_stat.rx_bytes; + ts->cur_tx_bytes = ts->tx_bytes - ts->last_tx_bytes; + ts->cur_rx_bytes = ts->rx_bytes - ts->last_rx_bytes; + ts->last_tx_bytes = ts->tx_bytes; + ts->last_rx_bytes = ts->rx_bytes; - pdvobjpriv->traffic_stat.cur_tx_tp = (u32)(pdvobjpriv->traffic_stat.cur_tx_bytes * 8 / 2 / 1024 / 1024); - pdvobjpriv->traffic_stat.cur_rx_tp = (u32)(pdvobjpriv->traffic_stat.cur_rx_bytes * 8 / 2 / 1024 / 1024); + ts->cur_tx_tp = (u32)(ts->cur_tx_bytes * 8 / 2 / 1024 / 1024); + ts->cur_rx_tp = (u32)(ts->cur_rx_bytes * 8 / 2 / 1024 / 1024); } bool traffic_status_watchdog(struct adapter *padapter, bool from_timer) -- 2.47.3