From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ED9D34CFC5 for ; Mon, 3 Aug 2026 22:29:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785796149; cv=none; b=A3njK1nyUa2zuG9EIlOe6hOsN7QDynRel747XVKV+oU6pMPP/hjHirL60iZTN5OvwR6S2d2CxbwK5kgptNApdY920NHyvJ8gGkIumky0tsRAEtMT2HfzUPV33FW/y2AUJwDwUa5d7nEoeWIhdei+Z/XCZKAYGqSoIpZ8cK3GZAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785796149; c=relaxed/simple; bh=ddjOipXehAODpjbycR9ZsNGaVtxKMYm+UzQ8H8R4O4E=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gcbDg3wUFNJyCq+J1/TAcAwgxDwblVvvdWG7RVt2jU1Us2AUjRlH+CXVSH5XrvGKAvuglw3VgB1LQNyLmeXGsCH4wlELlKxkgjdxy03iPQAwvocYHtGA0XWpmJASxQrFAGVRtWrs+MA0YZTcV/gMbUwNN1tQ9hJU4IAYsfhtVWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PxjIBm1Y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h5CVIOiR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PxjIBm1Y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h5CVIOiR" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 673Jl3mv1599787 for ; Mon, 3 Aug 2026 22:29:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sZ80AOwZ+2hx6l5a4gRP6Wc1xQDrMzv5eF1oL8ozawI=; b=PxjIBm1Yq1f01leh 2aY5HGi0wy6fti4bkHOHYHc5whd32Qf4IKp+R23FwjXaS3dTvagqRLFY9ypn8Do+ NTopKjNr015QQx6Az9Wix03c2VNUGn85L4s3TGSi6wUpbnSx8nxBKdOntcUgRp4M 03rNOw6Ao/REOzbBB+7CXbUiotLQzdPWFOBWT/R6kDZbO3tGad7Q2jBFbpbzbNwS kdHyIYZdWdrMFOISv8eXMxVwpglN2IHRjmtHpUogXP+EP/exMk6KfIhCyobE5JsC Zo/H9rp2oILcAHu/dUxhWRPocFcYT1ZFma99wrJbba6ISyNouGiiO81LqCbBeCqo 01dXTg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ftnvnm0s8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Aug 2026 22:29:06 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38f0fe57470so289962a91.0 for ; Mon, 03 Aug 2026 15:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785796145; x=1786400945; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=sZ80AOwZ+2hx6l5a4gRP6Wc1xQDrMzv5eF1oL8ozawI=; b=h5CVIOiR8f9Yeb1W16JOhVz4d9KsB4rZMQVv0bCb20lt0ljW6T1mH4oRpjVmdGWS8l fVa19hOt6pyYS57ZHZnlWLpo3Dcy+Z2lZCvtkL+8zY8FxAicbIGwK1l3/N48GMLsg0za fQJAhh4P1/wtbJlNIgToZ8hJJbn4roR1/SHloPJEWO94XWLCQKl+Y9OHe6Yh2W4w6Xnf K2UrFiQGiugHtkFqGQb2COcwNF5lFZnJm+tbty9jaEsUqykMhcDDAIEs2rvfFyQiNppo 9spL20e7W8MOrv5kQ7E9E4jSIUoA21CnQbwZwEXQ+aXJc0ZiFIzAj5dw8DbByyj9oCZY k6dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785796145; x=1786400945; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sZ80AOwZ+2hx6l5a4gRP6Wc1xQDrMzv5eF1oL8ozawI=; b=aS5hPs1KT8ZJF3w9jzFnUvZGFiXeScwYNIyiZh/S1g+CnrOLZG/7ifqAylXubdAg5x JeoN/Glw/2J4srjyDmL6ITBw+B2GqhJA5RUHcwbXL/2pW3YKy8ay3GerlJXRrp6yWgg4 tKClo+jzhVCWYDx3wCzHKe/faBF54Euu6NdKh5IzQwBzEnRqFz6kc+lCx+fF/rZ0by+I suusntwFwcWnHluPyAhJiBkSVU587lR1HdgRVqDzh1zRR2sEFELLWnG1kS3Jmcz0KqR+ VVADcRYoR1pHBaK+9FW+EOU1jZzKOIwGqnGCRFEdhNKsBvbpp8eY1VJEYW8rbhmpFXRm vKPQ== X-Forwarded-Encrypted: i=1; AHgh+RqX7EdP0Ubrg4UVH8DUvQycry7esJ/Ufm3VspQltMl+dL4V2A+LwrB4CzLY+QevkCFNeWpFdy5JiJhNSMM=@vger.kernel.org X-Gm-Message-State: AOJu0Yye2vMk69Dxa9cUESRZzjIM4SiEYNmG3GBoSQKf942ho+U+rExM CBWCi/nJ2eFh6YMdExpgkeQkYXORfQRkMFREZzUlg2MINhySYAU+jKkl5vrrIQPtve0MImRH8ib kUcBQ5sxn2ggkIzVhsenXaf9W6xoPau9r3uc9ryZaUmwPLq1vA60dshqZOqiC9BMPe6k= X-Gm-Gg: AR+sD10pxCH2WiDq1A64A9nYex+XmCYHKgDknmeC6p6a6d24o2Nt5KdbHEGaJtqUXhq dbrG2NWQAY5YpbXgr97vnmKfmL95ushAKD+uRGNXOqtIFb40iVU3ORFieWy7xE8e/b8ncyAbDeK wLLTGbcD4x2doNnBJT6diRo4lT2xVRtix45iVVayMSc9Z3WlR4N3xAPkmV0kZ65Uea1tN0Tf4tf Sls0DHdaLXcONK1tZVwR21w4C0fSyViQLjQwdhGPib5mg3PZkWFIfRNiF6/Qx36QOJC7iT0mXW7 zyGI4KGd26aRVtp7pNN8AIgDhcRa4H0/x3SmXFvGF2WgE4zn2grk43FMtDeKifP87Xt5iCvP27D VCsUvSsK+A6sMrcwNDJGkSecy+Q== X-Received: by 2002:a17:90b:4d05:b0:38e:4f31:8412 with SMTP id 98e67ed59e1d1-38fecc2f007mr1071156a91.11.1785796144756; Mon, 03 Aug 2026 15:29:04 -0700 (PDT) X-Received: by 2002:a17:90b:4d05:b0:38e:4f31:8412 with SMTP id 98e67ed59e1d1-38fecc2f007mr1071121a91.11.1785796144318; Mon, 03 Aug 2026 15:29:04 -0700 (PDT) Received: from localhost ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fab4e44bcsm49863604c88.12.2026.08.03.15.29.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 15:29:04 -0700 (PDT) Date: Mon, 3 Aug 2026 15:28:59 -0700 From: Jonathan Cameron To: Andre Przywara Cc: Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , James Morse , Ben Horgan , Reinette Chatre , Fenghua Yu , Jonathan Cameron , Srivathsa L Rao , Ganapatrao Kulkarni , Trilok Soni , Srinivas Ramana , Niyas Sait , Lee Trager , Ritwick Sharma , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 07/11] arm_mpam: propagate MSC access errors for mpam_reprogram_ris_partid() Message-ID: <20260803152859.00006590@oss.qualcomm.com> In-Reply-To: <20260731170324.2927758-8-andre.przywara@arm.com> References: <20260731170324.2927758-1-andre.przywara@arm.com> <20260731170324.2927758-8-andre.przywara@arm.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=aoaCzyZV c=1 sm=1 tr=0 ts=6a711632 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=7CQSdrXTAAAA:8 a=EUspDBNiAAAA:8 a=_W4zCIwx36R_oyA-FJgA:9 a=CjuIK1q_8ugA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-GUID: T1fvruYP5AxemsY6m5zlWYI7MyPk7LTm X-Proofpoint-ORIG-GUID: T1fvruYP5AxemsY6m5zlWYI7MyPk7LTm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAzMDE5NyBTYWx0ZWRfXywYccO7BxzwY 5q3kj2BYVgwoDSwClzLXUHK5z6XMb+b9VZaKcW4UYqEvRFTx/pH3yQsUM1Czaqol6aBvPKMgHWt klR3Y78HvTLmHXhOChQcsKv8byXXk1zG7g1yNOGbarfWrZV38TS0Iyn3IPNAvMqlhy5UUf+BXXS bL+c2YS55knaLJFWwp342mDTvfP+yB09eL8vKYHQusFy5jz/0Uf0xkyGckXeKdUbjoS0umDi14D zV7bZLK/X3IbnjT9kSOc4cI23daft5GMF877y8uFry9sievkmOK+ShxyH4/bEU24jUQdBOvNdfr ZuNkpx17TgztmM3F8YVfWmRQ1vUTmdsgF5M9e2aq+C9Vb0fulhKfhPexwS47qj7AOhqK+I6U1IT b78pbsZwTZr+RNZOSdY5oz+ZQ61Ay9w9KDgq+ZD4bh75ndukJnMfUPQylJYzYmVYEIqnveTBVim Dk0XcvkaLdvb6BVysvw== X-Proofpoint-Spam-Info: AW1haW4tMjYwODAzMDE5NyBTYWx0ZWRfXzK9FRiDLI0ez UJtyhUVuFR9OXu7GIatk6LMgeJ9kLDRUySe1KMc+2954QJ0ti8OjTI5yGzwxhEtg+MEMvmdDYRd jc6YZHa0W+EjwuhmBwsEZm3JS3QuFow= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-03_05,2026-08-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030197 On Fri, 31 Jul 2026 19:03:20 +0200 Andre Przywara wrote: > Allow the mpam_reprogram_ris_partid() function check for and return function to check > errors, and propagate MSC read and write errors from the lower level up. > This also covers the callers of this function: mpam_reset_ris() and > apply_config(). > > Signed-off-by: Andre Przywara One thing below to perhaps modify if you are respinning Reviewed-by: Jonathan Cameron > --- > drivers/resctrl/mpam_devices.c | 136 ++++++++++++++++++++++----------- > 1 file changed, 93 insertions(+), 43 deletions(-) > > diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c > index 38450c55e45e..32088ad1d67e 100644 > --- a/drivers/resctrl/mpam_devices.c > +++ b/drivers/resctrl/mpam_devices.c > @@ -1601,7 +1601,7 @@ void mpam_msmon_reset_mbwu(struct mpam_component *comp, struct mon_cfg *ctx) > } > } > > -static void mpam_reset_msc_bitmap(struct mpam_msc *msc, u16 reg, u16 wd) > +static int mpam_reset_msc_bitmap(struct mpam_msc *msc, u16 reg, u16 wd) > { > u32 num_words, msb; > u32 bm = ~0; > @@ -1610,15 +1610,19 @@ static void mpam_reset_msc_bitmap(struct mpam_msc *msc, u16 reg, u16 wd) > lockdep_assert_held(&msc->part_sel_lock); > > if (wd == 0) > - return; > + return 0; > > /* > * Write all ~0 to all but the last 32bit-word, which may > * have fewer bits... > */ > num_words = DIV_ROUND_UP(wd, 32); > - for (i = 0; i < num_words - 1; i++, reg += sizeof(bm)) > - __mpam_write_reg(msc, reg, bm); > + for (i = 0; i < num_words - 1; i++, reg += sizeof(bm)) { Not really related to what you are doing here, but if you like you could reduce the scope of i via for (int i = 0;... as it isn't used outside of this loop. > + int ret = __mpam_write_reg(msc, reg, bm); > + > + if (ret) > + return ret; Personally I don't like this style but feel free to ignore as this is very much a personal taste thing. I'd do int ret; ret = __mpam_write_reg(msc, reg, bm); if (ret) return ret; } just to keep the source of error and check for error next to each other. > + }