From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CBF5233928 for ; Mon, 3 Aug 2026 15:40:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785771602; cv=none; b=XNqPwIQMJhuzMPjSZh724M6qZe0CILG9ph0PpGSU+nV6n0oQsu97zjbTC3iqo+W44j/rJE5C1TKN9tevx6FXjPcV9uSMxrqmdidy2JThGU4NCkIGATaeUfO6XMsz+wp7Z8VmewzGIo5yDJA76UYo3wt3YbhZPrV2bQaCPLOIs44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785771602; c=relaxed/simple; bh=kLPvqUYyd6+VZ8KkqxpvUtF5zuTg7CL9QSy3myw5fRY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RifpiHlD7/PCOnkbU04Kdz+DBwBkeCs2kK5xQLCiOpuFtXoTouPofQID20ABx5mF8jBWdIC2Egf6/N67H0gISISpuaOw36s3ucSEAhxTBlgpBtwyudr5F8NbW8wgjumZw8YsBLzJ8mUs45AddVsi1Lw2i1mL0J6W5dqEtgrqIP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QHilW93s; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QHilW93s" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-495635a85d2so20996585e9.0 for ; Mon, 03 Aug 2026 08:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785771599; x=1786376399; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=33x3VU+iF4BupbuQ3tJsItFY9FQ0BMiwV1PziQvPdCQ=; b=QHilW93sK4yh120HUm/cv+y5dnt80DEIL1d9umf/1NcrMUu2Us999CHnhVfsQFPfwx jgklgANRla+Wy4n71HFpuM9F7BPfAfSkw6yxWDjRaaPLG5fKiaZ9L4qWUc6KlWQGhokv KXLNjrkQHBdE/D9KcT7srCzAWOog/EJ4marsaXvnPC/uqCqyWGyfGlM5dCftwZ8kS4Wt iL+Ue7qmjsPoslvQj3bHUND7mP6vuVWGHYGybrvohMEX3rbnUQAGaQ9ZnR2khNEl4bFX q828AKWEXflJPW+78+2EAzi2moyouCPy4yLP4aZssjpbCa5DeWhxZhzbumCwWbqLNvkh wjOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785771599; x=1786376399; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=33x3VU+iF4BupbuQ3tJsItFY9FQ0BMiwV1PziQvPdCQ=; b=Q8/sMyC3x1r8isuRmbUcvvxUmqegFU1dhyiXzKcmA+43c/+xoB29qdR+9YpTcHubCI fIiJ426fFih1eROLh0EquoCHmz9wyTyakTuf5ykloA6Z6ad/BTRnheHo1eTdpePMG7y6 j6UXWp+adey9eJBQesx6NSsrHSnb1XHMTqdYuyoOTqudkPDTFLAUfzVYm1D8Ym/yFcsC fcrR5LPizX9B6sKpulI4i2hipZaGwFT2KZ2fHyC6a8CBGR7iMajcVrVlFJUe58HOx9lM v+dbNSgo9EZJh3+iGggMGtwiMTdS3hokdIqbbuZF+FeiWHe6mL7MzBKZZvyu8m+HTIOK S9Uw== X-Forwarded-Encrypted: i=1; AHgh+RpwJmtyvhjuyPjJTmqa7qsWw0ogHy+wLmQVQj+J6cM49b6GiTSx935wAdciG8+eJ3fqYdIpZBSAToMIpE0=@vger.kernel.org X-Gm-Message-State: AOJu0YyL8xJJJEKfF4vc0YZuQXFS8btE1dQMgeSVmGMlf6HCp+LtKPqQ ttDH+QAy9vMo2+SZ1zMo813hcL93fiZ6Y567mI9WF4N1Yi2WtEIwbB64NlZOFDbymco= X-Gm-Gg: AR+sD11FSq8ezECfDu551G7KLw3hT9MUro/WIJf/RISQGHG1iwSF2T6MqAn2mfMEork b4zV9T9/FROezUzawcO/d5oIlk1gNKr9KzfNT1UMTQBTyYz7EDe1MlAaSEZ/gthqTyhd3BXN365 N28JzTJy3d9+566vapZ7Ra268iNAks+nNsXWTp9cqb20zbPP0vGmBkPyVHIYlRip7Mkg4O+oTGo kWCvvVjm1W4DnbOJjdTHZVknvsBCRPB6tJ7cWuZc2N2+/eh8KM0jerqT9lWOT/evZCheAVwqYNP xAG9oKhtjcnc8u+Miik36RQ036p0/SViYDGxWLFp/ygoMRfhPR/Rp/0PTwQCtUZJtLIAbd3vsBF uCJnsrSebs3e/6YJtYkNc9d66Cftf/phBKRT+s6qAB+JHPbSkW+gFll/ja9D6g7nwCmeqZKEfJM N5gzbuXQNCjQ5v2ubMUzRjLLTEfSsQ9LoE2t5ifsBQVO53VaT7V5virubsB6lecJMXSDTjBmk3S +pGT+y88YOjb7idiHPD2NW9lma2NTllo6J3 X-Received: by 2002:a05:600c:3e15:b0:495:5dcc:52b4 with SMTP id 5b1f17b1804b1-4980c649cbcmr246156405e9.3.1785771598646; Mon, 03 Aug 2026 08:39:58 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd458adc9sm36200628f8f.27.2026.08.03.08.39.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 08:39:57 -0700 (PDT) Date: Mon, 3 Aug 2026 16:39:55 +0100 From: David Laight To: Nicolas Pitre Cc: Borislav Betkov , Ingo Molnar , Thomas Gleinxer , Dave Hansen , x86@kernel.org, Andrew Morton , linux-kernel@vger.kernel.org, "H. Peter Anvin" , Peter Zijlstra , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , rodrigo.alencar@analog.com, jic23@kernel.org Subject: Re: [PATCH 0/2] x86: Use "er" asm constriant for add/sub Message-ID: <20260803163955.627bdd3f@pumpkin> In-Reply-To: <11o7545n-7569-3p9r-1q77-8nor8513r6n1@syhkavp.arg> References: <20260803094702.3852-1-david.laight.linux@gmail.com> <11o7545n-7569-3p9r-1q77-8nor8513r6n1@syhkavp.arg> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 3 Aug 2026 10:49:40 -0400 (EDT) Nicolas Pitre wrote: > On Mon, 3 Aug 2026, David Laight wrote: > > > The x86 instruction set only supports 32bit signed immediate values > > for add/sub. > > Replace the "ir" constraint with "er" to avoid build errors. > > > > Found by a patch that added used mul_u64_add_u64_div_u64() to > > do a rounding divide by 2^32 (perhaps not the best way to do this). > > > > A quick grep only found one other affected file. > > Would be a good idea adding those cases to the test module. They fail to compile so it isn't a big deal. David > > > Nicolas