From: Krzysztof Kozlowski <krzk@kernel.org>
To: genevieve.chan@altera.com
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dinh Nguyen <dinguyen@kernel.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux driver reviews <linux-drivers-review@altera.com>
Subject: Re: [PATCH] dt-bindings: clock: agilex: mark mpu_l2ram_clk deprecated
Date: Tue, 4 Aug 2026 09:49:23 +0200 [thread overview]
Message-ID: <20260804-excellent-electric-yak-d2de63@quoll> (raw)
In-Reply-To: <20260727094926.1124-1-genevieve.chan@altera.com>
On Mon, Jul 27, 2026 at 05:49:26PM +0800, genevieve.chan@altera.com wrote:
> From: Genevieve Chan <genevieve.chan@altera.com>
>
> Preliminary documentation referred to mpu_l2ram_clk, but that clock is
> now mpu_ccu_clk and is already represented by AGILEX_MPU_CCU_CLK.
> Keep AGILEX_MPU_L2RAM_CLK as a legacy ABI-preserved ID (do not use in
> new DTs) and mark clock ID 42 as reserved/unused so it is not reused,
> keeping all existing clock IDs stable for DT ABI compatibility.
>
> Fixes: 6b3c59780ed3 ("dt-bindings: documentation: add clock bindings information for Agilex")
> Cc: stable@vger.kernel.org # 5.8+
> Signed-off-by: Genevieve Chan <genevieve.chan@altera.com>
> ---
> include/dt-bindings/clock/agilex-clock.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/dt-bindings/clock/agilex-clock.h b/include/dt-bindings/clock/agilex-clock.h
> index 06feca07e08e..de7a58a06651 100644
> --- a/include/dt-bindings/clock/agilex-clock.h
> +++ b/include/dt-bindings/clock/agilex-clock.h
> @@ -44,6 +44,7 @@
>
> /* Gate clocks */
> #define AGILEX_MPU_CLK 30
> +/* Legacy ABI ID; do not use in new DTs, use AGILEX_MPU_CCU_CLK */
> #define AGILEX_MPU_L2RAM_CLK 31
> #define AGILEX_MPU_PERIPH_CLK 32
> #define AGILEX_L4_MAIN_CLK 33
> @@ -55,6 +56,7 @@
> #define AGILEX_CS_TIMER_CLK 39
> #define AGILEX_S2F_USER0_CLK 40
> #define AGILEX_EMAC0_CLK 41
> +/* 42 - reserved/unused */
How IDs can be reserved? These are implemented by drivers (abstract IDs
not used by hardware), so how driver could reserve it?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-04 7:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 9:49 genevieve.chan
2026-08-04 7:49 ` Krzysztof Kozlowski [this message]
2026-08-06 7:43 ` Chan, Genevieve
2026-08-06 7:58 ` Krzysztof Kozlowski
2026-08-06 9:58 ` Krzysztof Kozlowski
2026-08-07 4:03 ` Chan, Genevieve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804-excellent-electric-yak-d2de63@quoll \
--to=krzk@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=genevieve.chan@altera.com \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-drivers-review@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®