From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-00364e01.pphosted.com (mx0b-00364e01.pphosted.com [148.163.139.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D250147B43E for ; Tue, 4 Aug 2026 18:52:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.139.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785869557; cv=none; b=LHN62FU1SM7mmNQ3+7v/GEYM/Lruz4pc/z0zVnb4I/32fWwKPIeTvfun6CgNoHKP3AQZFJZt8fda+DZTE4JANLkjCifCdA8tzzuXjVumVr36g0LLfoYt4zedYA1FQ3CzjdxGZrrU4DHjNbUE3Nm6uoi0py0adzMyAc0hjJKCduc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785869557; c=relaxed/simple; bh=g8jPUs8pg/UEHyzRirqPZNurckpVqv7a3bIwEUEkAXw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O5ZzHGfPSGPfehgATqJf+Hy5cllL6cDlskt2bEbCSEPpO5zmecyKQsxGwkyyq0qwm6dLt+FO2z2PXgIZIisR99DZcwgdbbFC2T6vJj2sOdUfAbiWxHr3NyoQ3caaYQHuemmlSt1iJGfd8d3ce8LHwZ+Y54nfuZUmbkb8YGhekKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu; spf=pass smtp.mailfrom=columbia.edu; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=L97s7PyH; arc=none smtp.client-ip=148.163.139.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=columbia.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="L97s7PyH" Received: from pps.filterd (m0167077.ppops.net [127.0.0.1]) by mx0b-00364e01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 674IYB8Q2126301 for ; Tue, 4 Aug 2026 14:52:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps01; bh=6cEc Am4InXbaEDJaVpQUaZztPzUmrUXxaK7Mht5hSMw=; b=L97s7PyHs9MoxkJbnlnJ bob3e54A+PzjFbMJqyEpOSP83Qfu462DaYwFPq0SP6TG/IgGCWXhz0Nemgz1N/tQ YxEwK2Ez7Zn/m+S43x3BhSZWbb6ZajJUC/gMwuvpP2FqyHkUKrF+Ptz6Y0KAsw0m m4ix2vYWYNqBphFd0e1bSmW/VexIogi+V3XUJMixmM9cePya+6IrVwLnmDMcFSrV V1BOmk472SN3Q8+N79xBqvJtO1+AbYwc5WkRsjslFsVCPZsVPhI0vn1wIauvO5kZ PjLcr+yUXpjmpwzW/8wej/OKEhWliJKDw7BL6BCdFun7MLDAZev+Hlbs119SpYSs ig== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0b-00364e01.pphosted.com (PPS) with ESMTPS id 4fuj0et13t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Aug 2026 14:52:27 -0400 (EDT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51a8b0a08d2so1004771cf.0 for ; Tue, 04 Aug 2026 11:52:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785869547; x=1786474347; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6cEcAm4InXbaEDJaVpQUaZztPzUmrUXxaK7Mht5hSMw=; b=ZGI3XEZTvfBKDB8yhmvSpf/0PIKZQrXkBQyvgxKQVGJH2pyXIyzG/sAsOxmNuDUS6M fSO8/e0LI7dVr2E1aJO993lIUtpOICUaJOJzi0t1EWG/QwXZOq2jxh8C4bKDSk28T3Hy XT+1ax2sBlfq9p0b+Ju1nmEi0ZyT1f3OuL9/LdADUKP6mzUZlDEWycPYNsBQqkI5xpdV go0+tJ/B+yAn7xSFDGnZv/sV1+8du2Vp9xOaPuWIwmf2QnibA/1vEUp1MSlbkF0aX7XI 1v0m1mNC/SqO2btjLQPOELxKNo8mV/wDIagNQgBhknsBfJgI9zh4oAfSjmpgBbnfUNlE YxlQ== X-Forwarded-Encrypted: i=1; AHgh+Rqp/ctgmIZm0YXkMlUbFOCQxlDpDMduJgk29MI7zl+1XSfgjkAo1f644njCcpuSImj3dLRQV0U20c1EsMY=@vger.kernel.org X-Gm-Message-State: AOJu0YwKJNODg6BnUR2kx53BoKl9BPr/soylRm91METW0RU6NKIt+gem RlZjH6znZIYcFNCl5sGfABJKrCbF+m+gdOeILOyWMR9eqJx7Mw3WmzDHnbAxmRg/bheb9W0Yz/B JgPWjy0+bBl/O7DhylB8k194g09jMvv4av8t2ihQwgLaJjObBqsGtqi3fP/ta+w== X-Gm-Gg: AR+sD12+/UcVBoF/amCypFZRpEsAizIkeIbfln6WaNShyeGHJVb+o/lAL5ZimgMMEWT i063hV+qJrc0RnjsT95B9GI4NCBwLN+f1PbS37DjtkeLZ7EooOEDbuL50LfELNTSCKbFghS2abh 7itieAvdn8tzRNDUBVagqCzFaNvr2V4vUSH5GzoysTU5h+bFZ7B51qV++GwUsw+MwYSDmunR8im kPPGWEpysOaaANVieEzNE+mi4pbyLijGAu7IG3eZrbD2gCvICPz5AVTs9AYOcMXNIJ1YnHLvBdc 4laDClwNOgA5GjoszNJt3T/qcCn/pUmo9iPutV2H8v+zQvuFkQKxNAbgVXV6f9Dm548IOICTsEU fEcd9Qg5P X-Received: by 2002:a05:622a:258a:b0:51c:ba4:d837 with SMTP id d75a77b69052e-52ce6033864mr14931611cf.18.1785869547239; Tue, 04 Aug 2026 11:52:27 -0700 (PDT) X-Received: by 2002:a05:622a:258a:b0:51c:ba4:d837 with SMTP id d75a77b69052e-52ce6033864mr14931161cf.18.1785869546719; Tue, 04 Aug 2026 11:52:26 -0700 (PDT) Received: from [127.0.1.1] ([77.137.77.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec232d7fsm2313275f8f.20.2026.08.04.11.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 11:52:25 -0700 (PDT) From: Tal Zussman Date: Tue, 04 Aug 2026 14:52:09 -0400 Subject: [PATCH v2 01/10] ceph: add ceph_folio_snap_context() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260804-remove-wait-on-page-writeback-v2-1-81f0ab065284@columbia.edu> References: <20260804-remove-wait-on-page-writeback-v2-0-81f0ab065284@columbia.edu> In-Reply-To: <20260804-remove-wait-on-page-writeback-v2-0-81f0ab065284@columbia.edu> To: Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko , "Matthew Wilcox (Oracle)" , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Tal Zussman X-Mailer: b4 0.14.3-dev-d7477 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785869541; l=1926; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=g8jPUs8pg/UEHyzRirqPZNurckpVqv7a3bIwEUEkAXw=; b=kPzJerCbpMCCBKGAtZw8eKWb6/5ZVD4+Ug9RVQ0xo6KmV7nNnkpdLDMCwQucUV99QtMamuOod lxHS1F8FsRxCiL9AoDQknGXRMPSE1dKxItslwY4r9TZxB1CubxQ3RQW X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Authority-Analysis: v=2.4 cv=ePIjSnp1 c=1 sm=1 tr=0 ts=6a7234eb cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=j1J1DEHOHTVaJYOjuVnKiw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=x7bEGLp0ZPQA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Da8U98TiO7q1upZEImrf:22 a=QOCMdifcju39GKoXhKua:22 a=ALYDsW89DncSylXEcn0A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDE1MiBTYWx0ZWRfX+nNmo5vLk9X9 1uAU7HGfALb+zQh69tUC1X/K9pMoO661nFW0fjlHSPXpiQ/jJrviZjV4YFiPRhUdaAVO4V+k/IB xjKPBbWYm0/TnknNYYWR2pXlBdOKVC725p53UzmcRKqVK8h3HdID X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDE1MiBTYWx0ZWRfX4QnRpyny68Nm 8y5WKlLN7R+aiwG7gAyeDyUjH7s2GsNPh1fFhKqO7MbIAeQkpjsnV090r98/5MrYomhtoBfMFbw g8niwVZPEu1Te9iX45VPMt/og6y20JmCP/c5HMvMcwKcQRHF0Kr53TXpIQrvShriflnc6qJIlUk 4lKkVi942dECccvV2l20vcJZl/RHYmv569/LaQhcmQT3ILWt5Ewn1Mt9UFUVLCP/bp0Kvfkte7m +CFaU8EXXHmo/SY5fuxnsm3ntOUDr9Bb/36DPlqJ5CrqQiPaWpbqi6sqK1Ck/zei+drBDKlS1Ca 2oG/7VBRU6sClt8jkT5oRGvguO90WdXsKA6JZWW1X+j8IZehXPTaKvEmB14HbERbxETInzzwaVK ddzynJUlWC79fqwQ8xtRGdRF0zxsLeIjcEGQX9OrZNfF5nOcQ3fIdi2Lfu+GXL+a9gQhemOi0/F B6ACNDO3GUssxFOrA9Q== X-Proofpoint-GUID: OsRXqVvh23z4Rn_xpXy8jAK8U11Hdfc- X-Proofpoint-ORIG-GUID: OsRXqVvh23z4Rn_xpXy8jAK8U11Hdfc- X-Proofpoint-Virus-Version: vendor=nai engine=6900 definitions=11865 signatures=596817 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 adultscore=0 spamscore=0 priorityscore=1501 impostorscore=10 lowpriorityscore=10 bulkscore=10 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608040152 Add a folio-based counterpart to page_snap_context() that reads the snap context from folio->private directly. Convert the three writeback paths that passed &folio->page to page_snap_context() to ceph_folio_snap_context(), removing three open-coded folio-to-page conversions. No functional change. Signed-off-by: Tal Zussman --- fs/ceph/addr.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index e2da3ab9f808..8347366ce5d9 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -75,6 +75,12 @@ static inline struct ceph_snap_context *page_snap_context(struct page *page) return NULL; } +static inline +struct ceph_snap_context *ceph_folio_snap_context(const struct folio *folio) +{ + return folio->private; +} + /* * Dirty a page. Optimistically adjust accounting, on the assumption * that we won't race with invalidate. If we do, readjust. @@ -749,7 +755,7 @@ static int write_folio_nounlock(struct folio *folio, return -EIO; /* verify this is a writeable snap context */ - snapc = page_snap_context(&folio->page); + snapc = ceph_folio_snap_context(folio); if (!snapc) { doutc(cl, "%llx.%llx folio %p not dirty?\n", ceph_vinop(inode), folio); @@ -1171,7 +1177,7 @@ int ceph_check_page_before_write(struct address_space *mapping, } /* only if matching snap context */ - pgsnapc = page_snap_context(&folio->page); + pgsnapc = ceph_folio_snap_context(folio); if (pgsnapc != ceph_wbc->snapc) { doutc(cl, "folio snapc %p %lld != oldest %p %lld\n", pgsnapc, pgsnapc->seq, @@ -1824,7 +1830,7 @@ ceph_find_incompatible(struct folio *folio) folio_wait_writeback(folio); - snapc = page_snap_context(&folio->page); + snapc = ceph_folio_snap_context(folio); if (!snapc || snapc == ci->i_head_snapc) break; -- 2.39.5