From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-00364e01.pphosted.com (mx0b-00364e01.pphosted.com [148.163.139.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CDBF4756D2 for ; Tue, 4 Aug 2026 18:52:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.139.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785869554; cv=none; b=MWO85vP2Fr+UXE8lZZiz8i6Hy1V7/Qmeh9vZjkbftizqDMWZ2tSgb4l+IrIE2N8EzKaKw4xBgJn6q04hM5Tll7rbOhOYFPYsFBfcol8x9xQzb1MepoEFeNW6gYe6IbE/37tsmqmORXCvi8/hfHYi/ZuMHkFrMoqRc8LQsOjwVDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785869554; c=relaxed/simple; bh=9zGm2Ur3Nw8t1fGAniDrK4O8Ro9h7p/uEv8uJfX+ZUc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rKDtojzi2gLYmWnEu2jDQ+c5Dizz+ZBB6nwF6Va5pyIZP13UH67giHkcSCqDnDI3CErV0iuw7AF+CYso/FTIOA5hdkQ0XSkjZ6WLaUsOdgoGZUQmFkOhC4LVnwbrz07OIf6zzu4cu2kWVL5aBeposxefX5tnslbAuG5vy1tFFTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu; spf=pass smtp.mailfrom=columbia.edu; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=HY0pFEmU; arc=none smtp.client-ip=148.163.139.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=columbia.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="HY0pFEmU" Received: from pps.filterd (m0499198.ppops.net [127.0.0.1]) by mx0b-00364e01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 674IY5mG2463545 for ; Tue, 4 Aug 2026 14:52:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps01; bh=yedV j+u8P0Tmm47FPkrJoqBk2IvRgeJQ6pNoT7nNxrg=; b=HY0pFEmU2udRqNNtUDxJ 9RSw/lY1Vy7TzmvBYQFFbm40N4EWHwXjduXKD6rPYdsd71ltw1pMGfLRlKg+A+Tm EeksvS+7yGHcIeZbpz3F5DcsvH4dB6uY9vtQfupd+eVglKx19C9VuMyTDCGkvwLB gniMiWuNavsOszMidxOzzU/aeuza09cTtZR7VTESvwda2biUIollaTjfdJiZ3dPE L5PMfaZONppi5iegiAmsn14rGXFS5Ij1b+24q9tudfiyTDVE7d6zTN/lW2/GFaT1 Pl6n3xbk8eztta/yTTrL0tVMLE+xrrmnzNP2S7pbmok6hsdSwINqqHG6Ys2BASdw mQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0b-00364e01.pphosted.com (PPS) with ESMTPS id 4fum1pgxcw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Aug 2026 14:52:31 -0400 (EDT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8f45dde7595so1305926d6.3 for ; Tue, 04 Aug 2026 11:52:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785869550; x=1786474350; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yedVj+u8P0Tmm47FPkrJoqBk2IvRgeJQ6pNoT7nNxrg=; b=RhNe1a/eI6wNfNaisHh9RuDbMX7zXasC+kGtSyacQIyM0rXgpbq8DWwuNZrea7HKVt HkFWFpBWF8vPOCZlPJwpUIm2LiN5ELChcuzEDhmNV+Ju5i4e3ZF8sEaUQLDQQzvpC917 jWWq/dlpipEcZpaNwCpexp56NBKl23XHzBquDKXdmgZ1g6MArV9m++cIV6JJY6z+W/SO kICU4wGh9MX7EOpVmHTN9A0L+0LLTetanf7rG+bUmAjb5p8986oiXnowOj8xtUUMDWIr W3O4XRlmtkPo0Y06UpS2tfnUFtHzLATve7J095Z/F/Q4AzOPUBsEmP9SnG2q8PaZMMn1 k9ow== X-Forwarded-Encrypted: i=1; AHgh+Ro7NL6NOjivMFpQGPnmt1+QOG8dM8a+b3GGQDx/c2NouIzY161WU2era7a59/PRzvEFnrsCDH+2UBFntqg=@vger.kernel.org X-Gm-Message-State: AOJu0YzqZ85MRx9ZNCIzu+bJ2MIkeNwMZ6xIEGstU0FLIR0Ruve1BmkC vHolp2qW0edkCS2hGPAyuK6RrQWyR1eyakD24V/EO/bxLjRziculv6KBGNz6O3giPsTveo9HFvK lMN6A/04MVD84mcubwS2F+zOwzqwtQlV3e/JkbXMpdc4EOmq8P4BaYhhqf0BRNg== X-Gm-Gg: AR+sD11sSL1Gprv1CJcXUcJaf+YQw/v7Cy0qtJzHCShrs8cI1LCbTviBw8jjKPvG9MA MKhK9PgGZITT4SoII5JSasVZ/7cvNuHcJgaQ/ysbVg3RvDmoMQglpruF1Wpi5Ylj+n6HguJfdRJ QyzUjseKgANypm9kSSmuLqm9agMH6abs2tLHtMEEee2pz2Vs+/XlGxso1WS/kubyophNzSsTz1j VKZfNIjsOaCjNySTX95i6kYG1ac5muGPeznHk5Es3ztDO75Wf6c0QYa+bRpEQ4PMEBJUydco1NQ SfT/dOKyIs59zmztjjNX6rPAybI1gPAlTbhpMyqU9CYvzdZv0scKh8RxJlXAIIgxBW1lxIpEXxE uY8nDA5tz X-Received: by 2002:a05:622a:355:b0:519:8998:661b with SMTP id d75a77b69052e-52ce60c07c6mr12783041cf.20.1785869550474; Tue, 04 Aug 2026 11:52:30 -0700 (PDT) X-Received: by 2002:a05:622a:355:b0:519:8998:661b with SMTP id d75a77b69052e-52ce60c07c6mr12782271cf.20.1785869549978; Tue, 04 Aug 2026 11:52:29 -0700 (PDT) Received: from [127.0.1.1] ([77.137.77.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec232d7fsm2313275f8f.20.2026.08.04.11.52.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 11:52:28 -0700 (PDT) From: Tal Zussman Date: Tue, 04 Aug 2026 14:52:10 -0400 Subject: [PATCH v2 02/10] ceph: convert ceph_wait_until_current_writes_complete() to folios Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260804-remove-wait-on-page-writeback-v2-2-81f0ab065284@columbia.edu> References: <20260804-remove-wait-on-page-writeback-v2-0-81f0ab065284@columbia.edu> In-Reply-To: <20260804-remove-wait-on-page-writeback-v2-0-81f0ab065284@columbia.edu> To: Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko , "Matthew Wilcox (Oracle)" , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Tal Zussman X-Mailer: b4 0.14.3-dev-d7477 X-Developer-Signature: v=1; a=ed25519-sha256; t=1785869541; l=1518; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=9zGm2Ur3Nw8t1fGAniDrK4O8Ro9h7p/uEv8uJfX+ZUc=; b=YhHy2DJ2mcWRFMayaQHzRWVDDTYASGlGUJSMGAN80QdBcHSVdXLZ5tByq7B/kPH+1jdGwugfR syQDU3doLFhB5JzGHt5ToPbjDwQSP/Ct8ZorKaIRSv2e2Bwqyj1AwU+ X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Authority-Analysis: v=2.4 cv=PII/P/qC c=1 sm=1 tr=0 ts=6a7234ef cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=j1J1DEHOHTVaJYOjuVnKiw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=x7bEGLp0ZPQA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Da8U98TiO7q1upZEImrf:22 a=BpGzv1V74M3SfeTrGa8v:22 a=JfrnYn6hAAAA:8 a=oBeIbaJldBQvbLH65vwA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=1CNFftbPRP8L7MoqJWF3:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDE1MiBTYWx0ZWRfXzj++QJGsLk0A 7UtTXJMl8MRhsUYmpFFYFBkC7/QxKb4GyExFgMGxOAwvWsPIATsvdUGigOS6PKAdC77i9knMycS DidmYIBIUWPCz7BXzhoI2wAAgsWRngBxTYtYW3437FvnqiBfyS3m4L/DkybI0TWjPh5VO7JlS2a p17ccjuCYCRzP4cuQn19oenCNZKy38S+8XNm/XQfDI2pfuqT8BncnGqYk12RygftF+45qJJtvaa EOvyKgAeAA5SWS9h7noqPsyubMBFEh0BQ6vWPA+4dlPUI/7aPgPae/CXE55z00QLBEmSw422FnK lWJbK3ypKn1pvimhaMf30gdfjxg6dgb25cd9eu+h+IHQHh9BSFKYYMmq9oJy9RG9sc9CxfyIg8p RFEzuFYYLKCbsIjZc89NicNYB2nPamWktWps7KecP53wJ8smOavz6XnjkJhJiA1tebkO44PwTkW RgtEr6leqfjttWBcXAQ== X-Proofpoint-GUID: LUgdj9bMlInefjiDP2kk-nYncY7RiJna X-Proofpoint-ORIG-GUID: LUgdj9bMlInefjiDP2kk-nYncY7RiJna X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDE1MiBTYWx0ZWRfX6h0jxxhs6C7j WcvXs81Sw6LkxDja1dusmzLuPHbcnvaWb7WtgYYHSnGQY50J7FiEaD+cb+UTVhWSzvDONlAjhFh iBUEwaI7XOw0fh7TAokStjQiibb3rTxoxBNcs7B9K292SYVzhI88 X-Proofpoint-Virus-Version: vendor=nai engine=6900 definitions=11865 signatures=596817 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 malwarescore=0 spamscore=0 bulkscore=10 impostorscore=10 priorityscore=1501 suspectscore=0 lowpriorityscore=10 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608040152 Iterate the writeback batch as folios rather than using &folios[i]->page. Use ceph_folio_snap_context() for the snap context check and folio_wait_writeback() instead of wait_on_page_writeback(). This removes one call to compound_head() and the last caller of wait_on_page_writeback(). No functional change. Reviewed-by: Matthew Wilcox (Oracle) Signed-off-by: Tal Zussman --- fs/ceph/addr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 8347366ce5d9..967243f425f2 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -1624,7 +1624,7 @@ void ceph_wait_until_current_writes_complete(struct address_space *mapping, struct writeback_control *wbc, struct ceph_writeback_ctl *ceph_wbc) { - struct page *page; + struct folio *folio; unsigned i, nr; if (wbc->sync_mode != WB_SYNC_NONE && @@ -1639,10 +1639,10 @@ void ceph_wait_until_current_writes_complete(struct address_space *mapping, PAGECACHE_TAG_WRITEBACK, &ceph_wbc->fbatch))) { for (i = 0; i < nr; i++) { - page = &ceph_wbc->fbatch.folios[i]->page; - if (page_snap_context(page) != ceph_wbc->snapc) + folio = ceph_wbc->fbatch.folios[i]; + if (ceph_folio_snap_context(folio) != ceph_wbc->snapc) continue; - wait_on_page_writeback(page); + folio_wait_writeback(folio); } folio_batch_release(&ceph_wbc->fbatch); -- 2.39.5