From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C8EA3AFB0E for ; Tue, 4 Aug 2026 01:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785805766; cv=none; b=aUWAhnfzYubp5ICyizGt6VrXnDuxzElRAT2RI+yprtI9NhNHYvDGZSjjO7PcRb7dECsK9rHcAe0QymUg/Jkq/+AxEjwS5pGhIq94ioa1XTWnAo9NdumF3DCXVuTy0G+7kIxWNroEgmb7H06zND7ANvr++CootdESxA4dX4nwN/k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785805766; c=relaxed/simple; bh=/Tx8lp5PYGsfalGBmpWCVtMyVUB5gh3Ex5MCeuTCDj4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m1QQRcJ6h6/ATm5x6qz2JVC0qoBk+bFDXDpqyf3bCElHXt+K00PBDz0M4JAzeY9IcIJnl1s07NVZQpoEcAsbMsHdmh9mTjaEhRsrYA55w25ciogTNC8KHzJ53lczBsfxG5rgQIki7dtRHfTW8AN+NrVM8ExpNDJ+CchWDXgQ3Sg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ISc3EYEH; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ISc3EYEH" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38e7109321dso2335445a91.3 for ; Mon, 03 Aug 2026 18:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785805764; x=1786410564; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/Tx8lp5PYGsfalGBmpWCVtMyVUB5gh3Ex5MCeuTCDj4=; b=ISc3EYEHBVuayorlfyCgvO+42UK6E1U3Y6CtUjd0Q4Z46SkKSLFp8JJdUS6lI5qscM IC/7XDcTV6vNrn3Yx3/LR+WTsK5KpZYd6zm2V8/1ca+xhs8b2YFfgGlP3Wppz7v0R091 CzF9CO+OlQoxrjge/KMY9HY7+VNuHY/eZlSEDp+qWUK4Gsmir2vPfrNxnMCgQLJQiD8Q wV4a7rhGbDcQtGZlMz0S6ZenCRdWobJEdPQu356BCbPrXMOpMZoTWOHjzdLEJOZar6pR A1DeVuItdNJ9DgGzo/HzGAjjZBtGDSPp+74AMCUNPNtw4B/GungBsd3ls0MbAd0StqT6 2b0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785805764; x=1786410564; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/Tx8lp5PYGsfalGBmpWCVtMyVUB5gh3Ex5MCeuTCDj4=; b=VSTbULinR7wu7i9Feg5pJb/yf9n5bSWBuub0xnlQerdjJE3G55FzCzCSSaqVYHMZj6 Oyunmai+fwkBQVleRFmrlECzbgOK+Mf+qPj6fPTW078K8Nhosri+HIUmE1N2YHtQCyx5 3TjsGEyFiF9rTrtsiNadftfdkx9bnAXs5GSOrvEh+Zjxvd0QyJni9EhTdvSplXnuGjOC zes4wONkqcaBEftvG1RbClszBC5IZFy1zPsC77nfKAey24s/janCYmRWC68qF0VqcwCO FJQG8L/18Z61u0PEYLA3vbmmvGgF88MoHEPDpXfHVrPPNSZdVnqkQ+jDzM7N+0SdZJlW AJqA== X-Forwarded-Encrypted: i=1; AHgh+RrfbtMagVbzsVzNqi6tRo3T3+5wsFDCGGbzWBKbvguJF9bhbUMVCEAfFtzy27HTe5IvkoY9V83D6YV/9pQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzr3UVMMaGLeCD7aYqTKKGnInJTEt8OM3Yjsp6J3MfrE8JGSDNq FJ5x+LGysgwIe0iALrCAt0OWRO8G0E5jDMW9USbB5UcWqo1kpwxQlvDY X-Gm-Gg: AR+sD13ASMbYCdqcXAGEGUoL5tNZWjj/FzIy4ELk3hc42+x/5qe8n9uDk9/QycUXsKO UrKuAwCv5vomQi/wSojgUNAekShdEsiYWBUhLpxCanAp37laPkP9yDa3TJFuT3kdNuGL7vM4cZL AyKagWvDe0idXiPeu0z3CEqEWemn4Paq7nHCMyoumPWSYGD/sBRShxj4yz/NhLOQe9RPM2wJWBx mZgL3ckbuSYPmBBWgKD3E4ce6bV2cYhkkxBL9Sw0iyfyNCD8QQ0MpRHpCC92mpRNJCAYU8vCY8l 5IDCScKMz6W3QP318S1HBe2TA72MgjglMZ1zER4CVAt0Qr4TuFf6upVSOBmIJEu+vkxEi/9Qxr1 dzNeUFnsgjq50MdnxBuI8zVlua1V53y+riNqlzSXOV4vlYZLXnO6zN0CKRRsRwKCtRc3UVM9+yw WH8xamgbImdU6cvPUY/n2qOufCoZYkw+QV8KxbQVKsqpq83d2j2yjCih9tFbelOwxHX9QH9pvgp 1H2TFxMsh4VOVYYrqcubQ4jSLHfR/j3c1Qe4cz7R2nv4DaDxvkd X-Received: by 2002:a17:90b:2dca:b0:38e:6dd:a9ad with SMTP id 98e67ed59e1d1-38fbc0baf26mr11945449a91.0.1785805764489; Mon, 03 Aug 2026 18:09:24 -0700 (PDT) Received: from secrnd-cstp.tailb7f510.ts.net ([125.131.91.97]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38feda51060sm438434a91.10.2026.08.03.18.09.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 18:09:24 -0700 (PDT) From: Sanghyun Park To: Andrii Nakryiko Cc: Sanghyun Park , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Sun Jian , Puranjay Mohan , Ihor Solodrai , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+cdd6c0925e12b0af60cc@syzkaller.appspotmail.com, sashiko-bot@kernel.org Subject: Re: [PATCH bpf-next v2] bpf: Fix mmap_lock leak in irq_work path Date: Tue, 4 Aug 2026 10:08:21 +0900 Message-ID: <20260804010821.3756062-2-sanghyun.park.cnu@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, Aug 3, 2026 at 5:44 PM UTC, Andrii Nakryiko wrote: > > I'm just not sure that re-queueing works if irq_work_is_busy() returns > true, please double check. If that doesn't work, then we can miss the > irq_work callback, which would be bad. I see your point. I double-checked this, and re-queueing seems to work. However, keeping the irq_work_is_busy() check only adds one flag read, so the performance impact is quite negligible. I'll keep both checks in a conservative manner.