From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B988F340D9D for ; Tue, 4 Aug 2026 04:30:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785817854; cv=none; b=QJzsfDJBERhbT9NYUU34dzj3zUQyJz1HhcIAKFHoR29naqUtnfeB4nCD5fU0mPoMjqEdB3U1cZx4hTHHCSr28IzpT7BQnxEpOvxEwHN5cx5Es1J0dCZ/h2KGRhZKclEPET+JhZKgZ0t+MrsDzEIt4tO/j9AkbKWwd+gn6B6sFFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785817854; c=relaxed/simple; bh=OAETXZTVcG4Rpgb01BW+Bm+y6f2gek5DmYAEnw75v6Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WiC5ZH6Cbz2SQKp/LZvxJnq9OiffKu1qqVizXjXH4fM6Icfw39O9PY4+DwHksSaKWHmHA2SylyDolPxHPLGv9ewbzLEJf8kiI0chozCn8Xkr5R/g+JN4FZpXyOJsdzKc1irkmzLmudRz+29AK7lLgEHHiqbCJmAaBE7KjhhG5do= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QEdA1kt/; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QEdA1kt/" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2cacb8416a1so41114185ad.1 for ; Mon, 03 Aug 2026 21:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785817852; x=1786422652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=7yaXhmEwb+mJHwyLaCJwLr0hoYPttqtvD7BNNFbot6o=; b=QEdA1kt/hwG2JChYJypx2ps1JTOYoaFUwpLNPZLeV4KrLZxcJILXzBL7WM+UjD1f+D uFZJ0RvPXqHblGCRlrYjcWEq+NR79U+oQjWSitxLpm3DpT77wpOvgagudNj23zDaUOaj JFN2IGUWfCPahmm/AylmKJ2cTq0hk6dPzyBbAA4MIhjGdHEY9tbAlseRomH+83HXTjRp x3ttGYEnJeyAcCLAo9smTeviYQOofsHN7Uu8+rIQAH/Rf1/mmRg8lVkJW2a3myXqRR9w cAf/33q/KTVQDUi89TeD8Es+D9n807lVFpdSGJoqmiuoinPxdkg7/bYJiFEY6/bbBaxk tqKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785817852; x=1786422652; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7yaXhmEwb+mJHwyLaCJwLr0hoYPttqtvD7BNNFbot6o=; b=VP5EikiU25L5kVFDH06ySpfQldvae6ce9LYeJvZ2d6J3YJP0WbnICVp08BY+0EP19O Q8dJsOHBJ39vhXwVks0iuP/P5mHTzFE7kVDgjDIRS4Wlm2L7f0V2RWdXmGqiaH3a71Sf j6TFhznd99ZNHbFu/ihzOeljuHNplTEDjso++STdsvxnJg0YC1t27XgzywCsIpUvLW0y TLL5UcuveGL1vvtWE+6K9gBBTW03FB2VzgAbKcGTDBOJBEvv/bHMNtapFSlA5U5x1u6M hVcNrlaa98J56G8Mq8/Anu/3k7w+BtP9rf0r7QYkpiTutWYkK4JGm0dAhisIgPPnO2xG UinQ== X-Forwarded-Encrypted: i=1; AHgh+RpnWVL4JaSujhS7R9F7uC6vzJL1c6uqNZTdWpJtKoV/EcRQsW5LRkH+mfPOk+L0dhYVbLdBC5+NTNkrMTQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzd5hLO93ibFOojspmhkS46OOMgAeXrzLxiMlQujFvOM9S0z+Vh egTS2LDrbdpJaMedxcn9z/E4ZpsVxIL/DC0BDY0sPFkhbCXvwldx/Tnk X-Gm-Gg: AR+sD10Fxo4dEkBLpvwEiHNUOflm7XG1g2kiyBHV7vWB47MV/pJXej3CHPXAfkC0A2F AdvNIaYjnz9TL2gqEE5+rXXKxDNgV36VKAFT5gXn5Trz3jsFP4yzQ2jpZneU+GXuzLOjwjpshYJ RjIdUvsOtDilH8BhYAbZbgSc+dMenkq7B0Rh2OpBCbqrDUWS7kkAzXBWIgmi7zO42McrxmQnNDc 0iZkXC7Ey4agvB3dfjMwkQCK/WxfGKOoEW+0uGQfXwGqcs1TP6aLB58x3O8BvF6jMwOulXUrYLe iYySI2e80cYUbzu16H8YDAjQ8Z4pCjyrNbDsNXP85hGLgGd5Jnc3xuPS1CCbk5MJPsvbSsSJxBO EtyJhAIqAxfijnvEPswmokupmlYWkawb1O5qMKtOO7TxMWNw02TcJiA23kCnrpBQaPj1lHjJ3/A nkqo0nqkTkW8FqySKPqzlNVwZwc5NR/pchFljQBqTAq2c41t03dVxflzoT/cwZQjzr0ezCeNNa4 NWfYgsTN8Re7YxnX2uFLyUldvCjhLG62ItXCFARMf7k57t/lKxmyGDPMJMPy+sr+iS1G+xmimGP 6vzT X-Received: by 2002:a17:903:390c:b0:2ca:ce92:6e44 with SMTP id d9443c01a7336-2d05218984fmr118913895ad.8.1785817852050; Mon, 03 Aug 2026 21:30:52 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d04ae58d8bsm46026045ad.26.2026.08.03.21.30.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 21:30:51 -0700 (PDT) From: phucduc.bui@gmail.com To: Yixun Lan , Takashi Iwai , Mark Brown , Jaroslav Kysela , Liam Girdwood Cc: Troy Mitchell , Goko Mell , Jinmei Wei , Kuninori Morimoto , linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH] ASoC: spacemit: Remove redundant DAI field initialization Date: Tue, 4 Aug 2026 11:30:36 +0700 Message-ID: <20260804043036.22065-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc spacemit_i2s_init_dai() already initializes the playback and capture fields after duplicating the static DAI template with devm_kmemdup(). Remove the duplicated initializers from the static template and keep all field initialization in spacemit_i2s_init_dai(). Signed-off-by: bui duc phuc --- sound/soc/spacemit/k1_i2s.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/sound/soc/spacemit/k1_i2s.c b/sound/soc/spacemit/k1_i2s.c index 2d5ea1fd5d49..28a762769253 100644 --- a/sound/soc/spacemit/k1_i2s.c +++ b/sound/soc/spacemit/k1_i2s.c @@ -354,22 +354,6 @@ static const struct snd_soc_dai_ops spacemit_i2s_dai_ops = { static struct snd_soc_dai_driver spacemit_i2s_dai = { .ops = &spacemit_i2s_dai_ops, - .playback = { - .channels_min = 1, - .channels_max = 2, - .rates = SPACEMIT_PCM_RATES, - .rate_min = SNDRV_PCM_RATE_8000, - .rate_max = SNDRV_PCM_RATE_48000, - .formats = SPACEMIT_PCM_FORMATS, - }, - .capture = { - .channels_min = 1, - .channels_max = 2, - .rates = SPACEMIT_PCM_RATES, - .rate_min = SNDRV_PCM_RATE_8000, - .rate_max = SNDRV_PCM_RATE_48000, - .formats = SPACEMIT_PCM_FORMATS, - }, .symmetric_rate = 1, }; @@ -399,6 +383,8 @@ static int spacemit_i2s_init_dai(struct spacemit_i2s_dev *i2s, dai->playback.channels_min = 1; dai->playback.channels_max = 2; dai->playback.rates = SPACEMIT_PCM_RATES; + dai->playback.rate_min = SNDRV_PCM_RATE_8000; + dai->playback.rate_max = SNDRV_PCM_RATE_48000; dai->playback.formats = SPACEMIT_PCM_FORMATS; i2s->playback_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES; @@ -411,6 +397,8 @@ static int spacemit_i2s_init_dai(struct spacemit_i2s_dev *i2s, dai->capture.channels_min = 1; dai->capture.channels_max = 2; dai->capture.rates = SPACEMIT_PCM_RATES; + dai->capture.rate_min = SNDRV_PCM_RATE_8000; + dai->capture.rate_max = SNDRV_PCM_RATE_48000; dai->capture.formats = SPACEMIT_PCM_FORMATS; i2s->capture_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES; -- 2.43.0