From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f9.google.com (mail-pj2-f9.google.com [74.125.227.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 439B0432BD0 for ; Tue, 4 Aug 2026 09:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.137 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785836351; cv=none; b=hXf3h76rXJo3oKYR7fSkPWEIr+gLVjEdWvCuzMkmvMe/6o8bHp4VKx1d1BiU8em5cuWqSeHuo7riUfzgc5hQzNkILUC53wiLa0+IJNDPqXpwWdblHU4kSunEm6BprCdOOr16GLbBG0XsRa0s8okCqS29Br82K9xyyj2tkwnLGqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785836351; c=relaxed/simple; bh=SXp/5/NEZwyQ2T6u0pa5PIg41eZcqZD/pweYtKijIkA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qxr2ttB8NMu6urHhuooqsHn0nNbgNRhKIirn2zsPWDcBYn3cpfysr5R9gtrsm3PK2l9yFAQfY/zsL0kdjm5kyKeNdTQfdVA7vZS96y7jml/yulFcdXrKB25piStff4ORPbJfTctrw6E3uKkWfYzartfvFXCVvbPdHD+b1sMk14E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZixILjc5; arc=none smtp.client-ip=74.125.227.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZixILjc5" Received: by mail-pj2-f9.google.com with SMTP id 98e67ed59e1d1-38f0f8ab050so3605102a91.0 for ; Tue, 04 Aug 2026 02:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785836343; x=1786441143; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=u40wfBemGswFY3vLVA1SulOXv0qgjlAi2ZUYZH01yXg=; b=ZixILjc5o/OUubjHNpA6St5uqS/UzJfIifVJsjlOu+jfFTefWYZrYufHkcgu/YZaCb xyXhl9c88joS33CpxPY5uRRctQ7PLCkVWXfg3mLdRxTaJXB7g+ukg/v8YngGW6bXuNuH fsYMlb+zUa8MqkvY/WOP39XkSn+yAYHnHCDxZV/mRT05hFv1j0FHbsZ1yuYtObq6txJA I9qkdJCxl3ZYk3GGz4R682SnIFKuFy8ShC93E/2aRkOJaC+MMD4wgxh82mdCnMd3N50f aEyS2ik5jviiCRYHwjABzHJbihQ55l4qVcxwUU9ByBdT/p03kWRYGBQeJUi1Oh5K4jmc hwbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785836343; x=1786441143; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=u40wfBemGswFY3vLVA1SulOXv0qgjlAi2ZUYZH01yXg=; b=D0rCectR0T4PymGENvzM+sGvHZBgKfRjHIj7HFHzCFUA8c2Z3XW0WJkQGkkSOQDykX jnbhI04yhNdtL7CaHA/LtVYm1nguBlgvNbbs1k4zZzGWW6JYThpRT6NAB0aL1UXhar/G +6xg/jVgXAH9zB3pMEa77PIYyNOf17xcl3AZQj2q6Q2Anbuu/1iUNJiS4rEx2cdr9kp6 S0YIom8GqgLhneGe9MJ3IMWhsiIi0UHwGlmtdAThIBw+yNu/XC1VpAVxer58o8+cKvJQ 8StNZHYCKOPAsfbmL1ihzuNf6Cxvmfe/97C4mZOSkGRdah4ewrBcjS5LovJgLWt5JPTP ICew== X-Forwarded-Encrypted: i=1; AHgh+RqyVt400qKJArzDjGTGvO+kU5foslPTHgrSEPy//ParDDW8/rSpWrhSfdF4qAtnkRqzVKJ+L6QexhzmPGw=@vger.kernel.org X-Gm-Message-State: AOJu0YyRJN3Q0Cti3UOPkkJnZlkKfy+vKk3j9GuSWNByVZxI6pywcfQY PP4/AcUUBsBcwih0segigSaRcmM666cRv3smhduLsTBv2SluH4QuOnG1 X-Gm-Gg: AR+sD131AbJtAQhlDkizTprAMi5bdTcvptcte7SwDyaqN1n8ZnYRdVFo+prnLb8Mrra m+rX9T8Ts6I2i813CKPNzQaUAmumLgVMt0zJxEWPgh88f2tf/4MdxTPcyFgBw8vp9wqF2lme8Wv ZmIi/FVC4iJapYLpMWtuyAXiJx4akLBhB4rFG82tRJJphv3dbDMS/tao0PSgmFp5csy5yZVWzvH 5PnxQWvgjk0PtkCHOwdBP/HHe8rJyelCOcRQbUsFIzY/ggGqRYmlb0RU2ZEA2c9V4veRzhPYPdd /80hHFjIB5Eoc61ztW/srihFbNOOxWHwkGhvSEMTdFR7U49mx9JB/5MHmbhLczFXvEiTxIcRUt/ 6R+2IgJOotN27M7etwJ7eHX+NwyqoE1f5gPEknK4g7URECAt/R91/rLcFR4ydpoFfhlm1bYA11C ahetlEWOue+MiK9Se2Kf3nnhVosXaw86fMK/V0H9o4c8rHO9IeEe/MyjZDvtbXC7TCRsZipNpfG PKeFbQSd0OhKkz7B4PcNYE6Ucco9JfCCA== X-Received: by 2002:a17:90b:48c9:b0:38e:2fa0:491b with SMTP id 98e67ed59e1d1-38fbc511d3amr11525510a91.31.1785836342997; Tue, 04 Aug 2026 02:39:02 -0700 (PDT) Received: from HAOQINHUANG-MC0.tencent.com ([43.132.141.20]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fee06b438sm1042633a91.16.2026.08.04.02.39.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 04 Aug 2026 02:39:02 -0700 (PDT) From: Haoqin Huang To: Minchan Kim , Sergey Senozhatsky Cc: Jens Axboe , Nick Terrell , David Sterba , Andrew Morton , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Haoqin Huang , Rongwei Wang Subject: [PATCH v6 1/5] zram: do not release zstd global params from error paths Date: Tue, 4 Aug 2026 17:38:37 +0800 Message-ID: <20260804093841.67920-2-haoqinhuang7@gmail.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260804093841.67920-1-haoqinhuang7@gmail.com> References: <20260803141256.60599-1-haoqinhuang7@gmail.com> <20260804093841.67920-1-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Haoqin Huang zstd_setup_params() creates global cdict and ddict stored in params->drv_data, shared across all per-CPU contexts. The per-CPU zstd_create() error path called zstd_release_params(), which freed those globally-shared objects. This is a layering violation: a per-CPU callback should only clean up its own context, not release resources owned by the compression lifecycle. zstd_setup_params() called zstd_release_params() on its own error path as well, but zcomp_init() already calls release_params() when setup fails, so this is redundant. Remove zstd_release_params() from both error paths. Signed-off-by: Haoqin Huang Signed-off-by: Rongwei Wang --- drivers/block/zram/backend_zstd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/block/zram/backend_zstd.c b/drivers/block/zram/backend_zstd.c index d00b548056dc..5fabc3e7e975 100644 --- a/drivers/block/zram/backend_zstd.c +++ b/drivers/block/zram/backend_zstd.c @@ -85,7 +85,6 @@ static int zstd_setup_params(struct zcomp_params *params) return 0; error: - zstd_release_params(params); return -EINVAL; } @@ -161,7 +160,6 @@ static int zstd_create(struct zcomp_params *params, struct zcomp_ctx *ctx) return 0; error: - zstd_release_params(params); zstd_destroy(ctx); return -EINVAL; } -- 2.43.7