From: Andrew Morton <akpm@linux-foundation.org>
To: Aaron Tomlin <atomlin@atomlin.com>
Cc: lance.yang@linux.dev, mhiramat@kernel.org, pmladek@suse.com,
linux-kernel@vger.kernel.org, david.laight.linux@gmail.com,
neelx@suse.com, sean@ashe.io, chjohnst@gmail.com, steve@abita.co,
mproche@gmail.com, nick.lange@gmail.com
Subject: Re: [PATCH v8 0/2] hung_task: Improve warning budget handling and task reporting
Date: Tue, 4 Aug 2026 16:05:55 -0700 [thread overview]
Message-ID: <20260804160555.7622850f6162aae463714289@linux-foundation.org> (raw)
In-Reply-To: <20260804202050.262427-1-atomlin@atomlin.com>
On Tue, 4 Aug 2026 16:20:48 -0400 Aaron Tomlin <atomlin@atomlin.com> wrote:
> The hung_task watchdog detects tasks stuck in TASK_UNINTERRUPTIBLE (D)
> state for longer than CONFIG_DEFAULT_HUNG_TASK_TIMEOUT seconds. To prevent
> log spam during system spikes, sysctl_hung_task_warnings enforces a budget
> on the number of logged warnings.
>
> However, the current implementation has two major limitations:
>
> 1. Permanent exhaustion of warning budget
>
> sysctl_hung_task_warnings is decremented directly when printing
> warnings. Once this budget hits zero, no further warnings are
> reported until an administrator manually updates the sysctl value or
> reboots the system. Consequently, a single temporary hang episode
> permanently blinds the kernel watchdog to any subsequent hung tasks
> after system recovery.
>
> 2. Total log suppression when budget is exhausted
>
> Once the warning budget reaches zero, hung_task_info() completely
> suppresses all output, including the basic single-line alert. While
> suppressing verbose stack dumps and lock debugging is desirable to
> prevent dmesg flooding, hiding basic task alerts leaves
> administrators entirely unaware that tasks are hanging.
>
> This patch series resolves both limitations by decoupling the configured
> warning budget from the runtime warning counter, automatically resetting
> the budget when the system recovers, and keeping basic single-line hung
> task alerts visible.
Thanks. A couple of concerns from AI review:
https://sashiko.dev/#/patchset/20260804202050.262427-1-atomlin@atomlin.com
Apologies if these were considered during review of previous
iterations.
next prev parent reply other threads:[~2026-08-04 23:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 20:20 Aaron Tomlin
2026-08-04 20:20 ` [PATCH v8 1/2] hung_task: Reset warning budget when problem gets resolved Aaron Tomlin
2026-08-04 20:20 ` [PATCH v8 2/2] hung_task: Always print basic hung task info header Aaron Tomlin
2026-08-04 23:05 ` Andrew Morton [this message]
[not found] ` <8443c808-7e1e-45f7-b499-451d8b301c7f@linux.dev>
2026-08-05 14:16 ` [PATCH v8 0/2] hung_task: Improve warning budget handling and task reporting Aaron Tomlin
2026-08-06 2:05 ` Lance Yang
2026-08-06 14:03 ` Aaron Tomlin
2026-08-07 4:40 ` Lance Yang
2026-08-07 14:56 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804160555.7622850f6162aae463714289@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=atomlin@atomlin.com \
--cc=chjohnst@gmail.com \
--cc=david.laight.linux@gmail.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mproche@gmail.com \
--cc=neelx@suse.com \
--cc=nick.lange@gmail.com \
--cc=pmladek@suse.com \
--cc=sean@ashe.io \
--cc=steve@abita.co \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®