From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DC4848CD47 for ; Tue, 4 Aug 2026 17:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863162; cv=none; b=oktKVHnzAvmQT0SekpfCBVKOEu/mC+DEoNJsy+CjNQK0UQdbX4EGKl4XNSjj3QoabE0YNlajcNKNGGeQndKWjT14eF3lpYOwUU4km90o8BU2VrO7PeZ2GkykBURoARYP/d9fT/sAP3Q+pSUYGPZCEv9hdXOkB6s7IXgQVFKAbeA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863162; c=relaxed/simple; bh=fNsiQ4H4dUnXgAib4RUCLYEAN1rBwtnvY4VBYKSLsg8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ALQsYK+O8LieCK+olfOKDF/xEzxo6Mz37gScA8v8MntDLWu7U9aJ6j4HKSJJEEvqWFs/biUscIpIa7GY+1HVvTUFxTo1vu3JosTqtyLJ/P3CxYzph9Rci929e8WjW1pM0U2kyJjd1ei3ve+Cymoxh4Jk/bxgETG0ufSEDJ5wpTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CMy7E6xB; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CMy7E6xB" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c9c26a5fb98so119526a12.0 for ; Tue, 04 Aug 2026 10:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785863149; x=1786467949; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=LksaQirVyyRYvWZqZp8juYzuZLaLOR8yizwcni9laKI=; b=CMy7E6xBOO1aQYEE8K5DYgIp5o/R4VufjYy66Dqx6gXNSvFa19KNSRCDRA1gDebXts oFzQBesyfXBAxikV0nelQk8f5zw/J5ZToA2bvHl5QoBgKCMYPJZauL/xzJBOJxnCq5Wd l7PiASSFQrOgsOQcirgw7kIBaLGQvaiHb4czycw60bNcM3Oy/ssSZnKBv9Nm42bIU85f U48N7XvH0Bp47uBuitftte7R/Be9c4iej5JTK7wuXtNNSQhrFaHJi9OLCA8q+9c/Xe7t gIO0uf1HveC8ceHqBcOev0MznJDl26blyNXhhYwO1DZD93JmneC6TCPZdmaZs1EhSO0p V02Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785863149; x=1786467949; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LksaQirVyyRYvWZqZp8juYzuZLaLOR8yizwcni9laKI=; b=Tb4MxHYeLQcS/FMKH0tbj6+QBf43657c/iC14b4zcXZCJX4pjg/GG69Xjm8U5UF6XT VQ+UR5jCHuX09CJoR91njWSvlZFnARz5j0alnj9klvOFQONM7vxiiTBOt9ronSux1AJU bHuIRq5XuejXiygcmmLt7szYrRsC6BUAT8kKownl9vl+s950t4gHSBHzbVlzmCTcUqpe u+a6zfLDwDiRYt0FOME1qOTPK3xJdmWZLCtlwM0Jo2btJ4X6fhZbFGka8AP6vuPG/L/J cQCSehILlDdCq7Cw4ZvZULIEI9VTjmEyvT0fIT8NbphF+OqSiMjKVWigt50eueZU6VSB kbaQ== X-Forwarded-Encrypted: i=1; AHgh+Rr5lbFrdglYHsj7FdMKwFmclKIrOw4SgS9mxfCPSWPXtjSUhchkBRUbBLOBB9eWODTc6v77kXYh6NbYmjU=@vger.kernel.org X-Gm-Message-State: AOJu0YwKc6bJrN6mXEbwyt/NnloC7A1KKQw4Nf2px5ZBJsfXd10WS7Li NhBCWFVBLs3RXgBS/zloCNyfLWLDtqj9yvEX2eL80PPdwkp+1LyNa339 X-Gm-Gg: AR+sD12+WFXZIhrjPoE5GZFml/8d/3GyW2m0f0Jv6+4fPNaKrKjpJmr6eKveW1cjHWb rkMdLltN5XBqGDeQJpoerlQ+WB2c2+JFWiNX7S7oW/Fseu5pDLgEySPwEP/XaJqztBoXpibQnPP yADFbFLZYtc3cJEY3sxTRlEtXUxnNv7HQBYOeGTmOv2tgLwNiqhEzqOxhMBC17PspZNd5NYzyrz VAi9AAlXLcJIRwN/lBHmXesw0njC+4tysoZMv/Dsq0H4+YHCNbsHEQbMwszjww9cb5Me/G0x2Si gzQmPFLVQWZs/eOQFeEy48sQIPiNS+Tl26cn3bpUrpVaf2IWed1wMOrXKjdyR20w+/WPB5I0zBQ L2vrkLOTpvVHLQ5UFvDFJW+3+60cXaBxCHOR7YnO4ekonJa8DnuQNO03lDFbT94bx9sAmkAzTz0 VM0XXSsgYNzRmuYJ1w28RHiSffRSyri25PiHfit20TMuckyATGpMHEvJmnNRU= X-Received: by 2002:a05:6a20:9392:b0:3c3:75c5:48d5 with SMTP id adf61e73a8af0-3cb6c7536cdmr5854873637.4.1785863149251; Tue, 04 Aug 2026 10:05:49 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:1461:a94d:d559:948d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31586162e80sm7230582eec.0.2026.08.04.10.05.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 10:05:48 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Broadcom internal kernel review list , Markus Elfring , Joshua Crofts , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v5 0/3] iio: adc: bcm_iproc_adc: Simplify probe error handling Date: Tue, 4 Aug 2026 22:35:18 +0530 Message-ID: <20260804170521.196393-1-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid This series simplifies probe error handling in bcm_iproc_adc. Patch 1 removes redundant probe error messages after devm_request_threaded_irq(), where the helper already reports the error. Patch 2 introduces a local device pointer to reduce repetition and prepare for subsequent error handling cleanup. Patch 3 converts immediate-return probe error paths to dev_err_probe() while leaving cleanup paths unchanged. Changes in v5: - Keep Patch 2 focused on introducing a local device pointer with minimal code churn. - Convert only immediate-return probe error paths in Patch 3. - Leave cleanup (goto) error paths unchanged as suggested during review. Those will be converted separately together with the planned devm-managed cleanup using devm_add_action_or_reset(). - Improve line wrapping and formatting based on review comments. --- Mohammad Shahid (3): iio: adc: bcm_iproc_adc: Remove redundant probe error messages iio: adc: bcm_iproc_adc: Introduce local device pointer iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() drivers/iio/adc/bcm_iproc_adc.c | 48 +++++++++++++-------------------- 1 file changed, 18 insertions(+), 30 deletions(-) -- 2.43.0