From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE5E84949E0 for ; Tue, 4 Aug 2026 17:06:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863177; cv=none; b=Sf4Dqmdzi6UU6n1niLJFXUjU1xEhnmgd+BL13WL2BuWgiHBDX7+iz8pE2Gzq3+mY5f8CtGqUjLU5+IF2wN/OTrCodrvKqmhxrlJOiNJjpggJUw3vzF8ao91DQ/TNHfrrAVTnpGRizbI+2iHLpeBYObqOYMz0N89bB59H+76ZNxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863177; c=relaxed/simple; bh=5C7wceqaQFO2f4qXEFx21ohpcplYEZ+eV+kQkbGuCaY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DDAz3MwQuqrF0yODbqpgBDUr4nN5qG6zXtZwIKN5AJsuHok2Kab48GzQXEeBlfTQPCBLVhArFeAzfnMdgjy2rGDk1jY67hFCkcmz8EM8yF0A8KZJ9Kd+uMeADnAkKIPswmCiOppP+6MmpTbp3is/mK7bxQOqU5VNcGkCk8D3Ajw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pSJ2aHsB; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pSJ2aHsB" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-381b831d535so81275a91.0 for ; Tue, 04 Aug 2026 10:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785863159; x=1786467959; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+19O7nuCCtomwWmgwH/WqZ+QVpHVmBP+p+odMSd16YE=; b=pSJ2aHsBgQ6DL5gi6QbaGjTM6rc/bkTS77S7qjXdRm5uyJu3pWNFErW9ATxgfqSJtP Rn1c98RI71BS8AhipDVcryunmUPLsOqtE7P7bGp4FgP6HDJnFxE7x5vQTYoP2FFF6aIH ONPCUwKtWkD0L0aUTMH45QFVirmafiBsCmepw+frY33sJz1gzoAShMD/+3lda3iiQFSE SwkT9jy408zhbg7vQBXSW2NKA1IzB6Vo2am2lCsVAjcLqSk8Ut8IP1gYF6/Nzl0Mq3EY YoJoDmp1Mlk2xBP3yxFe1HYU4N/Zj69RcRakK72f9lHWLNWPXWMDpObS81RLqPbRUw09 h9NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785863159; x=1786467959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+19O7nuCCtomwWmgwH/WqZ+QVpHVmBP+p+odMSd16YE=; b=NfHRTdxImGQVYocIDt9LY9+EIu88XOtkTa0fzVMw88jA+x+0o+JKtMSRDErldim5mp bh+eO5p9+Hh2rNzxCDBBy6qIlYpDu89c62sHFNxv/NE7mThgAivnN0FXqADCVW09o/Sj fVSqGh88hjSihXwUfQFXAT/STCXsKPtYzJupGK3wJnS+FkMzxS7mxEntatx27bqo/HqD eYYcTn/7DJp3uXvmenzrVHnZHlgGdR/vLnjwvg41faCJ/LODnNNUdNhC37vTQ5Av6GlV LZQcVS3Ma8z8CntdqearghLFYjQy5sUclv9A9s8GSSg3X2wk6I2DQtduYLIbuX5q5t/y sC8w== X-Forwarded-Encrypted: i=1; AHgh+RrbkBQnAxi8VqByoTpePMiUB3YPJFf5vN8o/j/XgC4bkZJ/oqk0gUrtrNpSVma7H5OGDYiuO0oyBrx74Xk=@vger.kernel.org X-Gm-Message-State: AOJu0YxIU/2KA5xPFO1L3jKVA/Uv6MRm6oPvvrtZJrScgPL91dZ+FPRG SxFKkiLRY/OxLsevQFghH01+VNl2Egvgk7enthkMjA3rSOd/WiNxWlG/ X-Gm-Gg: AR+sD11d6hA8wUa5FvQ8wwABursTg+4WLhR9MWEf8zwIzuZa3ShTGcDL37U/Z0b3XcM pYL7rxt+/O2UzkuA35TwuihRZC1+NjcpPsKqIzZX6QHIWXavOYUwqsFBFsxbVJ/RWlS6goelSDU oWok4+2kv03rwbEXpgh1swaQZZW0UaJT3onVcxvyvCycgydzvZyiQ6GX5UhScRT+Kq7Hij0/tSU LTvPXYZFjH/0t7zb6wIABg1Xucx0xU69vcCEFGgZyitJRX7HjiTcTUZ9ivOChePlDMZ1NX2BEjO mE6mBbpym2tWhFikV4uxurOqOEUco4WCmQ6REcFKD3ljSaDcXD78d2muPe85mo1AKPQmIMDJZjp mmjOK8eIVVEuyJZsWhH3KMJlw37UmoIVccqu3MW0Pq7YOU4vFbGpifDz92gF9XAusH413hM4VuN n/1slQeek2yppOEQ3+gCG0+1ahQQl2TEkntxs36a9Py7r66gzWMoszs9uYRGA= X-Received: by 2002:a17:90b:5823:b0:38d:dbc7:5178 with SMTP id 98e67ed59e1d1-3903c632441mr378816a91.22.1785863159404; Tue, 04 Aug 2026 10:05:59 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:1461:a94d:d559:948d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31586162e80sm7230582eec.0.2026.08.04.10.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 10:05:58 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Broadcom internal kernel review list , Markus Elfring , Joshua Crofts , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v5 1/3] iio: adc: bcm_iproc_adc: Remove redundant probe error messages Date: Tue, 4 Aug 2026 22:35:19 +0530 Message-ID: <20260804170521.196393-2-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260804170521.196393-1-mdshahid03@gmail.com> References: <20260804170521.196393-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid devm_request_threaded_irq() already logs an error when the request fails, making the explicit dev_err() redundant. Similarly, iproc_adc_enable() already reports failures, making the additional dev_err() in the probe path redundant. Remove both duplicate messages. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c index cf4738b16e62..7c2e2770cd61 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -551,10 +551,8 @@ static int iproc_adc_probe(struct platform_device *pdev) iproc_adc_interrupt_handler, iproc_adc_interrupt_thread, IRQF_SHARED, "iproc-adc", indio_dev); - if (ret) { - dev_err(&pdev->dev, "request_irq error %d\n", ret); + if (ret) return ret; - } ret = clk_prepare_enable(adc_priv->adc_clk); if (ret) { @@ -564,10 +562,8 @@ static int iproc_adc_probe(struct platform_device *pdev) } ret = iproc_adc_enable(indio_dev); - if (ret) { - dev_err(&pdev->dev, "failed to enable adc %d\n", ret); + if (ret) goto err_adc_enable; - } indio_dev->name = "iproc-static-adc"; indio_dev->info = &iproc_adc_iio_info; -- 2.43.0