From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02F284963CC for ; Tue, 4 Aug 2026 17:06:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863197; cv=none; b=PdKshWpIsaruSOH6j52lXo9i4oEOXExMb4kjqhPAXsD4jzwrK5pv0Bu7vWyniThstQTaTCRHUjenoQ8btMdoEF/FXbtaO3dwY9rcVG/FN+Y7va1z+TGGOC6PrruCl9qcDJVB4mB+xXsTNjLJ3tMW3JFV2XdMPI2GkPcWwaw4t5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863197; c=relaxed/simple; bh=aaG3fmxJFvgG+2hFmR/kUuEaeX8ZQwfOcPELccRjOzQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VoLZumlqBZgoiilDVuLTVBgnFZJ/u45EddmtOvHxJ/S6b/uMxmylXTYJNiLWUKdlutKvxYHAH4OzvN1KAIlPi6g31E1kX/VUxnNzlTTdWRfBqnA9ltLwTiD1n/DC+dlNUsPySO5vpvi7rqnjUM22sX9Z7IcWc7oBdg6z1FvE9co= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WBbvmu0C; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WBbvmu0C" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2ceb096e675so1405545ad.0 for ; Tue, 04 Aug 2026 10:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785863180; x=1786467980; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/WxyWYexSwoS0Xhfap20Ecck/ANPlEcZKb1zpjgFsT0=; b=WBbvmu0C6DRhghhkcJl+g0iMqEkLHvApWeA3H/ftbbVto+TQem8J3G7UftYCL3eYeL 8iCzxIvzeDwrABHO81i7X/62hWSHX3s46ZXwFXD6v+Z7bWS9aRmn4DAR26SpRlaX66zm X5+OG4ab10xgzuxB8uHZnKhvrGBkOOCfzq6igx43XdlBNX2S8JaRGqvYeqGvyeKAwuSc gf2LvDM8RhQMDiZpbN5/9ga93uKwSBUdEgOMEYmwGig7FatoODaAz2QHlhrmFLHSOKio m0lnutkD7HrNtdAdFvEW+5YOlU7U5lIbCuvlBkfXGWVHdGIgPi5aOYOBaQE4NDGgPRS8 fWmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785863180; x=1786467980; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/WxyWYexSwoS0Xhfap20Ecck/ANPlEcZKb1zpjgFsT0=; b=diZYc27HIK93IdzTwPfBTZGDlFQB6ighT/kyaP47yevET/m3StIp0Ttf6enxs/4Um+ W+dDtrWxcmKIezMGRndvq8+AICXLYf1K9xFF9RjXK2KGABQOFfOdqSM099CcE3IY1sVq DrzVLzo8gDRyWINRMMWhqy3pfiaMTscEEk2J10ZioaiCFvMuWDtxEvQzaclybcn+dEpK vWxEw8skExfoWPT1NPLg7Lj6k5/Cq+VC8pQ+hHgPpbmOfzq8Gr0fvWDgwxj3fTScvRfO 9Hw4yIs2Ea6SYLublMxltIcFHbxSEzOeiZH0N9EC0ZMIVUdif1NQ66EEhNkIw1TDNdpj eisw== X-Forwarded-Encrypted: i=1; AHgh+RqHz/qK/sw258LRHXGGR8omm5TpGEe3AA9UPny3YyhovfA3KU31q6RWdffnUVO2U3kBDdhQmpktcpYOySk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+wojvEBVONPD6wIbmZc35svYWlil2MQOkU6bi4/M9/334pAqa C3BWKk5S9o8WsPlPUCg1Kj4GOiKTcF7DVDZ7JUjivC2CQEQoTHHPF9Kk X-Gm-Gg: AR+sD12zkapjMNcu3cN7F34GTEF3/hQN04stEqualWzVdfuk4k2N1hsoThUkkz2EApx Dr7xfujHdRDPNGPlJmYCc+0CpUYhdwhTmdkeKbQn8MWbIfGR7dzCDnye24wCVm0XYN4ABbhjdJ1 BT1FJcTAuXZ9q6kZY1gqDgCArPi88tJVTAivC7BBBeeug1UfNi03A+oMxK98psM7Dm8h2b6O7kI Zim+iW6jt4tFxoRs/PometnRTSdtxsbs3tVSbxXfLPtPFK+8kdOAwxyqmX4lQtUglJwRUt0QqM/ ZGL+BBygmGbJbDWW0KP1OsPCYT6rq/CZM0odWiDRclfJdxFpU+yDgXXGZ55nC1fFiBXpmlZ+1n/ woodWA4OayceXCBl/fXFRn4mdEFrZuHNFandAf3wCMVy7ae9eF2rYZi0nyDkiu3f2urDNv9/e8Z BMJlYU0m+RJQZZbfzm2Q/yKSkglmLQpDe4Af8iGMcY+pIPb5PRhmho739kGqAJ82zr+/+fUdfna 2i3sFPy5A== X-Received: by 2002:a17:903:2b0d:b0:2ce:faa6:7cbb with SMTP id d9443c01a7336-2d0ca7afcc1mr2775625ad.4.1785863180300; Tue, 04 Aug 2026 10:06:20 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:1461:a94d:d559:948d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31586162e80sm7230582eec.0.2026.08.04.10.06.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 10:06:19 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Broadcom internal kernel review list , Markus Elfring , Joshua Crofts , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v5 3/3] iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe() Date: Tue, 4 Aug 2026 22:35:21 +0530 Message-ID: <20260804170521.196393-4-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260804170521.196393-1-mdshahid03@gmail.com> References: <20260804170521.196393-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid Replace open-coded dev_err() followed by return with dev_err_probe() for probe failures that immediately return. Leave error paths that jump to cleanup labels unchanged to reduce code churn. These paths will be converted separately together with the planned devm-managed cleanup using devm_add_action_or_reset(). Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 31 ++++++++++++------------------- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c index 312be7c12e58..9238dc8c8873 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -522,18 +522,14 @@ static int iproc_adc_probe(struct platform_device *pdev) adc_priv->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "adc-syscon"); - if (IS_ERR(adc_priv->regmap)) { - dev_err(&pdev->dev, "failed to get handle for tsc syscon\n"); - ret = PTR_ERR(adc_priv->regmap); - return ret; - } + if (IS_ERR(adc_priv->regmap)) + return dev_err_probe(dev, PTR_ERR(adc_priv->regmap), + "failed to get handle for tsc syscon\n"); adc_priv->adc_clk = devm_clk_get(dev, "tsc_clk"); - if (IS_ERR(adc_priv->adc_clk)) { - dev_err(&pdev->dev, "failed getting clock tsc_clk\n"); - ret = PTR_ERR(adc_priv->adc_clk); - return ret; - } + if (IS_ERR(adc_priv->adc_clk)) + return dev_err_probe(dev, PTR_ERR(adc_priv->adc_clk), + "failed getting clock tsc_clk\n"); adc_priv->irqno = platform_get_irq(pdev, 0); if (adc_priv->irqno < 0) @@ -541,10 +537,9 @@ static int iproc_adc_probe(struct platform_device *pdev) ret = regmap_clear_bits(adc_priv->regmap, IPROC_REGCTL2, IPROC_ADC_AUXIN_SCAN_ENA); - if (ret) { - dev_err(&pdev->dev, "failed to write IPROC_REGCTL2 %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "failed to write IPROC_REGCTL2\n"); ret = devm_request_threaded_irq(dev, adc_priv->irqno, iproc_adc_interrupt_handler, @@ -554,11 +549,9 @@ static int iproc_adc_probe(struct platform_device *pdev) return ret; ret = clk_prepare_enable(adc_priv->adc_clk); - if (ret) { - dev_err(&pdev->dev, - "clk_prepare_enable failed %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "failed to enable clock\n"); ret = iproc_adc_enable(indio_dev); if (ret) -- 2.43.0