From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 268FF3AAF41 for ; Tue, 4 Aug 2026 21:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785878386; cv=none; b=eij6nR61R1svJW+85XkFKHAOeZHR9LW+WwYAdpd2QpTpYwtS0MYUhK5YMhhsBmFutS8o1h0qLHYbo4P1xZrpphZb8/R3dECx7m1oku8z8qdkaJxkSh1rqBb8qI2/Zqs0FOiO3LQNodj6771OLnwJPsHuSs4u2pUfOD6Lh32i61w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785878386; c=relaxed/simple; bh=/AMjJkwmXepaiNPW211uL4M2QxKkm9iBVQbvs9W65Lk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kVnuehe5Yt0yAjJ+IzY3zi74WRYjlIL5uW2wmkP+RCuzduqpZqXWfBLd9jiuv4yJVHexkDy8hrccEA51ydH9dg62x9bxVm2g40SdXJ5bTOVES6JrsHnojlDfFVnEhQplB/VsOq3P1tvNAoGzeWoRLl29PgGPAQPCgkDptxtLqo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=R6l+Wsnx; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=V4+MKVhq; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R6l+Wsnx"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="V4+MKVhq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785878384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iEFMTqOdO4uNqL8QNG/Z4Re63pCP40xKpdmxCirFV8A=; b=R6l+WsnxGTNczYMr2KWrd3bkP1lGsNmcETeVn3KMaX2zbanFJlCI4RKCJ/J8yvlJ/OVCxt trEENWVgwIo9cqI13OCGpNZBz9db9x09K6nEQB8JAxKQPHrv1xuG/pPAMZ7ZzfI8rWH+d1 WUN439pxzMnGDW5P/R8ioOVSelkj49c= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-497-CXW1vTaTPSGvaCXRX57PqA-1; Tue, 04 Aug 2026 17:19:42 -0400 X-MC-Unique: CXW1vTaTPSGvaCXRX57PqA-1 X-Mimecast-MFC-AGG-ID: CXW1vTaTPSGvaCXRX57PqA_1785878381 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-49564d4b849so743035e9.3 for ; Tue, 04 Aug 2026 14:19:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785878381; x=1786483181; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=iEFMTqOdO4uNqL8QNG/Z4Re63pCP40xKpdmxCirFV8A=; b=V4+MKVhqBVrsagi+VYZ7lrrKhhYBp4hfh4MI66h59Y4biKR7PD9WsIrqrZ1w6phUzp fDja7nliz4vJf2Glj52wGo8NsdSQByi2f6mcofhD9orVWFMGVYAu/Gr2PSkQHFgIb33S +5gEuyRneNXUd882FXE52Nkhxxr8KPEIW8ANF7vgwIeliuKyZPMdMQwBIw7vtXvgDtWs 1JIEcUPkfGtz2uqpDfhT0rmAcYafNCNxhpivBylvu1K+xhSctbHH5q6yK/GtaUNtgOpU ML5IyaIj+i6ITJw0GOTuRlK2Lv8KQexLOf+mv+u2ZPXHHMWrAlojm+YumEBscUj5hJIU rQWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785878381; x=1786483181; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iEFMTqOdO4uNqL8QNG/Z4Re63pCP40xKpdmxCirFV8A=; b=W89lFje69YnL7OUG9Z/pNYo1PTA6FQCtK5HkhCo9wwysb+WjUZN6UdCbiShNQpfQAZ DMdD1nc1J9k1nK0wlShUNAR0+n7S9ZdFnPJzT22c9Mi40+Eg6IIE4Q2vrmyd/waqqzrE AtgZctYWaKa9kzusIjmXTi4T96KFpr0AH41iMfpLgQepmZgfavumooebbq7O0oJhb4wl hJr/X6giSCt9iZVjEzTn8S35B/nhKsuCdROeu8jSeSTPiHpoYwY3R3Urrmy43UZYm9Gz GPMzJ29qIOUoL2+yKQnKz90rJ7NllqC38U9/LND++eUiC+fk1MA8C2T+JFi4miiWY45b O1gQ== X-Forwarded-Encrypted: i=1; AHgh+RrbFIbr5zKGdd9tZ5Nj1ehgJiXUma6HSCKPBqroahDqG8VF+8MEMjOBKC47Xu2ZijLjWsgxOw7k/43h5rI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/fMJswUE9YNLPXI4waoRx3Zoq2cwEthoieeay00iWH0Lu9l5A 1yIisc5MEeboDI9WwihZBMJVR1cgoj7W7daRAFXI70/wPL55jOeUSbEpMbyRuVDwGJBXavoOd3C DDNXVNSjHAVyEqvPeENNeI4y4TvMucQruS3PHIN7wW3P5cKskIrOhphTR5LW0Axrd4A== X-Gm-Gg: AR+sD12F+IblrgGQh5stcISA4ULpaxr0tHMjJhTatGvCnH69yYQv8oWQQvF4tfgH0My 6kIIce7hBRmLK9YpKGAhR36QTzuEoK0ZvVwwyGyCPwyxfzXiUoAyXMz2NMSLZ90bNpySwFsqj5l 8SZJbvS1ZfuiLQ7nVKRsft5ojU9X+WUqT7LYa0Hax2RV9/EKeB3pRK983XkKhliEiur9KA3n2pH JWYhJYNshYwc8afwIeqnLIfzTrDJDjEMwaHQ7QovHPYg/fSLGQxdXomY4KwbumMIyivmFV1LsHF li61PHl49v+3ky2r+Y1USWk/sNb+VtpXEdkddYyJt2QTuj9L1AshFiskeVUZLEbyTnoQp6QK97V ZxmPOkg3bqwMP1clcfdiZ2Q== X-Received: by 2002:a05:600c:35d0:b0:496:c93d:e2f with SMTP id 5b1f17b1804b1-4994e7c5ca9mr10783875e9.15.1785878381454; Tue, 04 Aug 2026 14:19:41 -0700 (PDT) X-Received: by 2002:a05:600c:35d0:b0:496:c93d:e2f with SMTP id 5b1f17b1804b1-4994e7c5ca9mr10783355e9.15.1785878381053; Tue, 04 Aug 2026 14:19:41 -0700 (PDT) Received: from redhat.com (IGLD-80-230-28-14.inter.net.il. [80.230.28.14]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994dfda45asm41924895e9.4.2026.08.04.14.19.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 14:19:40 -0700 (PDT) Date: Tue, 4 Aug 2026 17:19:37 -0400 From: "Michael S. Tsirkin" To: Xiong Weimin Cc: Alvaro Karsz , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vdpa: solidrun: Free IRQs after request failure Message-ID: <20260804171850-mutt-send-email-mst@kernel.org> References: <20260804092617.1344317-1-xiongweimin@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260804092617.1344317-1-xiongweimin@kylinos.cn> On Tue, Aug 04, 2026 at 05:26:17PM +0800, Xiong Weimin wrote: > Unwind any IRQs already requested by snet_request_irqs() before returning > an error so a later retry starts from a clean state. > > Signed-off-by: Xiong Weimin Here too. Pls tell us what is wrong and how it is fixed. E.g.: Currently .... This is a problem because ... We can not do .... because ... To address .... And then .... > --- > drivers/vdpa/solidrun/snet_main.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/vdpa/solidrun/snet_main.c b/drivers/vdpa/solidrun/snet_main.c > index 28d55315d..aa3ae3876 100644 > --- a/drivers/vdpa/solidrun/snet_main.c > +++ b/drivers/vdpa/solidrun/snet_main.c > @@ -407,7 +407,7 @@ static int snet_request_irqs(struct pci_dev *pdev, struct snet *snet) > snet->cfg_irq_name, snet); > if (ret) { > SNET_ERR(pdev, "Failed to request IRQ\n"); > - return ret; > + goto err_free_irqs; > } > snet->cfg_irq = irq; > > @@ -418,11 +418,15 @@ static int snet_request_irqs(struct pci_dev *pdev, struct snet *snet) > snet->vqs[i]->irq_name, snet->vqs[i]); > if (ret) { > SNET_ERR(pdev, "Failed to request IRQ\n"); > - return ret; > + goto err_free_irqs; > } > snet->vqs[i]->irq = irq; > } > return 0; > + > +err_free_irqs: > + snet_free_irqs(snet); > + return ret; > } > > static void snet_set_status(struct vdpa_device *vdev, u8 status) > -- > 2.43.0