From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 908C3413799 for ; Tue, 4 Aug 2026 21:23:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785878592; cv=none; b=nZIiwjJGjbpN6IAZIju8Ryz317SgG5E3FVblDo9BKIWOLEaCEntisBj9576LvO72qAclX3lFccl6OTcokSvxuwIDdrbzRl11Pq9E8mM62Fwxjs0d/MEmmLgBA4JxUiqMxmhBMP/L4cit9+hsmDfQEWowSsPc1p+m/wTQTMsiJsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785878592; c=relaxed/simple; bh=MuiEg9wanhQYi6utuDkaViH6kGx3NTrf8+035iX5pB0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L8P8Y4Kr7oMnIEYfiwMfD2OOawjoQORFv76hZ1z9dpcq1n1MC+s3lFz13UQDd1rmrgE7e/ThRxGNnYyyytPfRQGCv9l0GppZq7ZlGfOAwFHD+lUfWoiqgOw3ESIOgJXTdZqso7ecCFs3Y/EpBQKFTEVugbMzoBqJJmTIsIi0xQY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y338Qsh5; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=CUVbDw94; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y338Qsh5"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="CUVbDw94" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785878589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mGRg7FrOnjzxfTeNQiRd91leYz4HQZQa6zj2yMXk614=; b=Y338Qsh5w4EUL8s8ZH6Gvy9bxAhkLJ/yOUh6ejYdRsC8VWjVG3x1uJqSCEmgoYf4AFnT1f OMburevgP2BF0fkJbNLCIdfHwTlPB1IgvbjpItNotmCjB3tnad9sA7K0kyB6PjkZKjYeOl y0Qt6vsy9wSQ8DLmyZtXOEph/ZC49yI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-390-uX-8xOY0O6uFboVC6kXeIg-1; Tue, 04 Aug 2026 17:23:03 -0400 X-MC-Unique: uX-8xOY0O6uFboVC6kXeIg-1 X-Mimecast-MFC-AGG-ID: uX-8xOY0O6uFboVC6kXeIg_1785878582 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4955ce558d8so1900755e9.3 for ; Tue, 04 Aug 2026 14:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785878582; x=1786483382; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=mGRg7FrOnjzxfTeNQiRd91leYz4HQZQa6zj2yMXk614=; b=CUVbDw942WK6hCkO6HM2KEn66rGtueX+o2XlSlUGXNWQ4x0d1csKEhUFGTaPFytjg1 rbegfq4aFpkwORsprkj9SaC9uJQL6IU+cIr8ASfQkMu7QxLl0Y/nUSVMXtYVsWZXdsOF IHHvYcbMDMPfWp9UMwtmwCG6pncDd9Mm0PL2kMVg8DzeD939maST8ve5LkygkSIhdxS/ Glc8O2sAvXS75O/HdGwoY7lU0m2yc6pz3CdxnF6jIXnwaCEVoxgYu4tXdhsYES0LqXwe +OkFVCw6B5nrY9oAn9xEjNRJJUep55un/jH2FAg8z48Q2Km+VVDLgYToz+8K8dZYA3NU Sayg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785878582; x=1786483382; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mGRg7FrOnjzxfTeNQiRd91leYz4HQZQa6zj2yMXk614=; b=lH3oiSBzwNASJgOYw1l+kBnhHrEU5Msrwmd8/WGknnDpb1iDaIoplqhl6OsXBdvkAw uHkRgf+3Mspb+iQl/6c88du7BmnaD38fSaZ71RZPu9U5Dv/HpZBS2chzVre2x/mOQpyZ LB8X0o8tLLT+txSG3+Ixt22rzthXWhapw1T5AM/UPHY8233CYAyqM2W4HTeU2oiNDD0c P8xcznuNtX5Ialps9Pc4kYW2AAqbqFrIcigAamaegWlaASVyRGw/rv/lbuiRIXoNwwH/ JiA4SHD7yGGrgVUXpQVc0DflcNRFgQu/U7hKy4e2ATNpJfkqgVS4SaBVEZEsL66W9NMY dr8Q== X-Forwarded-Encrypted: i=1; AHgh+Rr67oL4IHVdoRQ1MaRnyA5Fb7lnbny/G5ytNkuLsZ58rdKoBqUmTBwgtyJ+v9Sx+IXspA1HlO04iIXg+1g=@vger.kernel.org X-Gm-Message-State: AOJu0YwLS+vzSaPqoSBjTW389ItIOpSD7UJ147+K2aOOYZgAW7xBjULy 97VOnO2FRZw1LJvZvhNDC7QrROGFVLvIiU4n2CGBBPgFGaxvVN4HYHtczwynqJ7V8WTf0bvWgoQ IgSLiIXhVVCLCKx3Hm7PsNiAvROftH1ZozVf7/pcwd9OtqUNcKer8bI12iP1SmfhUYg== X-Gm-Gg: AR+sD12ifDs2Z5uU+eUyOsIVSIip45ZaklbENq/RMgoAdoSFYpY5TildF/g230G948U oR9bz6zRtBM7yZEkty7zztgGxICe6cTvSmAN9BUlj3b4Jzt1/JHt7aI/xXd9y8yZPocjQatwbsx 5/JWxEuv1v8sYFaEG6KuXG0sh5Cy8n3nabPgBzXCtP90ZLK/8TTWGkr+lymRh8MQoJBJ85rESY5 Ds7T1TAQwb0X40XkBwM7dzxFijX1UJqkKmyzFsBBeukobrFpEos0SawUSjZGn8qMYKI2IDq93lh PBSgudfGtSmkPCgkrEdMdRrj8R/wwqj+TlGs42UlBpCvWgMvhBh4DP5d13voq0dbXJVYgoFkn78 EnGjHFF/bQSe2HT1IXgiUSQ== X-Received: by 2002:a05:600c:8b23:b0:495:4d00:2fc0 with SMTP id 5b1f17b1804b1-4994e7bb12dmr12639375e9.12.1785878581688; Tue, 04 Aug 2026 14:23:01 -0700 (PDT) X-Received: by 2002:a05:600c:8b23:b0:495:4d00:2fc0 with SMTP id 5b1f17b1804b1-4994e7bb12dmr12638885e9.12.1785878581251; Tue, 04 Aug 2026 14:23:01 -0700 (PDT) Received: from redhat.com (IGLD-80-230-28-14.inter.net.il. [80.230.28.14]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949f68f95sm138651955e9.0.2026.08.04.14.22.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 14:22:59 -0700 (PDT) Date: Tue, 4 Aug 2026 17:22:56 -0400 From: "Michael S. Tsirkin" To: Xiong Weimin Cc: Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] virtio-vdpa: Use queue id when setting vq affinity Message-ID: <20260804172230-mutt-send-email-mst@kernel.org> References: <20260804092649.1344478-1-xiongweimin@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260804092649.1344478-1-xiongweimin@kylinos.cn> On Tue, Aug 04, 2026 at 05:26:49PM +0800, Xiong Weimin wrote: > When optional queues are skipped, pass the compressed vDPA queue id to > set_vq_affinity() so affinity is applied to the queue that was actually > created. > > Signed-off-by: Xiong Weimin explain what the problem is please. don't just hint. > --- > drivers/virtio/virtio_vdpa.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c > index de2af696d..6bcf4567a 100644 > --- a/drivers/virtio/virtio_vdpa.c > +++ b/drivers/virtio/virtio_vdpa.c > @@ -352,7 +352,7 @@ static int virtio_vdpa_find_vqs(struct virtio_device *vdev, unsigned int nvqs, > continue; > } > > - vqs[i] = virtio_vdpa_setup_vq(vdev, queue_idx++, vqi->callback, > + vqs[i] = virtio_vdpa_setup_vq(vdev, queue_idx, vqi->callback, > vqi->name, vqi->ctx); > if (IS_ERR(vqs[i])) { > err = PTR_ERR(vqs[i]); > @@ -360,7 +360,8 @@ static int virtio_vdpa_find_vqs(struct virtio_device *vdev, unsigned int nvqs, > } > > if (has_affinity) > - ops->set_vq_affinity(vdpa, i, &masks[i]); > + ops->set_vq_affinity(vdpa, queue_idx, &masks[i]); > + queue_idx++; > } > > cb.callback = virtio_vdpa_config_cb; > -- > 2.43.0