From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f10.google.com (mail-wm2-f10.google.com [74.125.225.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47837486B9B for ; Tue, 4 Aug 2026 18:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.138 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785867685; cv=none; b=s9pV0zMlqEyJG4BpbUhFx5WKIJJXgm4vcmFnEqC84ip5Ieuuo2BQbkpZi5I4UadGjf1KfDeJXkrXFG3q6S7du91Xl8m7U5zMfO6qryMxVG44g6XSJAN/gZGwkAdjNpo1K8nYpWYKcyhjDDOLoCuCg/EGCHyceQczNGRCju2Zx7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785867685; c=relaxed/simple; bh=E18ZmlhKx2vZXzjAGq28ZhHz6/Zwk9XVloSjEWzAZ1k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WWIG45+9OTyMX2FIw7fYIUf1Si1xSxTG4CWuMkdW+zu2hY60VNRje3VE5ukp7970HRr/saLnWyvPFLN1jWBodOZK8fg7S6cBRnYjMN1ohmRXFEuDbE7zK/pwZfopLfJuazQ2Y46CDsorTPs6U3GFQMYH9SZ6tpJJKLD81EjUXrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ovn.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=74.125.225.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ovn.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm2-f10.google.com with SMTP id 5b1f17b1804b1-495459712d2so231435e9.1 for ; Tue, 04 Aug 2026 11:21:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785867681; x=1786472481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=oZeQlNjOge6WMVv6WVdFf9fbDLHuWnzd1YmpbjrG1hA=; b=Zd01AP0RuD7BW1xKakVk/Vg/cZPBHSxUPsCrxsUp6i/vlXFbL7vtu2pXBHd4cQ8cUT 1eUKKsb1ZzP9icvNEi24VibzQNsyFaaV/Jf354Hn1U/o72mDUetiq4ONVxCbQ382oHU8 oPucwLcnBR0xzmwUOoUrXo8Skfv7lBQwTIf9wPpoEnFWTqnZHvT6y0IkF1EWWjb4B5Ay BVnwzhGm89W4Kr10euxZv2whx3WTCCsH4UTZ7oSECHbiZ9WMzH8JCXMA7Yp7bgzg41FJ DzU7XqU4FnfVVAmoFeBQmZ+xsis8WV8eW3Ofxdt8W41YDewb2E/TIyRGJEr7WgDzzhHE BzGA== X-Forwarded-Encrypted: i=1; AHgh+RreAbmus/enDf3OKPfpLj/rlMqH2UlfsMNUui0kb6ClAaeTnQf+mlUvCJq6tlzOT+DJBGRp6EAXhlfUpMM=@vger.kernel.org X-Gm-Message-State: AOJu0YwPs2zZhRdrCyiMuJm3PLf9IgPoFVmMlJgMyqN/CDW9ePHxgJcY 5dRme5fNrY18AAVzeqh0twvi74KF8tIJFpPJ38LPiXAKXw1vmsb9FNj0 X-Gm-Gg: AR+sD132zteL4rrzzbx442CLPj5a0DMj35uJxPEE0alTJVTe2k80ETffDKS/P0S2uDu aiobs0YNWJDROSE44E5Hx2nMveuZjdlxC//zOUy0781kMIoSwfN9fm/NrLgjOBwlZtycQSpVcYj i9hEvH68gI0oxTa28nkYSrd0tFgoxFk3jr9QC31U83CX/QCoruAqhnadAJzPYB3PWDmCmv4FhVk rigcKwliavh3pcLheWxfR+qoXBQPHZCZgPXhz23fmmefp7a/d8VA7yAz6DhRcQgQVRJlHlbeeHM lz9RGthZq3SQSxgsglbunbqze4g56jY4ktpgX9NvOL/LKjmx7PMCJaIXiUku4/2bAuBM/VtfrHQ k+xbnnOGGFYLh5U/dZ/pc7eIQ7RR/cwiVkQ9W0zTt7BX0xsqlcmqXMmJ4nPKCTfBUN/6BVTtBPO yvwVgZRFRLBJq031x8Y3pwtQpljNlFMRScsGZ2eQ9XsBSj12GdJjE76txvPyKKqdnMAu7IQAq0z 4TWtKbmFHdCEY3lPI9tjhEUhCUukg== X-Received: by 2002:a05:600c:4fca:b0:496:c2fd:1731 with SMTP id 5b1f17b1804b1-4994e711309mr3148375e9.1.1785867681458; Tue, 04 Aug 2026 11:21:21 -0700 (PDT) Received: from im-t490s.redhat.com (78-80-108-129.customers.tmcz.cz. [78.80.108.129]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994e4bf5c1sm4946925e9.2.2026.08.04.11.21.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 11:21:21 -0700 (PDT) From: Ilya Maximets To: netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Aaron Conole , Eelco Chaudron , David Ahern , Ido Schimmel , Shuah Khan , Kuniyuki Iwashima , Nikolay Aleksandrov , Fernando Fernandez Mancera , Antoine Tenart , linux-kernel@vger.kernel.org, dev@openvswitch.org, linux-kselftest@vger.kernel.org, Ilya Maximets Subject: [PATCH net-next 6/6] net: vxlan: remove unused vxlan_dev_create Date: Tue, 4 Aug 2026 20:20:40 +0200 Message-ID: <20260804182049.2289754-7-i.maximets@ovn.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260804182049.2289754-1-i.maximets@ovn.org> References: <20260804182049.2289754-1-i.maximets@ovn.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The vport-vxlan in openvswitch was the last user and it is now gone. And we can now rename the internal function to have a better name. Signed-off-by: Ilya Maximets --- drivers/net/vxlan/vxlan_core.c | 42 ++++------------------------------ include/net/vxlan.h | 3 --- 2 files changed, 4 insertions(+), 41 deletions(-) diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c index 25e3fe1ee751..fd5505153d0b 100644 --- a/drivers/net/vxlan/vxlan_core.c +++ b/drivers/net/vxlan/vxlan_core.c @@ -3966,9 +3966,9 @@ static int vxlan_dev_configure(struct net *src_net, struct net_device *dev, return 0; } -static int __vxlan_dev_create(struct net *net, struct net_device *dev, - struct vxlan_config *conf, - struct netlink_ext_ack *extack) +static int vxlan_dev_create(struct net *net, struct net_device *dev, + struct vxlan_config *conf, + struct netlink_ext_ack *extack) { struct vxlan_net *vn = net_generic(net, vxlan_net_id); struct vxlan_dev *vxlan = netdev_priv(dev); @@ -4416,7 +4416,7 @@ static int vxlan_newlink(struct net_device *dev, if (err) return err; - return __vxlan_dev_create(link_net, dev, &conf, extack); + return vxlan_dev_create(link_net, dev, &conf, extack); } static int vxlan_changelink(struct net_device *dev, struct nlattr *tb[], @@ -4700,40 +4700,6 @@ static struct rtnl_link_ops vxlan_link_ops __read_mostly = { .get_link_net = vxlan_get_link_net, }; -struct net_device *vxlan_dev_create(struct net *net, const char *name, - u8 name_assign_type, - struct vxlan_config *conf) -{ - struct nlattr *tb[IFLA_MAX + 1]; - struct net_device *dev; - int err; - - memset(&tb, 0, sizeof(tb)); - - dev = rtnl_create_link(net, name, name_assign_type, - &vxlan_link_ops, tb, NULL); - if (IS_ERR(dev)) - return dev; - - err = __vxlan_dev_create(net, dev, conf, NULL); - if (err < 0) { - free_netdev(dev); - return ERR_PTR(err); - } - - err = rtnl_configure_link(dev, NULL, 0, NULL); - if (err < 0) { - LIST_HEAD(list_kill); - - vxlan_dellink(dev, &list_kill); - unregister_netdevice_many(&list_kill); - return ERR_PTR(err); - } - - return dev; -} -EXPORT_SYMBOL_GPL(vxlan_dev_create); - static void vxlan_handle_lowerdev_unregister(struct vxlan_net *vn, struct net_device *dev) { diff --git a/include/net/vxlan.h b/include/net/vxlan.h index 6e64757151b8..7b8207505523 100644 --- a/include/net/vxlan.h +++ b/include/net/vxlan.h @@ -359,9 +359,6 @@ struct vxlan_dev { VXLAN_F_MC_ROUTE | \ 0) -struct net_device *vxlan_dev_create(struct net *net, const char *name, - u8 name_assign_type, struct vxlan_config *conf); - static inline netdev_features_t vxlan_features_check(struct sk_buff *skb, netdev_features_t features) { -- 2.55.0